Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031480 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | have not tried | 2015-11-14 13:24 | 2015-11-23 08:27 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 3a7faced04fe | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031480: Remove all unnecessary casts in code (except Sqlc generated code) | |||||||
| Description | Cleanup extra casts in the code which are not needed and clutter the code when trying to read it. | |||||||
| Steps To Reproduce | i.e. optional Eclipse warning 'Unnecessary cast from XX to YY' | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0081908) hgbot (developer) 2015-11-16 19:18 |
Repository: erp/devel/pi Changeset: 3a7faced04fe6a5caecbe102264df41fb0189a3d Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sat Nov 14 13:26:10 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/3a7faced04fe6a5caecbe102264df41fb0189a3d [^] Fixed 31480: Remove unnecessary casts in code A few distinct patterns: - Cast from XX directly to XX just not needed at all - sometimes from .uniqueResult() - somtimes from i.e. reading from typed Map - Cast from Object to XX then passing to API using object anyway i.e. result of .uniqueResult() then passing to Restrictions.eq - some misc ones like DalUtil.getId to String when not required --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java M src-test/src/org/openbravo/test/role/inheritance/RoleInheritanceTestUtils.java M src/org/openbravo/costing/CostingMigrationProcess.java M src/org/openbravo/event/GLJournalLineEventHandler.java M src/org/openbravo/role/inheritance/InheritedAccessEnabledEventHandler.java M src/org/openbravo/role/inheritance/RecalculatePermissionsHandler.java M src/org/openbravo/role/inheritance/RoleInheritanceEventHandler.java M src/org/openbravo/role/inheritance/RoleInheritanceManager.java M src/org/openbravo/role/inheritance/access/AccessTypeInjector.java M src/org/openbravo/role/inheritance/access/FieldAccessInjector.java M src/org/openbravo/role/inheritance/access/TabAccessInjector.java --- |
|
(0082053) alostale (viewer) 2015-11-23 08:27 |
code reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-11-14 13:24 | shuehner | New Issue | |
| 2015-11-14 13:24 | shuehner | Assigned To | => Triage Finance |
| 2015-11-14 13:24 | shuehner | OBNetwork customer | => No |
| 2015-11-14 13:24 | shuehner | Modules | => Core |
| 2015-11-14 13:24 | shuehner | Triggers an Emergency Pack | => No |
| 2015-11-14 13:24 | shuehner | Relationship added | blocks 0031477 |
| 2015-11-14 13:24 | shuehner | Assigned To | Triage Finance => shuehner |
| 2015-11-16 14:01 | shuehner | Review Assigned To | => alostale |
| 2015-11-16 19:18 | hgbot | Checkin | |
| 2015-11-16 19:18 | hgbot | Note Added: 0081908 | |
| 2015-11-16 19:18 | hgbot | Status | new => resolved |
| 2015-11-16 19:18 | hgbot | Resolution | open => fixed |
| 2015-11-16 19:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/3a7faced04fe6a5caecbe102264df41fb0189a3d [^] |
| 2015-11-23 08:27 | alostale | Note Added: 0082053 | |
| 2015-11-23 08:27 | alostale | Status | resolved => closed |
| 2015-11-23 08:27 | alostale | Fixed in Version | => 3.0PR16Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |