Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030032 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2015-05-27 16:02 | 2015-06-17 20:06 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | aaroncalero | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR15Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | a5c25afa2d03 | ||||
| Projection | none | ETA | none | Target Version | RR15Q3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2014-08-02 | |||||||
| Regression introduced in release | RR14Q4 | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/67efd2776999 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030032: Pay button is enabled in the Receipt discounts tab, and allows the user to enter a wrong state in the Web POS | |||||||
| Description | When the Receipt discounts tab is enabled, all the buttons in the toolbar should be disabled, to force the user to either apply a discount, or close the tab. However, the Pay button is enabled, so the user can mistakenly enter a wrong state, in which most of the Web POS is disabled, so the user becomes stuck and the only option is to refresh the window. | |||||||
| Steps To Reproduce | - Log in the Web POS - Add some products to the ticket - Go to Receipt Discounts option in the menu - Realize that the Pay (total) button is enabled. This is not correct. - Click on the Pay button. Realize that you are now in an incorrect state, the menu is disabled, and you basically can only pay, but if you do you are still in this incorrect state, and the only solution is to refresh the page. | |||||||
| Proposed Solution | - The Pay button should be disabled in the Receipt discounts tab, like it was in 2014Q3 release. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0077881) hgbot (developer) 2015-05-29 09:14 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 41c037b78e4f437ce8e90a8ed4896974e8e2286f Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri May 29 09:01:34 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41c037b78e4f437ce8e90a8ed4896974e8e2286f [^] Fixed issue 30032: Pay button is enabled in the Receipt discounts tab The problem was that the Synchronization Helper was sending 'synchronized' events while the discounts tab was open, enabling the button. A check has been added to disable the button (or keep it disabled) if a request to disable it has been done, or if the this.isEnabled attribute is false (meaning that the toolbar has been disabled). --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js --- |
|
(0077883) Orekaria (administrator) 2015-05-29 09:54 |
That method was refactored to be able to log the status of the button each time that it is called With your changes for that special cases (are not all special?), we will no longer be able to log why the button has been disabled which, as said, was the only reason to refactor the method Please add the exceptions to the requirements object and be sure that, in the line 275, the error log is not shown with those 2 requirements |
|
(0077889) hgbot (developer) 2015-05-29 12:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a5c25afa2d03d167b2fa6a8b01d9efe8f554081b Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri May 29 12:47:57 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5c25afa2d03d167b2fa6a8b01d9efe8f554081b [^] Fixed issue 30032: Pay button is enabled in the Receipt discounts tab Refactored the way the function checks the isDisabled parameter and the this.isEnabled attributes to be used within the requirementsAreMet function. Added several comments. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js --- |
|
(0077896) dmitry_mezentsev (developer) 2015-05-29 13:55 |
http://wiki.openbravo.com/wiki/Bug_Reporting_Guidelines#How_to_Choose_the_Right_Severity [^] |
|
(0078338) Orekaria (administrator) 2015-06-16 23:27 |
Added 'I30032_PayButtonWithDiscretionaryDiscounts' test |
|
(0078350) hgbot (developer) 2015-06-17 20:06 |
Repository: tools/automation/pi-mobile Changeset: e003430ab8f3ed5c269a705429d0c9fd5780fb24 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Thu May 28 12:10:18 2015 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e003430ab8f3ed5c269a705429d0c9fd5780fb24 [^] Related to issue 28933, verifies issue 30032: Added 'I30032_PayButtonWithDiscretionaryDiscounts' test --- M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/paybutton/I30032_PayButtonWithDiscretionaryDiscounts.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-05-27 16:02 | marvintm | New Issue | |
| 2015-05-27 16:02 | marvintm | Assigned To | => aaroncalero |
| 2015-05-27 16:02 | marvintm | Regression level | => Production - Confirmed Stable |
| 2015-05-27 16:02 | marvintm | Triggers an Emergency Pack | => No |
| 2015-05-28 01:02 | marvintm | Status | new => scheduled |
| 2015-05-28 12:36 | aaroncalero | Regression date | => 2014-08-02 |
| 2015-05-28 12:36 | aaroncalero | Regression introduced in release | => RR14Q4 |
| 2015-05-28 12:36 | aaroncalero | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/67efd2776999 [^] |
| 2015-05-29 09:14 | hgbot | Checkin | |
| 2015-05-29 09:14 | hgbot | Note Added: 0077881 | |
| 2015-05-29 09:14 | hgbot | Status | scheduled => resolved |
| 2015-05-29 09:14 | hgbot | Resolution | open => fixed |
| 2015-05-29 09:14 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41c037b78e4f437ce8e90a8ed4896974e8e2286f [^] |
| 2015-05-29 09:54 | Orekaria | Note Added: 0077883 | |
| 2015-05-29 09:54 | Orekaria | Status | resolved => new |
| 2015-05-29 09:54 | Orekaria | Resolution | fixed => open |
| 2015-05-29 12:59 | hgbot | Checkin | |
| 2015-05-29 12:59 | hgbot | Note Added: 0077889 | |
| 2015-05-29 12:59 | hgbot | Status | new => resolved |
| 2015-05-29 12:59 | hgbot | Resolution | open => fixed |
| 2015-05-29 12:59 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41c037b78e4f437ce8e90a8ed4896974e8e2286f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a5c25afa2d03d167b2fa6a8b01d9efe8f554081b [^] |
| 2015-05-29 13:50 | dmitry_mezentsev | Relationship added | caused by 0027268 |
| 2015-05-29 13:55 | dmitry_mezentsev | Note Added: 0077896 | |
| 2015-05-29 13:55 | dmitry_mezentsev | Severity | major => minor |
| 2015-06-11 17:55 | marvintm | Review Assigned To | => marvintm |
| 2015-06-11 17:55 | marvintm | Status | resolved => closed |
| 2015-06-11 17:55 | marvintm | Fixed in Version | => RR15Q3 |
| 2015-06-16 19:34 | Orekaria | Relationship added | blocks 0029530 |
| 2015-06-16 23:27 | Orekaria | Note Added: 0078338 | |
| 2015-06-17 20:06 | hgbot | Checkin | |
| 2015-06-17 20:06 | hgbot | Note Added: 0078350 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |