Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0029339 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | critical | always | 2015-03-18 17:48 | 2015-04-16 15:18 | |||
Reporter | jecharri | View Status | public | |||||
Assigned To | migueldejuana | |||||||
Priority | immediate | Resolution | fixed | Fixed in Version | RR15Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f78942ca2634 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | adrianromero | |||||||
Regression level | Production - QA Approved | |||||||
Regression date | 2014-12-11 | |||||||
Regression introduced in release | RR15Q1 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/354010b54e3a [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0029339: Discounts are not properly calculated in Q1.1 of 2015 version | |||||||
Description | Discounts are not properly calculated in Q1.1 of 2015 version We are not rounding the final result of applying a discount and before Q1.1 we were doing it. | |||||||
Steps To Reproduce | In Q3.5 -go to Web POS and create a ticket 0.53*12=6.36 -> apply 20% discount -> round(0.53 * 0.8, 2) = 0.42 -> 0.42*12=5.04 In Q1.1 of 2015 -go to Web POS and create a ticket 0.53*12=6.36 -> apply 20% discount -> 0.53 * 0.8 = 0.424 -> 0.424*12=5.088~=5.09 | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||||||||||||||||
|
Notes | |
(0075767) hgbot (developer) 2015-03-19 11:25 |
Repository: erp/pmods/org.openbravo.retail.discounts Changeset: 4f4dd55ff95394b821439149e41239405b6a0f72 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Mar 19 11:21:09 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4f4dd55ff95394b821439149e41239405b6a0f72 [^] Fixed issue 0029339: Discounts are not properly calculated in Q1.1 of 2015 version Backout issue 28358 --- M web/org.openbravo.retail.discounts/js/promotion-manual.js --- |
(0075769) hgbot (developer) 2015-03-19 11:50 |
Repository: tools/automation/pi-mobile Changeset: df0ae84ed721b99ce809d6756f8411e2bd626fa5 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Mar 19 11:19:27 2015 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/df0ae84ed721b99ce809d6756f8411e2bd626fa5 [^] Fixed issue 0029339: Discounts are not properly calculated in Q1.1 of 2015 version Backout issue 28358 --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesI.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/ReceiptDiscount.java --- |
(0075784) migueldejuana (developer) 2015-03-20 11:13 |
This is a regression, because we did a wrong fix over an wrong reported issue. When we apply discounts, we have to apply the discount to each item of the line, not to the total price of the line. Example, you buy a computer and it has a 20% of discount, if you buy 2 computer, the 20% of discount is applyed to each computer and then they sum the price of each pc. It is a mistake to apply 20% of discount to the total price(sum of the 2 computers). |
(0076455) hgbot (developer) 2015-04-10 15:03 |
Repository: retail/backports/3.0RR15Q1.3/org.openbravo.retail.discounts Changeset: f78942ca26348142af4c6c56a1cd1a3a094886f4 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Mar 19 11:21:09 2015 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.retail.discounts/rev/f78942ca26348142af4c6c56a1cd1a3a094886f4 [^] Fixed issue 0029339: Discounts are not properly calculated in Q1.1 of 2015 version Backout issue 28358 --- M web/org.openbravo.retail.discounts/js/promotion-manual.js --- |
(0076592) adrianromero (manager) 2015-04-16 15:18 |
Verified |
Issue History | |||
Date Modified | Username | Field | Change |
2015-03-18 17:48 | jecharri | New Issue | |
2015-03-18 17:48 | jecharri | Assigned To | => Retail |
2015-03-18 17:48 | jecharri | Resolution time | => 1427065200 |
2015-03-18 17:48 | jecharri | Regression level | => Production - QA Approved |
2015-03-18 17:48 | jecharri | Regression introduced in release | => RR15Q1 |
2015-03-18 17:48 | jecharri | Triggers an Emergency Pack | => No |
2015-03-18 19:06 | Orekaria | Relationship added | depends on 0028933 |
2015-03-18 19:06 | Orekaria | Relationship replaced | blocks 0028933 |
2015-03-18 19:07 | Orekaria | Relationship added | related to 0028868 |
2015-03-19 11:02 | migueldejuana | Regression date | => 2014-12-11 |
2015-03-19 11:02 | migueldejuana | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/354010b54e3a [^] |
2015-03-19 11:03 | migueldejuana | Assigned To | Retail => migueldejuana |
2015-03-19 11:03 | migueldejuana | Status | new => scheduled |
2015-03-19 11:25 | hgbot | Checkin | |
2015-03-19 11:25 | hgbot | Note Added: 0075767 | |
2015-03-19 11:25 | hgbot | Status | scheduled => resolved |
2015-03-19 11:25 | hgbot | Resolution | open => fixed |
2015-03-19 11:25 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4f4dd55ff95394b821439149e41239405b6a0f72 [^] |
2015-03-19 11:50 | hgbot | Checkin | |
2015-03-19 11:50 | hgbot | Note Added: 0075769 | |
2015-03-19 11:50 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/4f4dd55ff95394b821439149e41239405b6a0f72 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/df0ae84ed721b99ce809d6756f8411e2bd626fa5 [^] |
2015-03-19 12:03 | Orekaria | Relationship added | depends on 0028358 |
2015-03-20 10:53 | dmitry_mezentsev | Relationship replaced | caused by 0028358 |
2015-03-20 11:09 | dmitry_mezentsev | Issue Monitored: dmitry_mezentsev | |
2015-03-20 11:13 | migueldejuana | Note Added: 0075784 | |
2015-03-24 16:25 | marvintm | Review Assigned To | => marvintm |
2015-03-24 16:25 | marvintm | Status | resolved => closed |
2015-03-24 16:25 | marvintm | Fixed in Version | => RR15Q2 |
2015-04-10 15:03 | hgbot | Checkin | |
2015-04-10 15:03 | hgbot | Note Added: 0076455 | |
2015-04-10 15:03 | hgbot | Status | closed => resolved |
2015-04-10 15:03 | hgbot | Fixed in SCM revision | http://code.openbravo.com/tools/automation/pi-mobile/rev/df0ae84ed721b99ce809d6756f8411e2bd626fa5 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q1.3/org.openbravo.retail.discounts/rev/f78942ca26348142af4c6c56a1cd1a3a094886f4 [^] |
2015-04-16 15:18 | adrianromero | Review Assigned To | marvintm => adrianromero |
2015-04-16 15:18 | adrianromero | Note Added: 0076592 | |
2015-04-16 15:18 | adrianromero | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |