Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0015380 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | always | 2010-12-09 11:43 | 2011-05-24 10:56 | |||
| Reporter | iperdomo | View Status | public | |||||
| Assigned To | iperdomo | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | bf0478c6ef18 | |||
| Projection | none | ETA | none | Target Version | 3.0MP0 | |||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_22 | |||
| OS Version | 2.6.35-gentoo-r12 | Database version | 8.3.12 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0015380: Remove tomcat's Expires filter | |||||||
| Description | The CacheFilter (org.openbravo.utils.CacheFilter) is the way to apply a expires header for all JavaScript files. This adds an expires in 2038. Check the generated web.xml <init-param> <param-name>Expires</param-name> <param-value>Sun, 17 Jan 2038 19:14:07 GMT</param-value> </init-param> According with HTTP 1.1 to mark a response as 'never expires' it should send a response to expire in one year, never more than that. "To mark a response as "never expires," an origin server sends an Expires date approximately one year from the time the response is sent. HTTP/1.1 servers SHOULD NOT send Expires dates more than one year in the future": http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html [^] Since the generated and static JavaScript is concatenated in a single request it makes no sense to keep this response header. This also solves the problem of clients having js files forever and we need to prompt a 'Clean your browser's cache' | |||||||
| Steps To Reproduce | * Using tomcat, request a static file in web/js, e.g. web/js/utils.js With Firebug check the response. It expires on 2038. * Remove the filter * Clear the browser cache * Request the same file * Re-request it, the server should return 304 'Not Modified' | |||||||
| Proposed Solution | * Remove the Expires header from the responses. | |||||||
| Tags | closingMay2011 | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0034018) hgbot (developer) 2011-02-02 19:58 |
Repository: erp/devel/pi Changeset: bf0478c6ef187bd9f9ae1ab686abe65d08fe5f3c Author: Iván Perdomo <ivan.perdomo <at> openbravo.com> Date: Wed Feb 02 19:57:04 2011 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/bf0478c6ef187bd9f9ae1ab686abe65d08fe5f3c [^] Fixes issue 15380: Removed CacheFilter for web/* resources --- M src-db/database/sourcedata/AD_MODEL_OBJECT.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml M src-db/database/sourcedata/AD_MODEL_OBJECT_PARA.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2010-12-09 11:43 | iperdomo | New Issue | |
| 2010-12-09 11:43 | iperdomo | Assigned To | => iperdomo |
| 2010-12-09 11:43 | iperdomo | Modules | => Core |
| 2010-12-09 11:44 | iperdomo | Summary | Remove Tomcat's CacheFilter => Remove tomcat's Expires filter |
| 2010-12-09 11:47 | iperdomo | Relationship added | related to 0015292 |
| 2010-12-09 15:46 | shuehner | Issue Monitored: shuehner | |
| 2011-02-02 19:17 | iperdomo | Status | new => scheduled |
| 2011-02-02 19:17 | iperdomo | fix_in_branch | => pi |
| 2011-02-02 19:58 | hgbot | Checkin | |
| 2011-02-02 19:58 | hgbot | Note Added: 0034018 | |
| 2011-02-02 19:58 | hgbot | Status | scheduled => resolved |
| 2011-02-02 19:58 | hgbot | Resolution | open => fixed |
| 2011-02-02 19:58 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/bf0478c6ef187bd9f9ae1ab686abe65d08fe5f3c [^] |
| 2011-02-03 11:37 | iperdomo | Relationship added | related to 0015854 |
| 2011-05-24 10:08 | dalsasua | Tag Attached: closingMay2011 | |
| 2011-05-24 10:56 | dalsasua | Status | resolved => closed |
| 2017-07-15 16:03 | shuehner | Relationship added | related to 0034500 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |