Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009950Openbravo ERPC. Securitypublic2009-06-29 15:472009-08-10 12:37
Reporternetworkb 
Assigned Tosathiyan 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target Version2.50MP4Fixed in Version2.40MP8 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009950: The employees have acces to their payroll
DescriptionAlthough employees do not have access to Manual settlements they can see their payrolls in different ways:

- Master Data Management || Business Partner || Business Partner >> Customer the field "Credit used" has the information about pending payments that are their payrolls.

- Sales Management || Transactions || Sales Invoice || Header select business partner. In BP selector appears the same information about credit used.

- Master Data Management || Business Partner press linked items and here there are all the manual settlements with amount information linked to this business partner.
Steps To ReproduceThere are three different ways:

- Master Data Management || Business Partner || Business Partner >> Customer the field "Credit used" has the information about pending payments that are their payrolls.

- Sales Management || Transactions || Sales Invoice || Header select business partner. In BP selector appears the same information about credit used.

- Master Data Management || Business Partner press linked items and here there are all the manual settlements with amount information linked to this business partner.
Proposed SolutionFor the two first points, modify:
* C_INVOICE_POST procedure in order to update credit used ONLY when it is a sales invoice.
* C_SETTLEMENT_POST procedure in order to update credit used ONLY when ISRECEIPT = Y
* SE_ORDER_BPARTNER, SL_INOUT_BPARTNER and SE_INVOICE_BPARTNER callouts in order to:
** Display Credit Limit Over message only in sales transactions.
** Display correctly the message as "Note: Credit Limit over by 1157622.42" instead of "Note: Credit Limit over by -1157622.42" where 1157622.42 is the credit available as SO_CreditLimit-SO_CreditUsed

The third point will be addressed by backport 0009981
Additional Information
TagsNo tags attached.
Relationships
related to backport 0009981 closed alostale Linked items show elements in windows where the role has no permission 
blocks defect 00097052.50MP4 closed sathiyan The employees have acces to their payroll 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-19 16:29psarobeTypedefect => backport
2009-07-19 16:29psarobefix_in_branch => 2.40
2009-07-21 13:40rafarodaAssigned Torafaroda => sathiyan
2009-07-21 13:40rafarodaSteps to Reproduce Updated
2009-07-21 13:40rafarodaRelationship addedrelated to 0009981
2009-07-28 06:52pjuvaraTarget Version => 2.50MP4
2009-07-28 15:08hgbotCheckin
2009-07-28 15:08hgbotNote Added: 0018659
2009-07-28 15:08hgbotStatusscheduled => resolved
2009-07-28 15:08hgbotResolutionopen => fixed
2009-07-28 15:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/1d84e460bbabf3df6e9114fdd0824245155338e4 [^]
2009-08-10 12:37sureshbabuStatusresolved => closed
2009-08-10 12:37sureshbabuNote Added: 0018892
2009-08-10 12:37sureshbabuFixed in Version => 2.40MP8

Notes
(0018659)
hgbot   
2009-07-28 15:08   
Repository: erp/stable/2.40
Changeset: 1d84e460bbabf3df6e9114fdd0824245155338e4
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Tue Jul 28 18:37:04 2009 +0530
URL: http://code.openbravo.com/erp/stable/2.40/rev/1d84e460bbabf3df6e9114fdd0824245155338e4 [^]

Fixes Issue 9950: The employees have access to their payroll

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_SETTLEMENT_POST.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
---
(0018892)
sureshbabu   
2009-08-10 12:37   
Tested