Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009930Openbravo ERPA. Platformpublic2009-07-16 13:302009-07-22 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009930: Remove some non-public not used xsql files
DescriptionAfter the public/private review done for MP2 there are a number of now private xsql files which are not used in openbravo.

As they are not public they cannot be used outside of their package (i.e. cannot be used by any modules) so it is safe to remove them.
Steps To Reproduce
Proposed Solution
Additional Information
Tags250MP3releasecandidate, leo
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-16 13:30shuehnerNew Issue
2009-07-16 13:30shuehnerAssigned To => rafaroda
2009-07-16 13:30shuehnerAssigned Torafaroda => shuehner
2009-07-16 13:44shuehnerNote Added: 0018317
2009-07-16 14:18hgbotCheckin
2009-07-16 14:18hgbotNote Added: 0018320
2009-07-16 14:18hgbotStatusnew => resolved
2009-07-16 14:18hgbotResolutionopen => fixed
2009-07-16 14:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6c479c40d9321d7b91b2a29f237c51117cdea9fe [^]
2009-07-21 16:24psarobeFixed in Version => 2.50MP3
2009-07-21 16:26psarobeTag Attached: 250MP3releasecandidate
2009-07-21 18:43psarobeTag Attached: leo
2009-07-21 21:41elopioStatusresolved => closed
2009-07-21 21:41elopioNote Added: 0018516
2009-07-22 00:00anonymoussf_bug_id0 => 2825069

Notes
(0018317)
shuehner   
2009-07-16 13:44   
@qa:

Testing needed: 2 steps
- one compile.complete to be sure that not file which is used by core was deleted
- second check removed xsql files in commit to be sure that no file has a accessModifier="public" statement in it (as we only want to remove non-public files)
(0018320)
hgbot   
2009-07-16 14:18   
Repository: erp/devel/pi
Changeset: 6c479c40d9321d7b91b2a29f237c51117cdea9fe
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jul 16 14:18:17 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6c479c40d9321d7b91b2a29f237c51117cdea9fe [^]

Fixed 9930: Remove some non-public, unused xsql files

---
R src/org/openbravo/erpCommon/ad_combos/AdOrgTreeCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/BankAccountCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/BusinessPartnerCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/CashBookCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/PaisCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/RegionCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/RegionSpainCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/ReportTypeCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/SalesOrderOpenItemCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/VendorCombo_data.xsql
R src/org/openbravo/erpCommon/ad_combos/WorkRequirementCombo_data.xsql
R src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports_EV_data.xsql
R src/org/openbravo/erpCommon/ad_reports/PurchaseEdition_data.xsql
R src/org/openbravo/erpCommon/ad_reports/ReportRawMaterial_data.xsql
R src/org/openbravo/erpReports/RptC_Invoice_Lines_data.xsql
R src/org/openbravo/erpReports/RptC_Invoice_Tax_data.xsql
R src/org/openbravo/erpReports/RptC_Order_Lines_data.xsql
R src/org/openbravo/erpReports/RptC_Remittance_Header_data.xsql
R src/org/openbravo/erpReports/RptC_Remittance_Lines_data.xsql
R src/org/openbravo/erpReports/TaxRegisterTypeLines_data.xsql
R src/org/openbravo/erpReports/TaxRegisterType_data.xsql
---
(0018516)
elopio   
2009-07-21 21:41   
compilation succeeded and no one of the deleted files include accessModifier statement.