Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009836Openbravo ERPA. Platformpublic2009-07-10 19:402009-07-23 00:00
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version2.50MP3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009836: ProductComplete selector is too slow with many products.
DescriptionThis selector is too slow with many products (i.e. 100k or 100m). Happens on both oracle and postgres.
Steps To Reproduce
Proposed Solution
Additional Information
Tags250MP3releasecandidate, leo
Relationships
depends on backport 0009837 closed shuehner ProductComplete selector is too slow with many products. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-10 19:40shuehnerNew Issue
2009-07-10 19:40shuehnerAssigned To => shuehner
2009-07-10 19:40shuehnerStatusnew => scheduled
2009-07-10 19:40shuehnerfix_in_branch => pi
2009-07-10 19:46hgbotCheckin
2009-07-10 19:46hgbotNote Added: 0018121
2009-07-10 19:46hgbotStatusscheduled => resolved
2009-07-10 19:46hgbotResolutionopen => fixed
2009-07-10 19:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/47fb0e8ab60b9c6452a85a304dbdbe19622fe82d [^]
2009-07-10 19:53shuehnerNote Added: 0018122
2009-07-21 16:24psarobeFixed in Version => 2.50MP3
2009-07-21 16:26psarobeTag Attached: 250MP3releasecandidate
2009-07-21 18:43psarobeTag Attached: leo
2009-07-22 06:07elopioStatusresolved => closed
2009-07-23 00:00anonymoussf_bug_id0 => 2825611

Notes
(0018121)
hgbot   
2009-07-10 19:46   
Repository: erp/devel/pi
Changeset: 47fb0e8ab60b9c6452a85a304dbdbe19622fe82d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Jul 10 19:46:07 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/47fb0e8ab60b9c6452a85a304dbdbe19622fe82d [^]

Fixed 9836: Optimize ProductComplete selector performance with many products
- When use with command=KEY limit to two rows, as only one row content, and count={0,1,2} is needed here
- Better placement of limit/offset on postgres
- Better placement of rownum <= clause on oracle
- Remove unneded joins from count queries: countRowsNotStored & countRowsNotStoredTrl
- Merge these two count queries as they were identical after the last step

---
M src/org/openbravo/erpCommon/info/ProductComplete.java
M src/org/openbravo/erpCommon/info/ProductComplete_data.xsql
---
(0018122)
shuehner   
2009-07-10 19:53   
for QA: this change affects all of the following use cases:

1.) When used with direct search via enter key (i.e. in Warehouse Management -> Physical Inventory)
a.) no row is found for the product value you entered (i.e. xx)
b.) exactly one row is found and the selector-popup is opened and closed immediately and the values are used in the calling page (i.e. hat)
c.) more than one row is found and the selector popup is opened and displays the products filtered by the partial name entered (i.e. b)

2.) When opened normally
Testing if ordering, filtering, scrolling works as expected for the following combinations
a.) Without setting 'With stock' in language en_US
b.) With setting 'With stock' in language en_US
c.) Without setting 'With stock' in language different from en_US
d.) With setting 'With stock' in language different from en_US

Testing is needed on both postgres and oracle