Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009794Openbravo ERPA. Platformpublic2009-07-07 10:532009-07-16 17:55
Reporterjpabloae 
Assigned Torafaroda 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version2.35MP13 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009794: 7 sourcedata XML files with data in custom range
DescriptionThere are 7 XML files in sourcedata with data in the custom ranges:

database/sourcedata/AD_ALERTRULE_TRL.xml
database/sourcedata/AD_ALERTRULE.xml
database/sourcedata/AD_IMPFORMAT_ROW.xml
database/sourcedata/AD_IMPFORMAT.xml
database/sourcedata/AD_MENU_TRL.xml
database/sourcedata/AD_MENU.xml
database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
Steps To ReproduceOpen any of those XML files and search for "1. Custom Range". There should be no data in that range.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-07-07 10:53jpabloaeNew Issue
2009-07-07 10:53jpabloaeAssigned To => rafaroda
2009-07-07 10:53jpabloaeOBNetwork customer => No
2009-07-08 07:30pjuvaraNote Added: 0017993
2009-07-08 09:13jpabloaeNote Added: 0017998
2009-07-08 09:23rafarodaNote Added: 0017999
2009-07-08 09:23rafarodaNote Added: 0018000
2009-07-08 09:23rafarodaStatusnew => acknowledged
2009-07-08 09:57jpabloaeNote Added: 0018008
2009-07-13 09:16rafarodaStatusacknowledged => scheduled
2009-07-13 09:16rafarodafix_in_branch => pi
2009-07-13 09:17rafarodaStatusscheduled => closed
2009-07-13 09:17rafarodaNote Added: 0018146
2009-07-13 09:17rafarodaResolutionopen => no change required
2009-07-13 09:20rafarodaNote Added: 0018147
2009-07-16 17:55anonymoussf_bug_id0 => 2822587

Notes
(0017993)
pjuvara   
2009-07-08 07:30   
Reminder sent to: jpabloae

jpabloae: what is the rationale for immediate priority?
(0017998)
jpabloae   
2009-07-08 09:13   
pjuvara: having data in the "custom ranges" of IDs is very bad, as it possible to collide with customer's data and it's also dangerous in the updates. This was raised to me by the support team, because they found this issue in one of the files dusing an update to 2.35MP13. After writting the test for hudson, we found out that it is present not in 1 but in 7 files.

Additionally, I consider anything raised by builds.openbravo.com as immediate+ priority:

* Build errors.
* Junit test errors.
* Smoke test errors.
* Database consistency.
* Sanity checks, like "modularity integrity" or "data in custom ranges".

This is the rationale behind this priority.
(0017999)
rafaroda   
2009-07-08 09:23   
This issue was set to immediate since GPS found problems due to it when upgrading a customer code.

This issue is present in both 2.3x and 2.40 versions. Have a look at AD_ALERTRULE, record "Purchase orders to be received" in custom range 1000020:
* https://code.openbravo.com/erp/stable/2.3x/file/7e401661a974/database/sourcedata/AD_ALERTRULE.xml [^]
* https://code.openbravo.com/erp/stable/2.40/file/3e2acda28c1b/src-db/database/sourcedata/AD_ALERTRULE.xml [^]
(0018000)
rafaroda   
2009-07-08 09:23   
Issue set to Acknowledged until a solution for it is being decided.
(0018008)
jpabloae   
2009-07-08 09:57   
Faulty files in 2.40:

src-db/database/sourcedata/AD_ALERTRULE.xml
src-db/database/sourcedata/AD_IMPFORMAT_ROW.xml
src-db/database/sourcedata/AD_IMPFORMAT.xml
src-db/database/sourcedata/AD_MENU.xml
src-db/database/sourcedata/AD_MESSAGE.xml
src-db/database/sourcedata/AD_TEXTINTERFACES.xml
(0018146)
rafaroda   
2009-07-13 09:17   
These already existing records in the Custom Range will not be fixed. If new appear, they will be addressed.
(0018147)
rafaroda   
2009-07-13 09:20   
The problems will arise in the upgrade from 2.3x to 2.40 when last Custom Range record in a fresh 2.40 is higher than last Custom Range in a fresh 2.3x (or fresh 2.3x has no records in Custom Range). This happens, for instance, in AD_TEXTINTERFACES:

   1. 2.3x AD_TEXTINTERFACES fresh file DOES NOT have Custom Range records https://code.openbravo.com/erp/stable/2.3x/file/7e401661a974/database/sourcedata/AD_TEXTINTERFACES.xml [^]
   2. Customer has created a new AD_TEXTINTERFACES record in Custom Range: 1000000
   3. Customer upgrades to 2.40 where AD_TEXTINTERFACES fresh file DOES have Custom Range records (BUG) https://code.openbravo.com/erp/stable/2.40/file/3e2acda28c1b/src-db/database/sourcedata/AD_TEXTINTERFACES.xml [^] Custom Range record 1000000 will conflict.

Solution proposed is to move Customer's record to a new range and then execute AD_UPDATE_SEQUENCE process in the database.

The same issue will arise in AD_IMPFORMAT_ROW:
    * 2.3x https://code.openbravo.com/erp/stable/2.3x/file/7e401661a974/database/sourcedata/AD_IMPFORMAT_ROW.xml [^] One record in Custom Range
    * 2.40 https://code.openbravo.com/erp/stable/2.40/file/3e2acda28c1b/src-db/database/sourcedata/AD_IMPFORMAT_ROW.xml [^] Two records in Custom Range