Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009705Openbravo ERPC. Securitypublic2009-06-29 15:472009-08-18 00:00
Reporternetworkb 
Assigned Tosathiyan 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target Version2.50MP4Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009705: The employees have acces to their payroll
DescriptionAlthough employees do not have access to Manual settlements they can see their payrolls in different ways:

- Master Data Management || Business Partner || Business Partner >> Customer the field "Credit used" has the information about pending payments that are their payrolls.

- Sales Management || Transactions || Sales Invoice || Header select business partner. In BP selector appears the same information about credit used.

- Master Data Management || Business Partner press linked items and here there are all the manual settlements with amount information linked to this business partner.
Steps To ReproduceThere are three different ways:

- Master Data Management || Business Partner || Business Partner >> Customer the field "Credit used" has the information about pending payments that are their payrolls.

- Sales Management || Transactions || Sales Invoice || Header select business partner. In BP selector appears the same information about credit used.

- Master Data Management || Business Partner press linked items and here there are all the manual settlements with amount information linked to this business partner.
Proposed SolutionFor the two first points, modify:
* C_INVOICE_POST procedure in order to update credit used ONLY when it is a sales invoice.
* C_SETTLEMENT_POST procedure in order to update credit used ONLY when ISRECEIPT = Y
* SE_ORDER_BPARTNER, SL_INOUT_BPARTNER and SE_INVOICE_BPARTNER callouts in order to:
** Display Credit Limit Over message only in sales transactions.
** Display correctly the message as "Note: Credit Limit over by 1157622.42" instead of "Note: Credit Limit over by -1157622.42" where 1157622.42 is the credit available as SO_CreditLimit-SO_CreditUsed

The third point will be addressed by defect 0009979
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00099502.50MP4 closed sathiyan The employees have acces to their payroll 
related to defect 0009979 closed alostale Linked items show elements in windows where the role has no permission 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-06-29 15:47networkbNew Issue
2009-06-29 15:47networkbAssigned To => rafaroda
2009-06-29 15:47networkbOBNetwork customer => Yes
2009-06-29 15:49networkbversion2.50 => 2.40
2009-06-29 19:25psarobeNote Added: 0017650
2009-06-29 19:25psarobeStatusnew => feedback
2009-07-08 11:30rafarodaNote Added: 0018012
2009-07-16 16:45networkbNote Added: 0018327
2009-07-16 16:45networkbStatusfeedback => new
2009-07-19 16:29psarobeStatusnew => scheduled
2009-07-19 16:29psarobefix_in_branch => pi
2009-07-21 13:39rafarodaAssigned Torafaroda => sathiyan
2009-07-21 13:39rafarodafix_in_branchpi =>
2009-07-21 13:39rafarodaSteps to Reproduce Updated
2009-07-21 13:41rafarodaRelationship addedrelated to 0009979
2009-07-22 11:32sathiyanNote Added: 0018539
2009-07-22 11:36rafarodaNote Deleted: 0018539
2009-07-28 06:52pjuvaraTarget Version => 2.50MP4
2009-07-28 17:36hgbotCheckin
2009-07-28 17:36hgbotNote Added: 0018664
2009-07-28 17:36hgbotStatusscheduled => resolved
2009-07-28 17:36hgbotResolutionopen => fixed
2009-07-28 17:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b76fb561da36f575fb80b4bb27ea8afbfe22195c [^]
2009-08-17 13:39sureshbabuStatusresolved => closed
2009-08-17 13:39sureshbabuNote Added: 0018974
2009-08-17 13:39sureshbabuFixed in Version => pi
2009-08-18 00:00anonymoussf_bug_id0 => 2839262

Notes
(0017650)
psarobe   
2009-06-29 19:25   
Sales invoices to payrolls? Please we need a better explanation.

Thanks in advance
(0018012)
rafaroda   
2009-07-08 11:30   
Reminder sent to: networkb

Please provide the feedback required. Thanks.
(0018327)
networkb   
2009-07-16 16:45   
The bug is :

If a business partner is an employee of the company, can see payrolls in Credit Used.

For employees its payrolls amount is the same as Credit Used. This field appears in diferent windows that everybody can access, although they do not have permission to Settlements.
(0018664)
hgbot   
2009-07-28 17:36   
Repository: erp/devel/pi
Changeset: b76fb561da36f575fb80b4bb27ea8afbfe22195c
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Tue Jul 28 21:05:18 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b76fb561da36f575fb80b4bb27ea8afbfe22195c [^]

Fixes Issue 9705: The employees have access to their payroll

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_SETTLEMENT_POST.xml
M src/org/openbravo/erpCommon/ad_callouts/SE_Invoice_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOut_BPartner.java
---
(0018974)
sureshbabu   
2009-08-17 13:39   
Tested the first two points listed in the defect.