Openbravo Issue Tracking System - Java Client POS
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009412Java Client POS(No Category)public2009-06-10 01:362010-07-23 00:00
Reporterfalcon 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.30 
Target VersionFixed in Version2.30.1 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
OBNetwork customerNo
Support ticket
Regression introduced in release
Summary0009412: "Regular Expression" filter is a partial string filter and does not work in product filter.
DescriptionThe product filter supplies a dropdown item labeled "Regular expression". This filter, however, provides only partial string matching, not regular expressions.

As a consequence, the name cannot be filtered by a partial string match.
Steps To ReproduceStock | Products | search by "Regular expression"
Proposed SolutionChange to "Partial", append % on the search string.

The attached patch modifies the name of the RE filter to PARTIAL, to better indicate what it does, and changes the locale to indicate that it's a partial match. Also, the ProductFilter class surrounds the match text with %%, as is done elsewhere (customer search).
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-06-10 01:36falconNew Issue
2009-06-10 01:36falconAssigned To => adrianromero
2009-06-10 01:38falconNote Added: 0017154
2009-06-15 15:41hgbotCheckin
2009-06-15 15:41hgbotNote Added: 0017312
2009-06-15 15:41hgbotStatusnew => resolved
2009-06-15 15:41hgbotResolutionopen => fixed
2009-06-15 15:41hgbotFixed in SCM revision => http://code.openbravo.com/pos/devel/main/rev/f62e4ef02806900c6fe208593537c752bcc0bad0 [^]
2009-06-15 15:47adrianromeroNote Added: 0017313
2010-07-22 13:56adrianromeroStatusresolved => closed
2010-07-22 14:02adrianromeroFixed in Version => 2.30.1
2010-07-23 00:00anonymoussf_bug_id0 => 3033255
2012-11-07 09:40priyamCategory01 - General => (No Category)

Notes
(0017154)
falcon   
2009-06-10 01:38   
I didn't even notice, but the patch contains an extra function to remove filters from the list of them. For the name, it makes no sense to have an is null/is not null, as the database requires it be defined. For the prices, it makes no sense to have the above two, nor the partial match on a float number (does that even work?).

This should've probably been another patch, but.. I didn't notice it on submit.
(0017312)
hgbot   
2009-06-15 15:41   
Repository: pos/devel/main
Changeset: f62e4ef02806900c6fe208593537c752bcc0bad0
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Jun 15 15:40:02 2009 +0200
URL: http://code.openbravo.com/pos/devel/main/rev/f62e4ef02806900c6fe208593537c752bcc0bad0 [^]

Fixes issue 0009412: "Regular Expression" filter is a partial string filter and does not work in product filter.

---
M locales/data_messages.properties
M src-data/com/openbravo/data/gui/ListQBFModelNumber.java
M src-pos/com/openbravo/pos/panels/JTicketsFinder.java
M src-pos/com/openbravo/pos/ticket/ProductFilter.java
M src-pos/com/openbravo/pos/ticket/ProductFilterSales.form
M src-pos/com/openbravo/pos/ticket/ProductFilterSales.java
---
(0017313)
adrianromero   
2009-06-15 15:47   
The literal "Regular expression" has been replaced by "Wildcards". That IMO reflects better how LIKE works.

It also has been changed in order to show only the correct items in string or numeric fields and in mandatory or non mandatory fields

What has not been added is a "%" at the end, because the user is supposed to add it if he wants to filter comparing only the begining of the value and let him the possibility to compare only the end of the value.