Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0009275Openbravo ERP02. Master data managementpublic2009-06-01 19:132009-07-23 00:00
Reportermirurita 
Assigned Tosathiyan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionrPath Linux
Product Version2.50MP1 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0009275: Import Order fails with new products
DescriptionIf you add in a imported order a product which doesn't exist in sample data (created by the user) the process of import orders fails.
Steps To Reproduce1) Create a new Product with search key: banana

2) Follow this test case:
http://wiki.openbravo.com/wiki/QA_test_plan_2.50/Test_cases [^]
with I_Orders.txt:
AA875875875RRTT,Pos Order,bellphone,banana,100,10.5,102

3) Go to Master Data Management -> Import Data -> Import Orders

4) Select corresponding order and press Import Orders button.
Proposed Solution
Additional Information
Tags250MP3releasecandidate, suresh
Relationships
has duplicate defect 0009279 closed jonalegriaesarte Openbravo ERP Syncronization with Openbravo POS doesn't work correctly with non-sample products. 
blocks defect 00093542.40 closed adrianromero Java Client POS Import Order fails with new products and business partners 
Attached Filespng import file loader.png (157,017) 2009-06-12 08:58
https://issues.openbravo.com/file_download.php?file_id=1418&type=bug
png

png order processed.png (157,247) 2009-06-12 08:58
https://issues.openbravo.com/file_download.php?file_id=1419&type=bug
png

png importing error.png (81,986) 2009-06-12 11:13
https://issues.openbravo.com/file_download.php?file_id=1420&type=bug
png

txt errorLog.txt (8,942) 2009-06-13 11:07
https://issues.openbravo.com/file_download.php?file_id=1427&type=bug
? ImportOrder.java (41,103) 2009-06-14 23:41
https://issues.openbravo.com/file_download.php?file_id=1428&type=bug
Issue History
Date ModifiedUsernameFieldChange
2009-06-01 19:13miruritaNew Issue
2009-06-01 19:13miruritaAssigned To => rafaroda
2009-06-01 21:49icematrix3kIssue Monitored: icematrix3k
2009-06-02 09:24rafarodaRelationship addedrelated to 0009279
2009-06-05 13:09psarobeStatusnew => scheduled
2009-06-05 13:09psarobefix_in_branch => pi
2009-06-05 15:34rafarodaRelationship replacedhas duplicate 0009279
2009-06-05 18:14miruritaRelationship addedblocks 0009354
2009-06-05 18:49rafarodaNote Added: 0017051
2009-06-05 18:49rafarodaAssigned Torafaroda => sathiyan
2009-06-05 18:49rafarodaPrioritynormal => high
2009-06-05 18:49rafarodafix_in_branchpi =>
2009-06-05 18:49rafarodaSummaryImort Order fails with new products => Import Order fails with new products
2009-06-05 18:49rafarodaDescription Updated
2009-06-05 18:49rafarodaProposed Solution updated
2009-06-12 08:47sathiyanStatusscheduled => closed
2009-06-12 08:47sathiyanNote Added: 0017227
2009-06-12 08:47sathiyanResolutionopen => unable to reproduce
2009-06-12 08:50sathiyanIssue Monitored: sathiyan
2009-06-12 08:57sathiyanStatusclosed => new
2009-06-12 08:57sathiyanResolutionunable to reproduce => open
2009-06-12 08:57sathiyanNote Added: 0017228
2009-06-12 08:58sathiyanFile Added: import file loader.png
2009-06-12 08:58sathiyanFile Added: order processed.png
2009-06-12 08:58sathiyanStatusnew => closed
2009-06-12 08:58sathiyanNote Added: 0017229
2009-06-12 11:12miruritaStatusclosed => new
2009-06-12 11:12miruritaNote Added: 0017237
2009-06-12 11:13miruritaFile Added: importing error.png
2009-06-13 11:07bennyfakeFile Added: errorLog.txt
2009-06-13 11:08bennyfakeNote Added: 0017278
2009-06-13 11:09bennyfakeIssue Monitored: bennyfake
2009-06-14 23:41icematrix3kFile Added: ImportOrder.java
2009-06-14 23:41icematrix3kNote Added: 0017279
2009-06-14 23:42icematrix3kNote Edited: 0017279
2009-06-15 07:24sathiyanNote Added: 0017280
2009-06-16 11:23rafarodaNote Added: 0017340
2009-06-16 11:23rafarodaStatusnew => scheduled
2009-06-18 15:55rafarodaNote Edited: 0017340
2009-06-18 20:14icematrix3kNote Added: 0017432
2009-06-18 20:27icematrix3kNote Edited: 0017432
2009-06-23 14:23hgbotCheckin
2009-06-23 14:23hgbotNote Added: 0017546
2009-06-23 14:23hgbotStatusscheduled => resolved
2009-06-23 14:23hgbotResolutionopen => fixed
2009-06-23 14:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/27b9c6b0026bf4f46387a72c68faae0c2d9f431d [^]
2009-06-23 14:30sathiyanNote Added: 0017547
2009-07-20 02:33wavesNote Added: 0018389
2009-07-21 16:24psarobeFixed in Version => 2.50MP3
2009-07-21 16:26psarobeTag Attached: 250MP3releasecandidate
2009-07-21 19:20psarobeTag Attached: suresh
2009-07-22 08:29sureshbabuStatusresolved => closed
2009-07-22 08:29sureshbabuNote Added: 0018523
2009-07-22 08:29sureshbabuFixed in Version2.50MP3 => pi
2009-07-23 00:00anonymoussf_bug_id0 => 2825598

Notes
(0017051)
rafaroda   
2009-06-05 18:49   
Seems to be an UUID issue in the import orders process.

Please also try to crash it with the following I_Orders.txt:
AA875875875rrrRRTT,Pos Order,mycustomer,beer,100,10.5,102
Having first created a Business Partner with search key: mycustomer
(0017227)
sathiyan   
2009-06-12 08:47   
I am able to import and process the order. I guess the reporter might miss the constant value for any of the fields Organization or Warehouse. However I have attached screen shots for that.
(0017228)
sathiyan   
2009-06-12 08:57   
I am reopening this for the purpose of attach screen shots.
(0017229)
sathiyan   
2009-06-12 08:58   
Please refer the screen shots.
(0017237)
mirurita   
2009-06-12 11:12   
The import file loader works for me and it creates the imported orders correctly (as is shown in your screenshots).

The problem is in the step 4) and 5) described in Steps to reproduce field.

3) Go to Master Data Management -> Import Data -> Import Orders

4) Select corresponding order and press Import Orders button.


After loading the imports (in Import File Loader) go to Master Data Management || Import Data || Import Orders.
Select the previously imported orders (open in edit mode).
Select POS Order in Document type jcombobox and press (in the bottom) the Import Orders button (Complete and process orders automatically checkbox selected).

When the process finish it shows an error.
(0017278)
bennyfake   
2009-06-13 11:08   
Hi, I got the similar case, please let me know if it is not. I input the data via Import Order interface and I got the same error message.

I attached the error log file for the reference. (errorLog.txt)

I found there had a error log :
ERROR org.openbravo.erpCommon.ad_process.ImportProcess - process - @CODE=@For input string: "90AA7116D53D41CE8761322BD25CC104"

90AA7116D53D41CE8761322BD25CC104 is the UUID code of my specific product id in m_product table.
(0017279)
icematrix3k   
2009-06-14 23:41   
(edited on: 2009-06-14 23:42)
I've attached the file with the fix, the import should work now.
(0017280)
sathiyan   
2009-06-15 07:24   
icematrix3k: You have changed some of the code here (taking business partner and location from different data class). You could justify the changes of those better. Can I reassign this bug to you?

Regards
Sathiyan.
(0017340)
rafaroda   
2009-06-16 11:23   
(edited on: 2009-06-18 15:55)
Sathiyan, please first reproduce the issue then review the patch attached.

Thanks.
(0017432)
icematrix3k   
2009-06-18 20:14   
(edited on: 2009-06-18 20:27)
Sathiyan: Sure. Basically, it runs *Integer.parseInt()* on ID's, and since the change to UUID (varchar in database), the check fails, and hence the Import Process error.
(0017546)
hgbot   
2009-06-23 14:23   
Repository: erp/devel/pi
Changeset: 27b9c6b0026bf4f46387a72c68faae0c2d9f431d
Author: Sathiyan Sivaprakasam <sathiyan.sivaprakasam <at> openbravo.com>
Date: Tue Jun 23 17:52:25 2009 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/27b9c6b0026bf4f46387a72c68faae0c2d9f431d [^]

Fixes Issue 9275: Import Order fails with new products.

---
M src/org/openbravo/erpCommon/ad_process/ImportOrder.java
---
(0017547)
sathiyan   
2009-06-23 14:30   
mirurita and bennyfake: I have fixed this issue. Please let me know if you have any other issue on this process. Price List is mandatory for any product (I hope you have added price list for banana product through price list tab). So please take care of it.

Thanks
Sathiyan.
(0018389)
waves   
2009-07-20 02:33   
We are facing similar issue. We updated ImportOrder.java with the new file but it is not working. Shoud we do something else to apply this patch?

thanks
(0018523)
sureshbabu   
2009-07-22 08:29   
Working fine after we select the price list manually