Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0009112Openbravo ERPA. Platformpublic2009-05-20 12:462009-05-26 00:00
shuehner 
alostale 
immediatecriticalhave not tried
closedfixed 
5
pi 
 
Core
No
0009112: API Change: erp_devel_pi-module-integrity-test - Build # 20 - Part4
erp_devel_pi-module-integrity-test - Build # 20 - Still Failing:

http://builds.openbravo.com/job/erp_devel_pi-module-integrity-test/20/ [^]

java API change:

org.openbravo.xmlEngine:
Missing
method org.openbravo.xmlEngine.XmlVectorValue.setTextMap(java.util.HashMap<java.lang.String, java.lang.String>): missing in 20
No tags attached.
Issue History
2009-05-20 12:46shuehnerNew Issue
2009-05-20 12:46shuehnerAssigned To => rafaroda
2009-05-20 12:46shuehnerRegression testing => No
2009-05-20 12:47shuehnerNote Added: 0016511
2009-05-20 15:03shuehnerNote Added: 0016523
2009-05-20 15:03shuehnerAssigned Torafaroda => pjuvara
2009-05-20 17:05pjuvaraNote Added: 0016536
2009-05-20 17:07pjuvaraAssigned Topjuvara => shuehner
2009-05-20 17:09shuehnerNote Added: 0016537
2009-05-20 17:10shuehnerNote Edited: 0016537
2009-05-20 17:10shuehnerAssigned Toshuehner => pjuvara
2009-05-21 07:21pjuvaraStatusnew => scheduled
2009-05-21 07:21pjuvaraNote Added: 0016545
2009-05-21 07:21pjuvaraAssigned Topjuvara => alostale
2009-05-21 07:21pjuvarafix_in_branch => pi
2009-05-21 16:52hgbotCheckin
2009-05-21 16:52hgbotNote Added: 0016557
2009-05-21 16:52hgbotStatusscheduled => resolved
2009-05-21 16:52hgbotResolutionopen => fixed
2009-05-21 16:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fc80fd9712afeacd305780b08217ddcf4849802c [^]
2009-05-25 11:12psarobeStatusresolved => closed
2009-05-26 00:00anonymoussf_bug_id0 => 2796609

Notes
(0016511)
shuehner   
2009-05-20 12:47   
This change reduced the visibility of one public method to package-local (by accident).

However the api review will most likely make 99% of xmlEngine non-public. Essentially everything besides a few methods which are needed to use xmlEngine.

Proposed solution: ack now, or postpone and mass-ack with the api review (scheduled for about week 22).
(0016523)
shuehner   
2009-05-20 15:03   
Developer who did the change is needed for further information: alostale
(0016536)
pjuvara   
2009-05-20 17:05   
Please review with alostale and reassign to me when it is ready for decision.
(0016537)
shuehner   
2009-05-20 17:09   
(edited on: 2009-05-20 17:10)
Checked with alostale: This change is not needed right now and can be easily reverted.

We suggest reverting it now.

The planned api review is independent of this one and do not want to mix the issues now => revert.

@Paolo: If revert is okay, please note and reassign to alostale he his commit the revert change and then close this issue with it.

(0016545)
pjuvara   
2009-05-21 07:21   
Exception rejected.

Please revert the change.
(0016557)
hgbot   
2009-05-21 16:52   
Repository: erp/devel/pi
Changeset: fc80fd9712afeacd305780b08217ddcf4849802c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu May 21 16:52:12 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fc80fd9712afeacd305780b08217ddcf4849802c [^]

fixed bug 0009112: API Change: erp_devel_pi-module-integrity-test - Build # 20 - Part4

---
M src-core/src/org/openbravo/xmlEngine/XmlVectorValue.java
---