|
Notes |
|
|
(0016610)
|
|
dbaz
|
|
2009-05-25 10:32
|
|
|
The only possible solution is set a fixed width of each column (the maximun column with should be asked to Localization team, because once the maximun is reached it won't be able to see any more digit of a column). |
|
|
|
|
David,
Could you please see if the solution proposed by dbaz is valid?
Thanks. |
|
|
|
|
Hi,
In my opinion, it's not necessary to change the standard code, because it would imply a lot of testing to check that continues to work trough several browsers and screen resolutions. I would apply the proposed solution from David to the customer that reports the bug, and just test it in their environment. It is true that a financial report is not well built if columns are not aligned from one block to another, but the official report is the one printed through the pdf file, and this is correctly built. The html report is just a draft view of the report, to easy check and look up numbers.
Once this is clear, I would say that the width of each column would be:
date column: necessary to show the text '99-99-9999'
dates debit, credit and total columns: necessary with to show the text '-999.999.999,99'
description column: the rest of available width
Regards. |
|
|
|
|
|
This issue is waiting for feedback regarding David Alsasua suggestion. |
|
|
|
|
David,
Could you please explain why % width does not work?
Thanks |
|
|
|
(0016712)
|
|
dbaz
|
|
2009-05-28 10:56
|
|
|
Because the text contained in the cells exceeds the % |
|
|
|
|
We have been doing some tests and we have realized that in GeneralLedgerReport.html, there is a table which first row has width=100% so it is doing that the rest of width columns are not being respected.
Modifying this and adjusting % width related to DAL indications above, we will make % work and appearance will be aligned and adapted to text.
(screenshot attached GLShowAll.png) |
|
|
|
|
David Baz,
Do you think that the fix proposed by networkb should be included in Openbravo ERP?
If so please schedule the issue.
Thanks. |
|
|
|
(0016729)
|
|
dbaz
|
|
2009-05-28 13:12
|
|
Since it is a particular report and not a standard behaviour for all the application, localization team should take the decision...
I reasign it to David Alsasua |
|
|
|
|
In my opinion, this should be applied only to the reporter's environment. This change of the report, makes it expand horizontally as much as needed, no matter if description is so large that the width of the report is much bigger than the width of the filters section. This is not comfortable for lower resolution monitors, and breaks the standard behavior of the ERP.
Regards. |
|
|
|
|
Just one final doubt: the only thing that we have done is to change the following line "<TD width="100%" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD>" by this other one "<TD colspan="5" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD></TR>" in ReportGeneralLedger.html file.
The behavior which follows the report when description is too large expanding horizontally as much as needed (being bigger than the width of the filters section, if necessary) is due to clause "style=table-layout: auto;" which is set in the standard pattern of table definition... so it is following the standard behavior, isn't it?
In case we want that reports data don't exceed filters section, we will need to set "style=table-layout: fixed;" and revise other table definitions... |
|
|
|
|
David Baz,
Any comment on this?
Thanks. |
|
|
|
|
|
Reminder sent to: dbaz
David Baz, could you please determine whether there is an issue in the HTML coding of this report?
Thanks. |
|
|
|
|
|
According to David Alsasua, this issue will not be fixed in standard Openbravo ERP but change can be applied to the customer. |
|
|
|
|
Hi again,
We would like to understand why this bug was closed once we had located the problem and without known David Baz's opinion. Because of that, we continue having the same doubt:
"the only thing that we have done is to change the following line "<TD width="100%" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD>" by this other one "<TD colspan="5" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD></TR>" in ReportGeneralLedger.html file.
The behavior which follows the report when description is too large expanding horizontally as much as needed (being bigger than the width of the filters section, if necessary) is due to clause "style=table-layout: auto;" which is set in the standard pattern of table definition... so it is following the standard behavior, isn't it?
In case we want that reports data don't exceed filters section, we will need to set "style=table-layout: fixed;" and revise other table definitions..."
Thanks |
|
|
|
|
Hi again,
We would like to understand why this bug was closed once we had located the problem and without known David Baz's opinion. Because of that, we continue having the same doubt:
"the only thing that we have done is to change the following line "<TD width="100%" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD>" by this other one "<TD colspan="5" class="DataGrid_Header_Cell">Cliente<SPAN id="fieldPartner2"></SPAN></TD></TR>" in ReportGeneralLedger.html file.
The behavior which follows the report when description is too large expanding horizontally as much as needed (being bigger than the width of the filters section, if necessary) is due to clause "style=table-layout: auto;" which is set in the standard pattern of table definition... so it is following the standard behavior, isn't it?
In case we want that reports data don't exceed filters section, we will need to set "style=table-layout: fixed;" and revise other table definitions..."
Thanks |
|
|
|
(0017536)
|
|
dbaz
|
|
2009-06-22 19:29
|
|
Hi networkb
At the end after reading your question I don't understand if with "style=table-layout: fixed;" you have finally succeed to fix the bug or not. If the answer is "yes" it is ok for me.
Even more, since this "bug" is only going to be fixed in your client, any solution that you find which has your client's agree is valid. |
|
|
|
|
Hi,
I attach the file we have applied to our customer. |
|
|
|
|
|
It seems that the bug is already fixed in the customer's environment and, from Engineering, we have decided not to change core. Shall we close the bug or do you need more clarifications? |
|
|
|
|
I do agree that ReportGeneralLedger.html has an issue in lines:
<div id="sectionPartner">
<table border="1" cellspacing="0" cellpadding="0" width="90%" class="DataGrid_Header_Table DataGrid_Body_Table" style="table-layout: auto;">
<tr class="DataGrid_Body_Row">
<td width="100%" class="DataGrid_Header_Cell">Customer
<span id="fieldPartner2"></span></td>
</tr>
which should be replaced by:
<div id="sectionPartner">
<table border="1" cellspacing="0" cellpadding="0" width="90%" class="DataGrid_Header_Table DataGrid_Body_Table" style="table-layout: auto;">
<tr class="DataGrid_Body_Row">
<td colspan="5" class="DataGrid_Header_Cell">Customer
<span id="fieldPartner2"></span></td>
</tr>
The current behavior looks like WithoutFix.png where the Date column takes too much width.
Applying the fix, WithFix.png, Date column takes a reasonable width but Description cell keeps being the one on which the other cells' width are based. |
|
|
|
(0018112)
|
|
hgbot
|
|
2009-07-10 16:06
|
|
Repository: erp/devel/pi
Changeset: 672dad0c98b0e1d7e4adcbf7068cbaab5323f281
Author: Rafa Roda Palacios <rafael.roda <at> openbravo.com>
Date: Fri Jul 10 16:05:48 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/672dad0c98b0e1d7e4adcbf7068cbaab5323f281 [^]
Fixes issue 0009027 Replaced width=\\"100%\\" by colspan=\\"5\\" to construct ReportGeneralLedger.html properly.
---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.html
---
|
|
|
|
|
|
Following Withfix.png image, the bug seems to be fixed |
|
showAllGL.jpg (128,876) 2009-05-13 18:54
GLShowAll.png (226,615) 2009-05-28 13:04
9027.diff (643) 2009-07-03 17:17