0008911: menu in Openbravo app called from a link does not work

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0008911

Openbravo ERP

B. User interface

public

2009-05-05 13:53

2009-08-05 11:44

Reporter

roklenardic

Assigned To

iperdomo

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Ubuntu 9.04

Product Version

2.50

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0008911: menu in Openbravo app called from a link does not work

Description

If there is a link or a button to the login screen of the Openbravo ERP such as:
* <a href="http://ec2-67-202-1-77.compute-1.amazonaws.com" [^] target="_blank">
* <input type='button' onClick="window.open('http://ec2-67-202-1-77.compute-1.amazonaws.com','vm' [^])" name="ov" value="Open My Virtual Machine">

once you login, the menu items simply do not work. if you access the same instance by copy-pasting the url into another browser (or even a new tab of the same browser) it works.

The problem is in utils.js (of PI)

line 297 and 307

if(top.opener != null) { // is a pop-up window

This is triggering in the main window because it has a top.opener (external link).

If Firebug is enabled, the error that is attached as a snapshot appears.

See also this cross-domain restriction:

Q: I can not access the properties of the new secondary window. I always
get an error in the javascript console saying "Error: uncaught
exception: Permission denied to get property <property_name or
method_name>. Why is that?

A: It is because of the cross-domain script security restriction (also
referred as the "Same Origin Policy"). A script loaded in a window (or
frame) from a distinct origin (domain name) cannot get nor set
properties of another window (or frame) or the properties of any of its
HTML objects coming from another distinct origin (domain name).
Therefore, before executing a script targeting a secondary window, the
browser in the main window will verify that the secondary window has
the same domain name.

https://developer.mozilla.org/En/DOM:window.open [^]

Steps To Reproduce

Proposed Solution

David Baz suggested:

if(top.opener != null && frames.name.indexOf('appFrame')==-1 && frames.name.indexOf('frameMenu')==-1) { // is a pop-up window

in every places of utils.js where

if(top.opener != null) or if(top.opener) appears

Additional Information

Tags

250MP1

Relationships

related to	defect	0010955	2.50MP12	closed	roklenardic	Callouts stop working in the app when called from a button
related to	defect	0019038		closed	alostale	App opened with window.open or link from another domain makes popups not to work