Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0008835Openbravo ERPY. DBSourceManagerpublic2009-04-29 16:032009-05-10 00:00
marvintm 
marvintm 
urgentcriticalhave not tried
closedfixed 
5
 
pi2.50MP1 
Core
No
0008835: If a module adds a column to a table which belongs to another module (or Core), it fails when applying the module
If a module adds a column to a table which belongs to another module (or Core), it fails when applying the module, because it tries to insert the whole table without taking into consideration the old table, instead of the usual table recreation process (which consists in creating an auxiliary table, moving the data to it, dropping the old table, creating the new table, and moving the data contained in the auxiliary table to the new one).
250MP1, Modularity
Issue History
2009-04-29 16:03marvintmNew Issue
2009-04-29 16:03marvintmAssigned To => marvintm
2009-04-29 16:03marvintmRegression testing => No
2009-04-29 16:03marvintmTag Attached: 250MP1
2009-04-29 16:03marvintmTag Attached: Modularity
2009-04-29 17:47psarobePrioritynormal => urgent
2009-04-29 17:47psarobeStatusnew => scheduled
2009-04-29 18:27marvintmNote Added: 0015943
2009-04-29 18:29hgbotCheckin
2009-04-29 18:29hgbotNote Added: 0015944
2009-04-29 18:29hgbotStatusscheduled => resolved
2009-04-29 18:29hgbotResolutionopen => fixed
2009-04-29 18:31hgbotCheckin
2009-04-29 18:31hgbotNote Added: 0015945
2009-04-29 18:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f031afa359432173791f824e8bc001cccc68a2ff [^]
2009-05-09 17:55psarobeStatusresolved => closed
2009-05-09 17:55psarobeNote Added: 0016199
2009-05-10 00:00anonymoussf_bug_id0 => 2789548

Notes
(0015943)
marvintm   
2009-04-29 18:27   
There is an additional consequence of this bug: if you manage (somehow) to install a module which adds a column to another module (or Core), and you try to uninstall it, not just the column, but the whole table will be deleted.
(0015944)
hgbot   
2009-04-29 18:29   
Repository: dbsourcemanager
Revision: 306
Author: marvintm
Date: 2009-04-29 18:29:40 +0200 (Wed, 29 Apr 2009)

Fixed issue 8835. Partial model loading will now take into account if a module adds an object to a table that is not owned by it. This should mean that modules that add columns to tables owned by other modules or Core can now be installed correctly, and when uninstalled, the whole table will not be removed from the database.

---
U trunk/src/org/apache/ddlutils/Platform.java
U trunk/src/org/apache/ddlutils/platform/ModelLoader.java
U trunk/src/org/apache/ddlutils/platform/ModelLoaderBase.java
U trunk/src/org/apache/ddlutils/platform/PlatformImplBase.java
U trunk/src/org/openbravo/ddlutils/task/AlterDatabaseDataMod.java
---

https://dev.openbravo.com/websvn/dbsourcemanager/?rev=306&sc=1 [^]
(0015945)
hgbot   
2009-04-29 18:31   
Repository: erp/devel/pi
Changeset: f031afa359432173791f824e8bc001cccc68a2ff
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Apr 29 18:30:54 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f031afa359432173791f824e8bc001cccc68a2ff [^]

Fixed issue 8835. Partial model loading will now take into account if a module adds an object to a table that is not owned by it. This should mean that modules that add columns to tables owned by other modules or Core can now be installed correctly, and when uninstalled, the whole table will not be removed from the database.

---
M src-db/database/lib/dbsourcemanager.jar
---
(0016199)
psarobe   
2009-05-09 17:55   
Tested