0008358: When package.module is called without having exported the module, the process crashes without any meaningful message

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0008358

Openbravo ERP

A. Platform

public

2009-03-31 12:14

2009-04-29 00:00

Reporter

marvintm

Assigned To

alostale

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

Fixed in Version

2.50MP1

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0008358: When package.module is called without having exported the module, the process crashes without any meaningful message

Description

When package.module is called without having exported the module, the process crashes (because it tries to zip a non-existent directory) without any message, only with a NullPointerException:

openbravo@domU-12-31-39-03-4A-44 AppsOpenbravo]$ ant package.module
> -Dmodule=com.mycompany.hotel
> Buildfile: build.xml
>
> package.module:
> [echo] Validating Module...
> [validateModules] 0 [main] WARN SystemValidation - Validation
> successfull no warnings or errors
>
> obx.export.database:
>
> obx.export.config.script:
> [extractModule] java.lang.NullPointerException
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModule.createOBX(ExtractModule.java:203)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModule.extractModule(ExtractModule.java:156)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModule.extractPackage(ExtractModule.java:175)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModule.extract(ExtractModule.java:86)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModule.extractName(ExtractModule.java:141)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModuleTask.doExecute(ExtractModuleTask.java:64)
> [extractModule] at
> org.openbravo.erpCommon.modules.ExtractModuleTask.execute(ExtractModuleTask.java:44)
> [extractModule] at
> org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:288)
> [extractModule] at
> sun.reflect.GeneratedMethodAccessor91.invoke(Unknown Source)
> [extractModule] at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> [extractModule] at java.lang.reflect.Method.invoke(Method.java:597)
> [extractModule] at
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
> [extractModule] at org.apache.tools.ant.Task.perform(Task.java:348)
> [extractModule] at
> org.apache.tools.ant.Target.execute(Target.java:357)
> [extractModule] at
> org.apache.tools.ant.Target.performTasks(Target.java:385)
> [extractModule] at
> org.apache.tools.ant.Project.executeSortedTargets(Project.java:1337)
> [extractModule] at
> org.apache.tools.ant.Project.executeTarget(Project.java:1306)
> [extractModule] at
> org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
> [extractModule] at
> org.apache.tools.ant.Project.executeTargets(Project.java:1189)
> [extractModule] at org.apache.tools.ant.Main.runBuild(Main.java:758)
> [extractModule] at org.apache.tools.ant.Main.startAnt(Main.java:217)
> [extractModule] at
> org.apache.tools.ant.launch.Launcher.run(Launcher.java:257)
> [extractModule] at
> org.apache.tools.ant.launch.Launcher.main(Launcher.java:104)
>

Of course, the process cannot complete succesfully if the module has not been exported, but a meaningful message should be provided, so the user knows that he needs to export the module (or call package.module with -Dobx.export.DB=true)

Steps To Reproduce

Proposed Solution

Additional Information