Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0008153Openbravo ERPA. Platformpublic2009-03-17 14:532009-04-22 00:01
Reporterrafaroda 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionrPath Linux
Product Versionpi 
Target VersionFixed in Version2.50 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0008153: Synchronize Terminology should not update ad_column.name in pi
DescriptionSynchronize Terminology should not update ad_column.name in pi since it can cause several issues in sample data.

See the change of an element name + synchronize terminology (changing ad_field.name + ad_column.name) [1] causing issues in sample data [2].

[1] https://code.openbravo.com/erp/devel/pi/rev/11d4a5269853a8bbb7a7e1cc51129ca86a42f9e7 [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/9f2eafe970eb [^]
Steps To Reproduce1) As System Administrator, go to 'Application Dictionary || Setup || Element'
2) Change 'Business Partner' record to 'Partner'
4) Run Synchronize Terminology process (Application Dictionary || Synchronize Terminology)
5) ant export.database.data

Everything OK until here: AD_ELEMENT, AD_COLUMN and AD_FIELD inside src-db/database/sourcedata have been changed.

6) ant export.sample.data

You will see a lot changes in referencedata/sampledata which one does not expected to happen (because the modification has been done to metadata)
Proposed Solution1) Synchronize Terminology should not update ad_column.name in pi
2) Should not be easy to modify ad_column.name
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-03-17 14:53rafarodaNew Issue
2009-03-17 14:53rafarodaAssigned To => mtaal
2009-03-17 14:53rafarodaRegression testing => No
2009-03-17 14:54rafarodaStatusnew => scheduled
2009-03-17 14:54rafarodafix_in_branch => pi
2009-03-20 16:57mtaalNote Added: 0014824
2009-03-20 16:58mtaalAssigned Tomtaal => alostale
2009-03-23 10:01hgbotCheckin
2009-03-23 10:01hgbotNote Added: 0014844
2009-03-23 10:01hgbotStatusscheduled => resolved
2009-03-23 10:01hgbotResolutionopen => fixed
2009-03-23 10:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8137e5253e158f4bea680d76be7fd8d1dc283bcc [^]
2009-03-24 14:01jayakumarNote Added: 0014899
2009-04-06 11:42rafarodaNote Added: 0015216
2009-04-21 10:32psarobeStatusresolved => closed
2009-04-22 00:01anonymoussf_bug_id0 => 2778080

Notes
(0014824)
mtaal   
2009-03-20 16:57   
Remark from Ismael:

Synchronize terminology should modify ad_column.name only first time, when the
ad_element is assigned to the column but not later. Asier will take care of
this.
(0014844)
hgbot   
2009-03-23 10:01   
Repository: erp/devel/pi
Changeset: 8137e5253e158f4bea680d76be7fd8d1dc283bcc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Mar 23 10:00:53 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8137e5253e158f4bea680d76be7fd8d1dc283bcc [^]

fixed bug 0008153: Synchronize Terminology should not update ad_column.name in pi

---
M src-db/database/model/functions/AD_SYNCHRONIZE.xml
M src-db/database/model/triggers/AD_ELEMENT_TRG.xml
---
(0014899)
jayakumar   
2009-03-24 14:01   
If We have fixed in Element (Application Dictionary || Setup || Element  ||  Element ), it was been changed automatically in ad_column and ad_field by Synchronize Terminology process earlier. So the changes was reflect in ad_element, ad_column and ad_field. Now it did not work that way. Its only changed on AD_Element now. Its not changed in AD_COLUMN and AD_FIELD now by Synchronize Terminology Process. It is different from earlier behavior. Could you please advice?
(0015216)
rafaroda   
2009-04-06 11:42   
Hi Jay,

The fix worked for me following the steps described: no changes in AD_COLUMN nor in SmallBazaar.xml were done.

Regards.