Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0008134Openbravo ERPA. Platformpublic2009-03-12 16:352009-03-26 18:02
shuehner 
shuehner 
highmajoralways
closedfixed 
5
pi 
2.40MP4 
Core
No
0008134: Double representation should not be used for numbers as it is inprecise
Double's are still used as intermediate representation in two places. Depending on values and configured precision this leads to wrong numbers displayed to the user.

XmlEngine/DataGrid (still) use Double when formatting according to formats defined in Format.xml
- Go to MRP -> Manufacturing plan
- Enter a header
- Enter a single line
- Execute the following sql in the underlying database (just to shortcut the process of entering this value):
update mrp_run_productionline set qty = '0.77777777777777777777777777';
- Last step changes the quantity of all Manufacturingplan lines to this value.
- edit config/Format.xml
  change the formatOutput value for "qtyRelation" to "#,##0.###############################"
- display the manufacturing plan line again and so that not the correct value (as entered in the update step) is displayed but a different one.
- The correct value should be displayed as the configured Format.xml entry has more digits as the example quantity value.
Fix XmlEngine & DataGrid to not use double as intermediate format when formatting numbers.

No tags attached.
blocks defect 0008098 closed shuehner Double representation should not be used for numbers as it is inprecise 
Issue History
2009-03-16 11:39rafarodaTypedefect => backport
2009-03-16 11:39rafarodafix_in_branch => 2.40
2009-03-18 13:54hgbotCheckin
2009-03-18 13:54hgbotNote Added: 0014785
2009-03-18 13:54hgbotStatusscheduled => resolved
2009-03-18 13:54hgbotResolutionopen => fixed
2009-03-18 13:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/ae2fd76d5f215377d8a73f45005c56750dad203d [^]
2009-03-24 11:01psarobeFixed in Version => 2.40MP4
2009-03-26 18:02psarobeStatusresolved => closed

Notes
(0014785)
hgbot   
2009-03-18 13:54   
Repository: erp/stable/2.40
Changeset: ae2fd76d5f215377d8a73f45005c56750dad203d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Mar 18 13:25:37 2009 +0100
URL: http://code.openbravo.com/erp/stable/2.40/rev/ae2fd76d5f215377d8a73f45005c56750dad203d [^]

Fixed 8134: changed outputformatting in edit & grid view to not use double as intermediate representation
Use BigDecimal instead to avoid floating point problems

---
M src-core/src/org/openbravo/xmlEngine/FieldValue.java
M src/org/openbravo/erpCommon/utility/DataGrid.java
---