Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0008070Openbravo ERPE. Translationpublic2009-03-11 14:582009-06-22 08:04
Reporteralostale 
Assigned Toalostale 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0008070: Translations do not work for manual windows if they don't set defaultLang variable
DescriptionOn line translation is taking the language to translate to from the defaultLang variable in HTML. This makes that in case this variable is not (properly) set the translation is not correctly performed.
Steps To Reproduce-Create a new manual window with translatable tags
-In the HTML do not include the defaultLang variable
-Run ant translate to generate text interfaces for the new window
-Translate these new entries to another lanugage
-Change application language to that langue
-Go to the window and check it is not translated at all
Proposed SolutionIn org.openbravo.uiTranslation.TranslationHandler.setLanguage method do not retrieve language information from html variable but from session variable (vars.getLanguage())
Additional Information
TagsNo tags attached.
Relationships
related to defect 0009353 closed alostale With the application in spanish, terms of some reports are in English 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-03-11 14:58alostaleNew Issue
2009-03-11 14:58alostaleAssigned To => pheenan
2009-03-11 14:58alostaleRegression testing => No
2009-03-12 13:37rafarodaPrioritynormal => high
2009-03-12 13:37rafarodaStatusnew => scheduled
2009-03-12 13:37rafarodaversion => pi
2009-03-24 10:40AinhoaPagolaAssigned Topheenan => alostale
2009-04-03 19:12shuehnerNote Added: 0015195
2009-04-20 15:03alostaleStatusscheduled => closed
2009-04-20 15:03alostaleNote Added: 0015440
2009-04-20 15:03alostaleResolutionopen => no change required
2009-04-21 00:00anonymoussf_bug_id0 => 2776828
2009-06-22 07:23alostaleRelationship addedrelated to 0009353
2009-06-22 08:04hgbotCheckin
2009-06-22 08:04hgbotNote Added: 0017498
2009-06-22 08:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/906b65e00d8ea79456e03603b757c1e6bc60c91a [^]

Notes
(0015195)
shuehner   
2009-04-03 19:12   
This current behavior to use defaultLang is consistent with translation of i.e. calendar & calculator. They do use this info for determining the language. It was added for these users in the first place.
(0015440)
alostale   
2009-04-20 15:03   
As Stefan says, this defaultLang is also needed for calendar and calculator so even we made not needed for interface we would still require it. Thus it is not worth to modify xmlEngine to retrieve it from session instead from html.
(0017498)
hgbot   
2009-06-22 08:04   
Repository: erp/devel/pi
Changeset: 906b65e00d8ea79456e03603b757c1e6bc60c91a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jun 22 08:04:09 2009 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/906b65e00d8ea79456e03603b757c1e6bc60c91a [^]

fixed bug 009353: With the application in spanish, terms of some reports are in English
  Fixed several problems in online translation:
    -Template was not properly selected for files not ending in .html
    -Langauge was not taken for templates without language tag (reported as issue 8070)
    -Text was not properly trimmed when doing the online translation

---
M src-core/src/org/openbravo/base/HttpBaseServlet.java
M src-core/src/org/openbravo/uiTranslation/TranslationUtils.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
M src-core/src/org/openbravo/xmlEngine/XmlEngine.java
---