Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007920Openbravo ERPF. Localizationpublic2009-03-03 15:212009-07-26 22:07
ReporterMbX7174 
Assigned Topheenan 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50alpha-r11 
Target VersionFixed in Version2.50MP3 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0007920: Translation fails, because the ad_textinterfaces table refers to a file, using an relative path, application uses absolute path
DescriptionTextInterfacesData::selectText() creates a 3-fold SQL query (UNION).
The selects, indicated by orderSeq 3 and 1 do not function properly, because the htmlFile parameter given to the selectText-method is a fully qualified file name (absolute path), while the filename-field in the ad_textinterfaces table refers to the files, using a relative path (/org/...).
Steps To Reproduce1) Introduce Spanish into Openbravo
2) Switch OB to Spanish
3) Print a Sales Invoice

Result:

The invoice notes do not get translated because of the bug.
Proposed SolutionThe filename is used for 2 purposes:
1) To locate the JRXML file on the local file system (absolute path is needed)
2) To compose the query in the ad_textinterfaces table

Separate both concerns, or inject a prefix that can crop the fully qualified file name.
Additional Information
Tags250MP3releasecandidate, commsup_sprint7, leo
Relationships
Attached Filespdf InvoiceReport.20090303-143117.pdf (40,634) 2009-03-03 15:21
https://issues.openbravo.com/file_download.php?file_id=959&type=bug
Issue History
Date ModifiedUsernameFieldChange
2009-03-03 15:21MbX7174New Issue
2009-03-03 15:21MbX7174Assigned To => rafaroda
2009-03-03 15:21MbX7174File Added: InvoiceReport.20090303-143117.pdf
2009-03-03 15:49rafarodaAssigned Torafaroda => pheenan
2009-03-04 19:54hgbotCheckin
2009-03-04 19:54hgbotNote Added: 0014403
2009-03-04 19:54hgbotStatusnew => resolved
2009-03-04 19:54hgbotResolutionopen => fixed
2009-03-04 19:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/548a51c5302da5a20f6092ca0814baeae4828595 [^]
2009-03-06 09:30pheenanTag Attached: commsup_sprint7
2009-04-21 10:53psarobeStatusresolved => closed
2009-04-22 00:01anonymoussf_bug_id0 => 2778042
2009-07-03 13:11hgbotCheckin
2009-07-03 13:11hgbotNote Added: 0017799
2009-07-03 13:11hgbotStatusclosed => resolved
2009-07-03 13:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/548a51c5302da5a20f6092ca0814baeae4828595 [^] => http://code.openbravo.com/erp/devel/pi/rev/35d3cb4c25c13a090714bddcf3e1521fe8efb827 [^]
2009-07-21 16:24psarobeFixed in Version2.50 => 2.50MP3
2009-07-21 16:26psarobeTag Attached: 250MP3releasecandidate
2009-07-21 18:43psarobeTag Attached: leo
2009-07-26 22:07psarobeStatusresolved => closed

Notes
(0014403)
hgbot   
2009-03-04 19:54   
Repository: erp/devel/pi
Changeset: 548a51c5302da5a20f6092ca0814baeae4828595
Author: Phil Heenan <phillip.heenan <at> openbravo.com>
Date: Wed Mar 04 19:54:01 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/548a51c5302da5a20f6092ca0814baeae4828595 [^]

Fixed 7920. Modified query input to use a shortened version of the file path. Updated translation handling for manual forms to ensure translations are returned. Implemented translation for sub reports passed through the PrintController.

---
M src-core/src/org/openbravo/uiTranslation/TranslationHandler.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/erpCommon/ad_process/JasperProcess.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
---
(0017799)
hgbot   
2009-07-03 13:11   
Repository: erp/devel/pi
Changeset: 35d3cb4c25c13a090714bddcf3e1521fe8efb827
Author: Phil Heenan <phillip.heenan <at> openbravo.com>
Date: Wed Mar 04 19:54:01 2009 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/35d3cb4c25c13a090714bddcf3e1521fe8efb827 [^]

Fixed 7920. Modified query input to use a shortened version of the file path. Updated translation handling for manual forms to ensure translations are returned. Implemented translation for sub reports passed through the PrintController.

---
M src-core/src/org/openbravo/uiTranslation/TranslationHandler.java
M src-core/src/org/openbravo/xmlEngine/XmlDocument.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/erpCommon/ad_process/JasperProcess.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/erpCommon/utility/reporting/ReportManager.java
---