Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0007901Openbravo ERP02. Master data managementpublic2009-03-02 18:102012-06-13 17:29
shuehner 
Sandrahuguet 
lowminorhave not tried
closedfixed 
5
2.40MP2 
 
Core
No
0007901: isactive is ignored for table m_product_bom (Bill of Materials tab in Product window)
The code for i.e. calculated Quantity on hand or prices for products which have a bill of materials does not check the isactive flag.

So deactivating of BOM entries seems not possible without deleting an entry.
Check the code of i.e. one of the following functions:

BOM_PRICELIMIT, BOM_PRICELIST, ...

to see that the iteration of the BOM is done without respecting the isactive flag of the m_product_bom table.
Clean-up, OB3-Reviewed
related to design defect 0007902 acknowledged mirurita Check that isactive is used when it exists in a table 
Issue History
2009-03-02 18:10shuehnerNew Issue
2009-03-02 18:10shuehnerAssigned To => rafaroda
2009-03-02 18:10shuehnerRegression testing => No
2009-03-02 18:13shuehnerRelationship addedrelated to 0007902
2009-03-04 08:43rafarodaTag Attached: Clean-up
2009-03-04 08:44rafarodaAssigned Torafaroda => shuehner
2009-03-04 08:44rafarodaPrioritynormal => low
2009-03-04 08:44rafarodaStatusnew => acknowledged
2009-03-04 08:44rafarodaAssigned Toshuehner => gorkaion
2011-11-25 10:20gorkaionTag Attached: OB3-Reviewed
2012-05-10 12:05SandrahuguetStatusacknowledged => scheduled
2012-05-10 12:05SandrahuguetAssigned Togorkaion => Sandrahuguet
2012-05-10 12:05Sandrahuguetfix_in_branch => pi
2012-05-11 09:50SandrahuguetNote Added: 0048571
2012-05-11 10:09SandrahuguetNote Edited: 0048571bug_revision_view_page.php?bugnote_id=0048571#r3450
2012-05-11 10:18SandrahuguetNote Edited: 0048571bug_revision_view_page.php?bugnote_id=0048571#r3451
2012-06-13 17:27dmiguelezNote Added: 0049819
2012-06-13 17:28hgbotCheckin
2012-06-13 17:28hgbotNote Added: 0049820
2012-06-13 17:28hgbotStatusscheduled => resolved
2012-06-13 17:28hgbotResolutionopen => fixed
2012-06-13 17:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8bb97e60e1d0e799505ae26893b906488b636db5 [^]
2012-06-13 17:29dmiguelezStatusresolved => closed

Notes
(0048571)
Sandrahuguet   
2012-05-11 09:50   
(edited on: 2012-05-11 10:18)
Test Plan:
Go to product and create:
Product p11
 -Organization: F&B US, Inc.
 -Name:p11
 -stocked=Y
 -bill of materials:N
 -tab price: price list: general sales, net unit price=5, net list price=5
Product p12
 -Organization: F&B US, Inc.
 -Name:p12
 -stocked=Y
 -bill of materials:N
 -tab price: price list: general sales, net unit price=6, net list price=6
Product p1
 -Organization: F&B US, Inc.
 -Name:p1
 -stocked=N
 -bill of materials:y
 -tab price: price list: general sales, net unit price=0, net list price=0
 -tab Bill of matenials
   -bom product:p11, active:yes
   -bom product:p12, active:no
 -Click Verify BOM
Product p2
 -Organization: F&B US, Inc.
 -Name:p2
 -stocked=Y
 -bill of materials:N
 -tab price: price list: general sales, net unit price=1.5, net list price=1.5
Product p
 -Organization: F&B US, Inc.
 -Name:p
 -stocked=N
 -bill of materials:y
 -tab price: price list: general sales, net unit price=0, net list price=0
 -tab Bill of matenials
   -bom product:p1, active: yes
   -bom product:p2, active: yes
 -Click Verify BOM

Go to sales invoice and create one
 -Organization: F&B US, Inc.
 -Business partner: Healthy Food Supermarkets, Co.
 -Payment Terms: 30 days
 -Payment Method: Wire Transfer
 -Line tab: product=p, net unit price=0, line net amout=0
 -Click complete
 -Notice that you can only see active bill of material products in sales invoice lines.

(0049819)
dmiguelez   
2012-06-13 17:27   
Code Review + Testing OK
(0049820)
hgbot   
2012-06-13 17:28   
Repository: erp/devel/pi
Changeset: 8bb97e60e1d0e799505ae26893b906488b636db5
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri May 11 09:25:47 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bb97e60e1d0e799505ae26893b906488b636db5 [^]

Fixed bug 7901 Add flag isactive=Y when used m_product_bom table

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/model/functions/M_BOM_PRICELIMIT.xml
M src-db/database/model/functions/M_BOM_PRICELIST.xml
M src-db/database/model/functions/M_BOM_PRICESTD.xml
M src-db/database/model/functions/M_BOM_QTY_ONHAND.xml
M src-db/database/model/functions/M_BOM_QTY_ORDERED.xml
M src-db/database/model/functions/M_BOM_QTY_RESERVED.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
M src-db/database/model/functions/M_PRODUCT_BOM_CHECK.xml
---