Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007581Openbravo ERP02. Master data managementpublic2009-02-16 17:412009-03-18 11:03
Reporternetworkb 
Assigned Topheenan 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version2.35MP5 
Target VersionFixed in Version2.50beta 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0007581: Import file loader does not take into account Field format sequence
DescriptionIf a new Import Loader Format is created and its lines are created randomly ( I mean, field format sequence is not 10,20,30...), when a csv file is imported using this file format, information is not well organized.

Import process in Import File Loader does not take into account the sequence created in Field Format tab. It takes into account the order which those lines were created (you can see it looking at ad_impformat_row table)
Steps To Reproduce1 Generate a new Import Loader Format. Use I_Bpartner table, and Semicolon separator.
2 Define its line randomly. (See atached file in order to generate its lines).
Generate first line with sequence 110, 10, 30, etc.
3 Go to Import File loader form. Select the previous file format and use the attached csv.

If you look at i_bpartner table, you will see that information has not been stored in the correct field.
Proposed Solution
Additional Information
Tagscommsup_sprint6
Relationships
depends on backport 0007583 closed pheenan Import file loader does not take into account Field format sequence 
depends on backport 0007584 closed pheenan Import file loader does not take into account Field format sequence 
Attached Filesjpg 2.jpg (140,264) 2009-02-16 17:42
https://issues.openbravo.com/file_download.php?file_id=849&type=bug
jpg

csv mis_prov.csv (299) 2009-02-17 16:45
https://issues.openbravo.com/file_download.php?file_id=857&type=bug
csv mis_prov_corrected.csv (275) 2009-02-17 19:21
https://issues.openbravo.com/file_download.php?file_id=862&type=bug
Issue History
Date ModifiedUsernameFieldChange
2009-02-16 17:41networkbNew Issue
2009-02-16 17:41networkbAssigned To => rafaroda
2009-02-16 17:41networkbFile Added: mis_prov.csv
2009-02-16 17:41networkbRegression testing => No
2009-02-16 17:42networkbFile Added: 2.jpg
2009-02-16 18:23rafarodaAssigned Torafaroda => pheenan
2009-02-16 18:23rafarodaStatusnew => scheduled
2009-02-16 18:23rafarodafix_in_branch => trunk
2009-02-17 09:43pheenanTag Attached: commsup_sprint6
2009-02-17 16:21svnbotCheckin
2009-02-17 16:21svnbotNote Added: 0013576
2009-02-17 16:21svnbotStatusscheduled => resolved
2009-02-17 16:21svnbotResolutionopen => fixed
2009-02-17 16:21svnbotsvn_revision => 13279
2009-02-17 16:44pheenanStatusresolved => new
2009-02-17 16:44pheenanResolutionfixed => open
2009-02-17 16:44pheenanNote Added: 0013577
2009-02-17 16:45pheenanFile Deleted: mis_prov.csv
2009-02-17 16:45pheenanFile Added: mis_prov.csv
2009-02-17 16:45pheenanStatusnew => scheduled
2009-02-17 16:46pheenanStatusscheduled => resolved
2009-02-17 16:46pheenanResolutionopen => fixed
2009-02-17 16:46pheenanNote Added: 0013578
2009-02-17 17:06svnbotCheckin
2009-02-17 17:06svnbotNote Added: 0013586
2009-02-17 17:06svnbotsvn_revision13279 => 13284
2009-02-17 19:20svnbotCheckin
2009-02-17 19:20svnbotNote Added: 0013597
2009-02-17 19:20svnbotsvn_revision13284 => 13295
2009-02-17 19:20pheenanStatusresolved => new
2009-02-17 19:20pheenanResolutionfixed => open
2009-02-17 19:20pheenanNote Added: 0013598
2009-02-17 19:21pheenanFile Added: mis_prov_corrected.csv
2009-02-17 19:23pheenanNote Added: 0013600
2009-02-17 19:24pheenanStatusnew => closed
2009-02-17 19:24pheenanNote Added: 0013601
2009-02-17 19:24pheenanResolutionopen => no change required
2009-03-18 11:03anonymoussf_bug_id0 => 2691397

Notes
(0013576)
svnbot   
2009-02-17 16:21   
Repository: openbravo
Revision: 13279
Author: pheenan
Date: 2009-02-17 16:21:17 +0100 (Tue, 17 Feb 2009)

Fixed 7581. int field constant being used to alter the array iterator when it bears no impact on the count. Due to this fields were being skipped causing the values in the data rows to be assigned to the wrong fields.

---
U trunk/src/org/openbravo/erpCommon/ad_forms/FileImport.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13279&sc=1 [^]
(0013577)
pheenan   
2009-02-17 16:44   
Reopening issue to change the test csv file which contains an error.
(0013578)
pheenan   
2009-02-17 16:46   
Changing to resolved again after attaching a corrected csv test file
(0013586)
svnbot   
2009-02-17 17:06   
Repository: openbravo
Revision: 13284
Author: pheenan
Date: 2009-02-17 17:06:39 +0100 (Tue, 17 Feb 2009)

Fixed 7583. Backport for issue 7581. Removing constant integer which caused the array iterator to go out of sequence.

---
U branches/r2.40/src/org/openbravo/erpCommon/ad_forms/FileImport.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13284&sc=1 [^]
(0013597)
svnbot   
2009-02-17 19:20   
Repository: openbravo
Revision: 13295
Author: pheenan
Date: 2009-02-17 19:20:33 +0100 (Tue, 17 Feb 2009)

Rolling back changes made for issue 7581. This is not a real issue but a case of the documentation not clearly stating how to work with the import files and the file definitions.

---
U trunk/src/org/openbravo/erpCommon/ad_forms/FileImport.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=13295&sc=1 [^]
(0013598)
pheenan   
2009-02-17 19:20   
rolling back commit. Not actually an issue.
(0013600)
pheenan   
2009-02-17 19:23   
This issue relates to the use of constant fields and their inclusion in the import file. Constant fields should not be included in the import file. Need to add this to the wiki documentation to make this point clearer.
(0013601)
pheenan   
2009-02-17 19:24   
Updated OB Support with the actual issue. Have attached a correctly formatted import file which has been tested and imports correctly.