Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0007493 | Openbravo ERP | A. Platform | public | 2009-02-11 11:04 | 2009-04-22 00:00 |
|
| Reporter | schmidtm | |
| Assigned To | alostale | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 2.40 | |
| Target Version | | Fixed in Version | 2.50beta | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0007493: Application can not be deployed on Servlet 2.4-compliant webcontainer like Glassfish v3 |
| Description | While migrating OpenBravo to Glassfish v3 (prelude release) we discovered this exception on deployment:
java.lang.IllegalArgumentException: Invalid URL Pattern: [
/ad_callouts/SL_ProductionPlan_Conversion.html
]
at com.sun.enterprise.deployment.node.web.ServletMappingNode.setElementValue(ServletMappingNode.java:88)
at com.sun.enterprise.deployment.node.SaxParserHandler.endElement(SaxParserHandler.java:423)
This is because our com.sun.enterprise.util.net.URLPattern.isValid() enforces the Servlet 2.4 spec:
SRV.13.2 Rules for Processing the Deployment Descriptor:
"URI paths specified in the deployment descriptor are assumed to be in URLdecoded
form. The containers must inform the developer with a descriptive
error message when URL contains CR(#xD) or LF(#xA). The containers must
preserve all other characters including whitespace in URL."
This constraint has been added to Servlet-2.4.
Most Servlet-2.3 implementations like tomcat are more forgiving by swalloing this in web.xml:
<url-pattern>
/ad_callouts/SL_ProductionPlan_Conversion.html
</url-pattern>
Whereas for GFv3 and other 2.4-compliant webcontainers you have to modify this into:
<url-pattern>/ad_callouts/SL_ProductionPlan_Conversion.html</url-pattern>
I bet you don't write these aprox. 2000 servlet-mappings by hand, therefore it should be no big deal
to write them without CR/NL given that it's still backward-compatible and should cause no other grieve.
I've added a patch for your reference.
cheers,
Matthias Schmidt
Sun Microsystems, Inc.
|
| Steps To Reproduce | |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  web.xml.diff.gz (49,950) 2009-02-11 11:04
https://issues.openbravo.com/file_download.php?file_id=828&type=bug
 wad-rv24.patch (946) 2009-02-11 12:58
https://issues.openbravo.com/file_download.php?file_id=829&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2009-02-11 11:04 | schmidtm | New Issue | |
| 2009-02-11 11:04 | schmidtm | Assigned To | => rafaroda |
| 2009-02-11 11:04 | schmidtm | File Added: web.xml.diff.gz | |
| 2009-02-11 11:05 | rafaroda | Assigned To | rafaroda => jpabloae |
| 2009-02-11 11:34 | jpabloae | Status | new => acknowledged |
| 2009-02-11 12:58 | jpabloae | File Added: wad-rv24.patch | |
| 2009-02-11 12:59 | jpabloae | Note Added: 0013341 | |
| 2009-02-11 12:59 | jpabloae | Assigned To | jpabloae => alostale |
| 2009-02-18 11:43 | alostale | OBNetwork customer | => No |
| 2009-02-18 11:43 | alostale | Severity | critical => minor |
| 2009-02-20 08:49 | svnbot | Checkin | |
| 2009-02-20 08:49 | svnbot | Note Added: 0013783 | |
| 2009-02-20 08:49 | svnbot | Status | acknowledged => resolved |
| 2009-02-20 08:49 | svnbot | Resolution | open => fixed |
| 2009-02-20 08:49 | svnbot | svn_revision | => 13443 |
| 2009-04-21 10:54 | psarobe | Status | resolved => closed |
| 2009-04-22 00:00 | anonymous | sf_bug_id | 0 => 2777926 |