0007465: FACT_ACCT_RESET database procedure unposts all manual settlements when unposting one record

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0007465

Openbravo ERP

09. Financial management

public

2009-02-02 19:20

2009-03-06 11:05

Reporter

galderromo

Assigned To

eduardo_Argal

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

RedHat

Product Version

2.35MP4

Target Version

Fixed in Version

2.40MP3

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0007465: FACT_ACCT_RESET database procedure unposts all manual settlements when unposting one record

Description

When having 5000 manual settlements and 5000 invoices.
If you want to unpost a manual settlement to unprocess the settlement, all the manual settlements are unposted.
Posting manual settlements with no direct accounting means changing all settlements from posted='N' to posted='Y'.
When you want to unpost a manual settlement, you just want to update posted='Y' to posted='N' so you can unprocess the settlement.
But the application unposts all the manual settlements. Although it does not change the accounting information, the accounting background process posts again all the 5000 manual settlements. So you have to wait until this are posted before the invoices get also posted.

Steps To Reproduce

Introduce 5 manual settlement.
Post them.
Unpost a manual settlement. Also the log says: "Success 5 updated".

Proposed Solution

Improve code at FACT_ACCT_RESET around line 220:

        v_Cmd:='UPDATE ' || Cur_Tables.TableName || ' SET Posted=''N'', Processing=''N'' WHERE AD_Client_ID=''' || Cur_Clients.AD_Client_ID
        || ''' AND (Posted=''Y'' OR Processing<>''N'' OR Processing IS NULL) AND NOT EXISTS (SELECT 1 FROM FACT_ACCT WHERE AD_TABLE_ID =''' || Cur_Tables.AD_Table_ID ||
        ''' AND RECORD_ID = ' || Cur_Tables.TableName || '_ID AND AD_CLIENT_ID =''' || Cur_Clients.AD_Client_ID || ''' )';
            -- DBMS_OUTPUT.PUT_LINE(' executing: ' || v_Cmd);

updates all the records not having accounting info at fact_acct.

Additional Information