Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0007306Openbravo ERPA. Platformpublic2009-02-02 10:032009-03-06 12:34
mtaal 
mtaal 
normalmajorhave not tried
closedfixed 
5
pi 
pi 
Core
No
0007306: Solve various validation errors reported by the validate.database task
The reported validation errors with the change which needs to be made:

c.- Table C_TEMP_SELECTION and C_TEMP_SELECTION2 present in the database but
not defined in the Application Dictionary -> MTA should change the
validation to not take into account "TEMPORARY" tables when reading db
tables. Both tables are not in our standard model but generated in the
prescript. Temporary tables will never be part of our model (dbSourceManager
will never create a temporary table from the model). DB dictionary tables
(USER_TABLES) have a isTemporary column ("TEMPORARY" in oracle)
d.- Mandatory but nullable columns: I would disable this validation in 2.50.
To properly manage this case we need to implement the "mandatory" attribute
in fields. In 2.60 there is a clean-up project planned that should enable
back this validation and include a review on this columns. -> MTA should
send an email to Stefan -who will lead the cleanup- to put this as a feature
request for the cleanup project. You should explain to him the validation
process because for sure Stefan will extend it with new rules during the
clean-up
e.- Not nullable but not mandatory columns -> MTA should set all of them as
mandatory in AD (automatic script)
f.- Wrong type: mistakes with lists -> MTA should change the validation for
lists, it should be VARCHAR(60). In my last email I said that datatype in
lists should be VARCHAR2(60) but it is the sub-type in oracle (sorry, my
fault). VARCHAR2 in oracle is equivalent to VARCHAR in postgresql and the
type in our model is VARCHAR (afaic you are using DBSourceManager to read
the model from db). Oracle has VARCHAR2 and NVARCHAR2 and not VARCHAR AND
NVARCHAR (strange naming in oracle due to historical reasons).
g.- Wrong type: mistakes with USER1_ID, USER2_ID -> MTA should change the
ad_reference_id of these columns to 10 (string) and ad_referencevalue_id to
null (these columns are supposed to be used as foreing keys to user defined
dimensions, so they should be tableDir or tableReference or search, but
since the referenced entity does not exist is is better to put them as
string)
No tags attached.
Issue History
2009-02-02 10:03mtaalNew Issue
2009-02-02 10:03mtaalAssigned To => mtaal
2009-02-02 10:03mtaalsf_bug_id0 => 2556395
2009-02-02 10:03mtaalRegression testing => No
2009-02-03 10:52psarobeStatusnew => scheduled
2009-02-03 10:52psarobefix_in_branch => trunk
2009-02-04 14:56svnbotCheckin
2009-02-04 14:56svnbotNote Added: 0013143
2009-02-04 14:56svnbotStatusscheduled => resolved
2009-02-04 14:56svnbotResolutionopen => fixed
2009-02-04 14:56svnbotsvn_revision => 12775
2009-03-06 12:34psarobeStatusresolved => closed

Notes
(0013143)
svnbot   
2009-02-04 14:56   
Repository: openbravo
Revision: 12775
Author: mtaal
Date: 2009-02-04 14:55:55 +0100 (Wed, 04 Feb 2009)

Fixes issue 7306, Solve various validation errors reported by the validate.database task

---
U trunk/src/org/openbravo/base/model/ModelProvider.java
U trunk/src/org/openbravo/base/model/Property.java
U trunk/src/org/openbravo/service/system/DatabaseValidator.java
U trunk/src-db/database/model/tables/AD_EXCEPTIONS.xml
U trunk/src-db/database/model/tables/AD_FIELD.xml
U trunk/src-db/database/model/tables/C_BANKSTATEMENTLINE.xml
U trunk/src-db/database/model/tables/C_CASHLINE.xml
U trunk/src-db/database/model/tables/C_TAXPAYMENT.xml
U trunk/src-db/database/sourcedata/AD_COLUMN.xml
U trunk/src-db/database/sourcedata/AD_ELEMENT.xml
U trunk/src-db/database/sourcedata/AD_FIELD.xml
U trunk/src-db/database/sourcedata/AD_TABLE.xml
U trunk/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12775&sc=1 [^]