Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0007089Openbravo ERPA. Platformpublic2009-01-23 11:082009-04-21 12:39
Reporteralostale 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0007089: Dynamic redirect to tabs do not work for modules in manual code
DescriptionIn some manual windows a WAD window is called. As windows defined within modules have a different URL pattern when these windows are trying to redirect to a WAD window in a module it doesn't work.

The problem appears with this code in a number of manual windows:

            String strWindowPath = "", strTabName = "";
            if (tab != null && tab.length != 0) {
                strTabName = FormatUtilities.replace(tab[0].name);
                strWindowPath = "../"
                        + FormatUtilities.replace(tab[0].description) + "/"
                        + strTabName + "_Relation.html";
            } else
                strWindowPath = strDefaultServlet;

            printPageClosePopUp(response, vars, strWindowPath);

Here the URL to be called is composed as the window name and the tab name which is not valid for modules.
Steps To Reproduce
Proposed SolutionThe way to obtain the URL for a tab shouldn't be hardcoded but it should be obtainable through a method.
Additional Information
TagsModularity
Relationships
related to defect 0007026 closed alostale Links to new module windows do not work 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-01-23 11:08alostaleNew Issue
2009-01-23 11:08alostaleAssigned To => alostale
2009-01-23 11:08alostalesf_bug_id0 => 2530779
2009-01-23 11:08alostaleOBNetwork customer => No
2009-01-23 11:08alostaleRegression testing => No
2009-01-23 11:09rafarodaTag Attached: Modularity
2009-01-23 11:09alostaleNote Added: 0012555
2009-01-23 11:09alostaleNote Added: 0012557
2009-01-28 08:46rafarodaversion => trunk
2009-01-30 15:44alostaleRelationship addedrelated to 0007026
2009-01-30 17:13rafarodaStatusnew => scheduled
2009-02-04 12:30svnbotCheckin
2009-02-04 12:30svnbotNote Added: 0013128
2009-02-04 12:30svnbotStatusscheduled => resolved
2009-02-04 12:30svnbotResolutionopen => fixed
2009-02-04 12:30svnbotsvn_revision => 12753
2009-02-04 13:11svnbotCheckin
2009-02-04 13:11svnbotNote Added: 0013133
2009-02-04 13:11svnbotsvn_revision12753 => 12759
2009-02-04 14:15svnbotCheckin
2009-02-04 14:15svnbotNote Added: 0013140
2009-02-04 14:15svnbotsvn_revision12759 => 12768
2009-04-21 12:39psarobeStatusresolved => closed

Notes
(0012555)
alostale   
2009-01-23 11:09   
Review all the closePopup* and redirect methods.
Also review the hardcoded links
(0012557)
alostale   
2009-01-23 11:09   
after this fix the new method should be added to the developers guide
(0013128)
svnbot   
2009-02-04 12:30   
Repository: openbravo
Revision: 12753
Author: alostale
Date: 2009-02-04 12:30:46 +0100 (Wed, 04 Feb 2009)

fixed bug 0007089: Dynamic redirect to tabs do not work for modules in manual code

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CopyFromSettlement.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateVatRegisters.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/DropRegFactAcct.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/EditCCPMeasureValues.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ExportReferenceData.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/InsertAcces.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectClose.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectCopyFrom.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/RequestAction.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/Test_In.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/UpdateMaintenanceScheduled.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AlertManagement.java
U trunk/src/org/openbravo/erpCommon/ad_forms/AlertManagement_data.xsql
U trunk/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java
U trunk/src/org/openbravo/erpCommon/ad_process/CopyFromGLJournal.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportAccountServlet.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBPartnerServlet.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportBudgetServlet.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportOrderServlet.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportProductServlet.java
U trunk/src/org/openbravo/erpCommon/ad_process/ImportTaxServlet.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAcctRedirectUtility.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAcctRedirectUtility_data.xsql
U trunk/src/org/openbravo/erpCommon/businessUtility/TabFilter.java
U trunk/src/org/openbravo/erpCommon/utility/UsedByLink.java
U trunk/src/org/openbravo/erpCommon/utility/Utility.java
U trunk/src/org/openbravo/erpCommon/utility/WindowTree.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12753&sc=1 [^]
(0013133)
svnbot   
2009-02-04 13:11   
Repository: openbravo
Revision: 12759
Author: alostale
Date: 2009-02-04 13:11:29 +0100 (Wed, 04 Feb 2009)

Added missing file for issue 0007089

---
A trunk/src/org/openbravo/erpCommon/utility/Tab_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=12759&sc=1 [^]
(0013140)
svnbot   
2009-02-04 14:15   
Repository: openbravo
Revision: 12768
Author: huehner
Date: 2009-02-04 14:15:21 +0100 (Wed, 04 Feb 2009)

Issue 7089
Fix trunk build on postgres, was broken in r12759

---
U trunk/src/org/openbravo/erpCommon/utility/Tab_data.xsql
---

https://dev.openbravo.com/websvn/openbravo/?rev=12768&sc=1 [^]