Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0007085Openbravo ERPE. Translationpublic2009-01-23 10:182022-02-01 08:08
gforcada 
Triage Platform Base 
normalminoralways
newopen 
5
pi 
 
Core
No
0007085: Don't export columns that doesn't contain text
When a language is exported and a row doesn't contain a Description, but others has, an empty <value column="Description" original=""></value> is added to that <row>, for example:

<row id="100" trl="Y">
  <value column="Name" original="Table">Table</value>
  <value column="CommitWarning" original=""></value>
  <value column="Description" original="Define tables that Openbravo can access in the database.">Define tables that Openbravo can access in the database.</value>
  <value column="Help" original="Define tables that Openbravo can access in the database.">Define tables that Openbravo can access in the database.</value>
</row>

The CommitWarning column is empty in this row, so it shouldn't be exported at all.

And when importing the translation, if a row doesn't have a column it should skip that column for that row (or add the default language - English - translation, if any).

This is somewhat related to https://issues.openbravo.com/view.php?id=7009 [^]
No tags attached.
Issue History
2009-01-23 10:18gforcadaNew Issue
2009-01-23 10:18gforcadaAssigned To => rafaroda
2009-01-23 10:18gforcadasf_bug_id0 => 2530698
2009-01-23 16:37jordimasIssue Monitored: jordimas
2009-01-28 08:48rafarodaversion => trunk
2009-01-30 17:15rafarodaNote Added: 0012932
2009-01-30 17:15rafarodaStatusnew => feedback
2009-02-02 10:30gforcadaNote Added: 0012988
2009-02-10 10:11rafarodaAssigned Torafaroda => pheenan
2009-02-10 10:12rafarodaNote Added: 0013288
2009-02-12 10:38gforcadaNote Added: 0013394
2009-02-20 09:09pjuvaraNote Added: 0013785
2009-02-20 09:09pjuvaraStatusfeedback => new
2009-03-03 12:33rafarodaStatusnew => acknowledged
2009-03-03 12:33rafarodaTypedefect => feature request
2009-03-24 10:43AinhoaPagolaAssigned Topheenan => alostale
2011-05-18 16:13hgbotCheckin
2011-05-18 16:13hgbotNote Added: 0037157
2011-05-18 16:13hgbotStatusacknowledged => resolved
2011-05-18 16:13hgbotResolutionopen => fixed
2011-05-18 16:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.localization.spain.referencedata.taxes/rev/8226c24bc331167c0e9a1d190a97e414807f06c1 [^]
2011-06-10 12:40shuehnerNote Added: 0038226
2011-06-10 12:40shuehnerStatusresolved => new
2011-06-10 12:40shuehnerResolutionfixed => open
2017-04-10 14:38alostaleAssigned Toalostale => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0012932)
rafaroda   
2009-01-30 17:15   
Hi Gil,

First of all, could you please write down the steps to reproduce this issue.

Secondly, is this really a defect in the 'Export translation' functionality or a feature request?

Thank you.
(0012988)
gforcada   
2009-02-02 10:30   
Sorry it's a feature request.

The issue is that when those xml files with empty <value> are exported to po files with Openbravo2PO they add false translations which is not an issue for a translator, but is an issue for a statistics system.

If we remove those <value> when exporting to xml files Openbravo2PO or any other tool used to interact with the xml files will not have empty strings to translate.
(0013288)
rafaroda   
2009-02-10 10:12   
Reminder sent to: gforcada

Gil, can you please add the steps to reproduce this issue?

Thank you.
(0013394)
gforcada   
2009-02-12 10:38   
Steps:

- Export a language from Openbravo ERP to xml files
- run "grep 'original=""' *.xml" in the directory that contains the language xml files
- you will see 16834 lines in the it_IT/trunk for example (it was updated on 2009-02-11)

All those <value> are meaningless since they doesn't contain anything. and when exported to po files they cause confusions when calculating the statistics.
(0013785)
pjuvara   
2009-02-20 09:09   
Feedback has been provided.
(0037157)
hgbot   
2011-05-18 16:13   
Repository: erp/mods/org.openbravo.localization.spain.referencedata.taxes
Changeset: 8226c24bc331167c0e9a1d190a97e414807f06c1
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed May 18 13:31:04 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.localization.spain.referencedata.taxes/rev/8226c24bc331167c0e9a1d190a97e414807f06c1 [^]

Fixes issue 7085: Dataset should not contain any tax checked as default

---
M referencedata/standard/Impuestos_ES.xml
---
(0038226)
shuehner   
2011-06-10 12:40   
Reopen, as commit resolving it has intended for another issues (17085)