0007019: Implement batch validation of application dictionary and module

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0007019

Openbravo ERP

A. Platform

public

2009-01-20 10:25

2009-03-06 12:34

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0007019: Implement batch validation of application dictionary and module

Description

Batch Validation:
A separate ant task which can be run from the command line with the following checks. The check task will print warnings and errors.

1: ad columns = bd columns: (so there are no physical columns not mapped nor logical columns not in the bd)

2: tables withou primary key

3: Datatype mismatch as per reference: physical type of the column does not match the ad.
eg: reflist should be varchar2(60), or amount should be number...

4: Foreign keys not declared (as per reference). It should just be a warning, and audit info should be excluded (we don't declare foreing key for updatedby and createdby columns)

5: Code in a module should be within the declared javaPackage of the module

6: all modules should finally depend on core

7. Industry templates (module of type "Industry Template") should include core as a module
Extra info:
[09:32:37] iciordia: for the last two (modules depend on core and IT include core), all you need to know is:
[09:34:19] … ad_module_dependency is the table where dependencies and includes are stored
[09:35:06] … the column "isincluded" is a boolean to define if it is a dependency or an include
[09:35:31] … standard modules depend on other modules, and all of them should finally depend on core

8: licensetype and license should not be null. If they are null the validation will send a warning or an error depending on when are we validating (always a warning but when executing package.module)

The above tasks should be done also during module export and when building the system.

Things to take into account for the implementation:
- the validation should be callable for a single module
- the errors/warnings are returned in a result object, so that the caller can decide to print the errors/warnings or throw exceptions

Steps To Reproduce

Proposed Solution

Additional Information