Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0006918Openbravo ERPA. Platformpublic2009-01-15 16:012009-04-21 12:39
Reportericiordia 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Versionany
Product Versionpi 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0006918: Name of "Package" tab is not clear enough
DescriptionIn the Module window there is a "Package" tab where packages for classes generated by DAL for each table are declared.
Steps To Reproduce
Proposed SolutionBetter names for this tab can be:
-Table package
-Data package
-Data Service package

Additionally, an explanation of what a Package is (including some examples) should be included in the help of that tab.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-01-15 16:01iciordiaNew Issue
2009-01-15 16:01iciordiaAssigned To => mtaal
2009-01-15 16:01iciordiasf_bug_id0 => 2510112
2009-01-15 16:01iciordiaRegression testing => No
2009-01-15 16:33mtaalNote Added: 0012224
2009-01-19 11:23psarobeStatusnew => scheduled
2009-01-19 11:23psarobeNote Added: 0012311
2009-01-19 11:23psarobefix_in_branch => trunk
2009-02-02 17:46svnbotCheckin
2009-02-02 17:46svnbotNote Added: 0013031
2009-02-02 17:46svnbotStatusscheduled => resolved
2009-02-02 17:46svnbotResolutionopen => fixed
2009-02-02 17:46svnbotsvn_revision => 12678
2009-04-21 12:39psarobeStatusresolved => closed

Notes
(0012224)
mtaal   
2009-01-15 16:33   
Also add extra info to the help of the following columns of the ad_table table:
- name
- classname
- ad_package_id

Here is a copy from the email send to the development team:

Related to this change, when adding a new table the following is relevant:

- the AD_Table.name field is used as the tag name in xml when exporting and importing data for records in the table. The same xml/tag name is used when constructing Webservice messages. So it makes sense to choose a readable and understandable name here.

- when defining a table as part of a module development then the AD_Table.name needs to be prefixed with one of the DBPrefixes defined for that module, the prefix is the DBPrefix plus the underscore character, for example: PREFIX_MyTable.

- The same prefixing rule applies to the AD_Table.tablename (the physical table name in the database).

- a AD_Table record has a mandatory relation to a package (the AD_Package). Choose a sensible package fitting to the functional area to which the table applies (so not the Core package). If no such package exist then create a new one. The relation to the module is maintained through the AD_Package, so an AD_Table has an AD_Package which belongs to a module. When developing for a module then first a package needs to be defined in AD_Package, linked to the module. Then the records in AD_Table (for that module) can be linked to that package.

- the AD_Table.classname is used when generating a representation of the table in java (the entity or business object, see the src-gen directory). The classname is the simplename of the class (so without the package name). Often the AD_Table.name can be used here. The combination of classname and package needs to be unique.

The above info will also be added to the developers guide.
(0012311)
psarobe   
2009-01-19 11:23   
1. Login with system administration role
2. Go to Application dictionary->Module
(0013031)
svnbot   
2009-02-02 17:46   
Repository: openbravo
Revision: 12678
Author: mtaal
Date: 2009-02-02 17:45:45 +0100 (Mon, 02 Feb 2009)

Changed triggers to use error message numbers which fit to oracle also
Fixes issue 6918 Name of "Package" tab is not clear enough
Changed validation to work by module, added validation to check object name length
Database validation can be done by module

---
U trunk/referencedata/standard/Masterdata.xml
U trunk/src/org/openbravo/service/system/DatabaseValidator.java
U trunk/src/org/openbravo/service/system/ModuleValidator.java
U trunk/src/org/openbravo/service/system/SystemValidationResult.java
U trunk/src/org/openbravo/service/system/SystemValidationTask.java
U trunk/src-db/database/model/triggers/AD_MODULE_TRANSLATION_TRG.xml
U trunk/src-db/database/model/triggers/AD_MODULE_VERSION_TRG.xml
U trunk/src-db/database/model/triggers/AD_PACKAGE_JP_TRG.xml
U trunk/src-db/database/sourcedata/AD_COLUMN.xml
U trunk/src-db/database/sourcedata/AD_DATASET_TABLE.xml
U trunk/src-db/database/sourcedata/AD_ELEMENT.xml
U trunk/src-db/database/sourcedata/AD_FIELD.xml
U trunk/src-db/database/sourcedata/AD_MESSAGE.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
U trunk/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
U trunk/src-db/database/sourcedata/AD_TABLE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12678&sc=1 [^]