0006882: Line with English description created in sales invoice by "Generate invoices"

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0006882

Openbravo ERP

07. Sales management

public

2009-01-14 11:04

2011-02-04 09:15

Reporter

networkb

Assigned To

rmorley

Priority

high

Severity

minor

Reproducibility

always

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

2.40

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0006882: Line with English description created in sales invoice by "Generate invoices"

Description

If you look at a sales invoice lines generated by "Generate invoices" process, there is one line without product and a description like
"Delivery Note" + Document No.

This line should be translated to some language.

Actually, this line is generated within C_INVOICE_CREATE procedure [1] (business logic) that is not able to take a language.

[1] https://dev.openbravo.com/websvn/openbravo/trunk/src-db/database/model/functions/C_INVOICE_CREATE.xml [^]

(SELECT dt.PrintName || ' ' || ox.DocumentNo||' '||(
                      CASE
                        WHEN ox.PoReference IS NULL
                        THEN NULL
                        ELSE '('||ox.PoReference||')'
                      END
                      ) AS Reference
                    FROM C_DOCTYPE dt,
                      C_ORDER ox
                    WHERE dt.C_DocType_ID=ox.C_Order_ID
                      AND ox.C_Order_ID=Cur_Order.C_Order_ID
                    ORDER BY ox.DocumentNo DESC

Steps To Reproduce

Go to Sales Management > Transactions > Generate Invoices
Select any filter and press Ok.
Go to Sales invoice and select one of the created invoice.
Go to its lines.
One of them has a description like "Delivery Note" + Document No, without product.
This description should be translated.

Proposed Solution

The description should be translated or maybe this line could be deleted.

Actually, this can not be implemented yet since Multi Language Support (MLS) is still not available.

Business Logic should not depend on the language of the logged user that launches the business logic but on some other "business" language. The same happens when printing an invoice for a customer that is not speaking logged user's language.

Additional Information

Tags

Clean-up, Localization, ReleaseCandidate, trlImprove

Relationships

related to	feature request	0002202	pi	acknowledged	rmorley	AT235: MLS needed in General Accounting Report Setup
blocks	feature request	0004058		acknowledged	rmorley	Translation management