Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0006584Openbravo ERPZ. Otherspublic2008-12-16 15:242009-04-21 11:07
shuehner 
Hennadzi 
highmajorhave not tried
closedfixed 
5
pi 
 
Core
No
0006584: Potential NullpointerException
The File:
src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java


contains the following line in the logout method:

if (request.getSession().getAttribute("#Authenticated_user") != null || !request.getSession().getAttribute("#Authenticated_user").equals("")) {

The OR condition does not make any sense here and leads to a NPE for the equals("") call, if getAttribute() really returns null. The condition should very likely be AND here.

comsup_sprint3
Issue History
2008-12-16 15:24shuehnerNew Issue
2008-12-16 15:24shuehnerAssigned To => rafaroda
2008-12-16 15:24shuehnersf_bug_id0 => 2433560
2008-12-16 15:24shuehnerRegression testing => No
2008-12-16 17:14shuehnerNote Added: 0011435
2008-12-16 17:14shuehnerPrioritynormal => high
2008-12-16 17:14shuehnerSeverityminor => major
2008-12-18 16:08rafarodaStatusnew => scheduled
2008-12-18 16:08rafarodaAssigned Torafaroda => Hennadzi
2008-12-18 16:08rafarodafix_in_branch => trunk
2008-12-18 17:41svnbotCheckin
2008-12-18 17:41svnbotNote Added: 0011537
2008-12-18 17:41svnbotStatusscheduled => resolved
2008-12-18 17:41svnbotResolutionopen => fixed
2008-12-18 17:41svnbotsvn_revision => 11385
2008-12-18 17:45HennadziTag Attached: comsup_sprint3
2009-04-21 11:07psarobeStatusresolved => closed

Notes
(0011435)
shuehner   
2008-12-16 17:14   
Updated priority as this bug leads to a NPE on every logout.
(0011537)
svnbot   
2008-12-18 17:41   
Repository: openbravo
Revision: 11385
Author: hennadzi
Date: 2008-12-18 17:41:14 +0100 (Thu, 18 Dec 2008)

Bug fixed 0006584: Potential NullpointerException

---
U trunk/src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=11385&sc=1 [^]