Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0006536Openbravo ERPA. Platformpublic2008-12-14 21:212009-01-27 16:06
mtaal 
shuehner 
lowmajorhave not tried
closedduplicate 
5
pi 
 
Core
No
0006536: Mutable servlet fields
Servlet should not have members as one servlet instance can be used by multiple threads at the same time. This occurs 45 times in Openbravo code:
(when searching for the location on your own system, strip of the /home/mtaal/mydata/dev/workspaces/obtrunk/ part):

/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/utility/ExportGrid.java:106 M M MSF: org.openbravo.erpCommon.utility.ExportGrid.st is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:191 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.windowNameEnUS is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:1054 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Client_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java:555 M M MSF: org.openbravo.erpCommon.ad_forms.InitialOrgSetup.AD_User_U_Name is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:65 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.tabName is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:402 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_Org_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/Translation.java:584 M M MSF: org.openbravo.erpCommon.ad_forms.Translation.m_IsCentrallyMaintained is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:189 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.tabId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:344 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.clientName is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:64 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.tableId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java:554 M M MSF: org.openbravo.erpCommon.ad_forms.InitialOrgSetup.AD_User_U_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_process/SendMailText.java:185 M M MSF: org.openbravo.erpCommon.ad_process.SendMailText.g_log is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java:99 M M MSF: org.openbravo.erpCommon.ad_actionButton.CreateRegFactAcct.RevenueAmtDr is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:107 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.windowId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/utility/ExportGrid.java:55 M M MSF: org.openbravo.erpCommon.utility.ExportGrid.gridBO is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java:301 M M MSF: org.openbravo.erpCommon.utility.reporting.printing.PrintController.pocData is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:63 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.tabId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:445 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_Product_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java:97 M M MSF: org.openbravo.erpCommon.ad_actionButton.CreateRegFactAcct.ExpenseAmtDr is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/Role.java:149 M M MSF: org.openbravo.erpCommon.ad_forms.Role.strIsRTL is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java:74 M M MSF: org.openbravo.erpCommon.ad_reports.MInOutTraceReports.strmProductIdGlobal is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:259 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.windowId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:500 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_User_Name is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_process/SendMailText.java:184 M M MSF: org.openbravo.erpCommon.ad_process.SendMailText.errors is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/utility/PrintJR.java:89 M M MSF: org.openbravo.erpCommon.utility.PrintJR.jasperReport is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:190 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.tableId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java:98 M M MSF: org.openbravo.erpCommon.ad_actionButton.CreateRegFactAcct.ExpenseAmtCr is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_process/SendMailText.java:183 M M MSF: org.openbravo.erpCommon.ad_process.SendMailText.counter is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:187 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.tabName is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:445 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_Project_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:68 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.windowNameEnUS is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java:77 M M MSF: org.openbravo.erpCommon.ad_reports.MInOutTraceReports.strmAttributesetinstanceIdGlobal is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:66 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.windowName is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:417 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_Account_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:445 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_BPartner_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_process/SendMailText.java:267 M M MSF: org.openbravo.erpCommon.ad_process.SendMailText.mailResult is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/srcAD/org/openbravo/erpCommon/ad_actionButton/ActionButtonJava_Responser.java:123 M M MSF: org.openbravo.erpCommon.ad_actionButton.ActionButtonJava_Responser.strProcessId is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java:67 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline_Lines.tabNameEnUS is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:499 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_User_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialClientSetup.java:445 M M MSF: org.openbravo.erpCommon.ad_forms.InitialClientSetup.AD_Tree_SalesRegion_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java:517 M M MSF: org.openbravo.erpCommon.ad_forms.InitialOrgSetup.AD_Org_ID is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:186 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.windowName is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java:191 M M MSF: org.openbravo.erpCommon.ad_forms.InvoiceVendorMultiline.tabNameEnUS is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java:100 M M MSF: org.openbravo.erpCommon.ad_actionButton.CreateRegFactAcct.RevenueAmtCr is a mutable servlet field
/home/mtaal/mydata/dev/workspaces/obtrunk/openbravo/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java:163 M M MSF: org.openbravo.erpCommon.ad_reports.MInOutTraceReports.count is a mutable servlet field
Clean-up
duplicate of defect 0006283 closed alostale Openbravo servlet classes have (static) members which are changed by post/get actions 
Issue History
2008-12-14 21:21mtaalNew Issue
2008-12-14 21:21mtaalAssigned To => rafaroda
2008-12-14 21:21mtaalsf_bug_id0 => 2429175
2008-12-14 21:21mtaalRegression testing => No
2008-12-18 15:44rafarodaTag Attached: Clean-up
2008-12-18 15:44rafarodaAssigned Torafaroda => shuehner
2008-12-18 15:44rafarodaPrioritynormal => low
2008-12-18 15:44rafarodaStatusnew => acknowledged
2009-01-27 16:05shuehnerStatusacknowledged => scheduled
2009-01-27 16:05shuehnerfix_in_branch => trunk
2009-01-27 16:06shuehnerRelationship addedduplicate of 0006283
2009-01-27 16:06shuehnerStatusscheduled => closed
2009-01-27 16:06shuehnerNote Added: 0012692
2009-01-27 16:06shuehnerDuplicate ID0 => 6283
2009-01-27 16:06shuehnerResolutionopen => duplicate

Notes
(0012692)
shuehner   
2009-01-27 16:06   
Same topic really and the fix will be done in the other issue 6283.