0006492: Send alerts by e-mail - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0006492

Openbravo ERP

01. General setup

public

2008-12-11 16:46

2009-04-21 11:05

Reporter

ccasuso

Assigned To

anthony_wolski

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.40

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0006492: Send alerts by e-mail

Description

In an alert, in tab 'Alert Recipient' selecting a role and an user, Openbravo sends an email to all users with this role.

Steps To Reproduce

1.- Selecting an alert
2.- In tab 'Alert Recipient' selecting a role and an user and marking 'Send Email'
3.- Openbravo sends an email to all users with the selected role (It must sends only an email to the selected user)

Proposed Solution

At file 'PeriodicAlert_data.xsql', at method 'prepareMails', the clause SQL must be:
           SELECT C.SMTPHOST,
                       REQUESTUSER,
                       REQUESTUSERPW,
                       C.REQUESTEMAIL AS MAILFROM,
                       U.EMAIL AS MAILTO,
                       C.AD_LANGUAGE
                  FROM AD_ALERTRECIPIENT R,
                       AD_USER U,
                       AD_CLIENT C
                 WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
                   AND SENDEMAIL = 'Y'
                   AND R.AD_USER_ID = U.AD_USER_ID
                   AND C.AD_CLIENT_ID = U.AD_CLIENT_ID

instead:

          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_USER U,
                 AD_CLIENT C
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND R.AD_USER_ID = U.AD_USER_ID
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
          union
          SELECT C.SMTPHOST,
                 REQUESTUSER,
                 REQUESTUSERPW,
                 C.REQUESTEMAIL AS MAILFROM,
                 U.EMAIL AS MAILTO,
                 C.AD_LANGUAGE
            FROM AD_ALERTRECIPIENT R,
                 AD_CLIENT C,
                 AD_USER U
           WHERE AD_ALERTRULE_ID = TO_NUMBER(?)
             AND SENDEMAIL = 'Y'
             AND C.AD_CLIENT_ID = U.AD_CLIENT_ID
             and u.ad_user_id in (select ad_user_id
                                    from ad_user_roles ur
                                   where ur.ad_role_id = r.ad_role_id)

Additional Information