Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0006367Openbravo ERP01. General setuppublic2008-12-04 16:322009-02-18 15:07
plujan 
dbaz 
normalminorhave not tried
closedfixed 
5
pi 
pi 
Core
No
0006367: On user window, when changing password I can get an error by typing fast
I'm on User window (either modifying or creating a new one). When I open the pop up window to set the password, if my password ends on a capital letter and I do not release the Shift key before hitting Enter, I get an incorrect window (see attach)
1. Create a new user or go to an existent one.
2. Click on password button. The pop up window is displayed.
3. Enter a password, by example "userA". *Release* the Shift key and hit Enter. The behavior is correct, the window closes and the main window is refreshed.
4. Open the password pop up again. Enter password "userA" again. This time, *hold* the Shift key when hitting Enter. The pop up window is refreshed with an incorrect window inside (see attach)

No tags attached.
jpg BUG_PasswordEntering.JPG (145,183) 2008-12-04 16:32
https://issues.openbravo.com/file_download.php?file_id=492&type=bug
jpg
Issue History
2008-12-04 16:32plujanNew Issue
2008-12-04 16:32plujanAssigned To => rafaroda
2008-12-04 16:32plujansf_bug_id0 => 2389154
2008-12-04 16:32plujanFile Added: BUG_PasswordEntering.JPG
2008-12-04 16:32plujanRegression testing => No
2008-12-09 13:06pheenanAssigned Torafaroda => dbaz
2008-12-15 01:20dbazStatusnew => scheduled
2008-12-15 01:20dbazfix_in_branch => trunk
2008-12-26 22:53dbazNote Added: 0011741
2008-12-26 23:00dbazNote Edited: 0011741
2008-12-26 23:01svnbotCheckin
2008-12-26 23:01svnbotNote Added: 0011742
2008-12-26 23:01svnbotStatusscheduled => resolved
2008-12-26 23:01svnbotResolutionopen => fixed
2008-12-26 23:01svnbotsvn_revision => 11593
2009-02-18 15:07sureshbabuStatusresolved => closed
2009-02-18 15:07sureshbabuNote Added: 0013664
2009-02-18 15:07sureshbabuFixed in Version => trunk

Notes
(0011741)
dbaz   
2008-12-26 22:53   
(edited on: 2008-12-26 23:00)
This problem is quite complex:

Problem 1:
* In Firefox for security issues, when there is a popup, SHIFT + ENTER do the submit and it avoid that the popup close (perhaps ad-block capabilities)
* I have created a dummy function to catch SHIFT + ENTER to avoid this issue, so now SHIFT+ENTER doesn't do anything in popups.

Problem 2:
* Firefox issue: When a popup refresh its content with another html, the focus doesn't remain properly in the popup. After trying there is no any option to fix it via Javascript. In IE the behavior is correct.
* To workaround this Firefox issue I have changed the first focused element to the "Cancel" button instead of the textbox. With this change, a TAB press of the user is needed to focus the textbox obtaining:
   - User keyboard interaction to do the proper popup focus
   - Usability security to avoid directly change the password once the popup is opened.
* The only way its keep failing is if user pick the textbox with the mouse and then press SHIFT + ENTER... which is a very strange way of use the app.

EDITED: The Firefox bug is solved in Firefox 3.1. So in Firefox 3.1 beta 2 it works as in IE7... so in Firefox 3.1 there won't be any problem regarding to this.

(0011742)
svnbot   
2008-12-26 23:01   
Repository: openbravo
Revision: 11593
Author: dbaz
Date: 2008-12-26 23:01:18 +0100 (Fri, 26 Dec 2008)

Fixed bug 6367: Now shift+enter is not catched in application popups

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/EncryptedButtons.html
U trunk/web/js/shortcuts.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=11593&sc=1 [^]
(0013664)
sureshbabu   
2009-02-18 15:07   
Retested in context 79.125.56.185/openbravotrunk