0006284: Use of double instead of BigDecimal, double is very inprecise

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0006284

Openbravo ERP

A. Platform

public

2008-11-30 23:10

2009-01-07 15:43

Reporter

mtaal

Assigned To

Dowid

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0006284: Use of double instead of BigDecimal, double is very inprecise

Description

There are a few cases in Openbravo source code where a double type is used. A double is far more in-precise than a BigDecimal. Always a BigDecimal should be used.
See for example this code in the ReportGeneralLedger class:
        double amount = 0.0;
        for (int i=0;data2!=null && i<data2.length;i++){
          if (data2[i].factAcctId.equals(data[0].factAcctId)) {
            if (log4j.isDebugEnabled()) log4j.debug("break i:"+i);
            break;
          };
          // if (data2[i].id.equals(data[0].id))
          if ((data2[i].partner.equals(data[0].partner) && (!(strcBpartnerId.equals("")&&(strAll.equals("")))))||(strcBpartnerId.equals("")&&(strAll.equals(""))))
            amount += Double.valueOf(data2[i].total).doubleValue();
        }

Here a BigDecimal should be used.

Search for the use of double in the source tree and repair the incorrect uses.

Steps To Reproduce

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

duplicate of	defect	0004512	2.50	closed	vmromanos	Float Point Errors
depends on	backport	0006477		closed	vmromanos	Use of double instead of BigDecimal, double is very inprecise