Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0006283Openbravo ERPA. Platformpublic2008-11-30 23:052009-03-06 12:34
mtaal 
alostale 
highmajoralways
closedfixed 
5
pi 
pi 
Core
No
0006283: Openbravo servlet classes have (static) members which are changed by post/get actions
Servlet objects are accessed by multiple threads. This means that it is not possible/not correct to have members (static or non-static) in a servlet class which are manipulated by get/post methods. Openbravo contains numerous cases of java members in a servlet (more than 100 cases at least). Check for example the tableSql member in servlet classes.

All Openbravo servlet classes should be checked for this illegal and incorrect pattern.
platform1_sprint1
has duplicate defect 0006536 closed shuehner Mutable servlet fields 
Issue History
2008-11-30 23:05mtaalNew Issue
2008-11-30 23:05mtaalAssigned To => rafaroda
2008-11-30 23:05mtaalsf_bug_id0 => 2367145
2008-11-30 23:05mtaalRegression testing => No
2008-12-01 13:00shuehnerIssue Monitored: shuehner
2008-12-01 13:08shuehnerNote Added: 0010841
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-16 17:49rafarodaAssigned Torafaroda => alostale
2008-12-16 17:49rafarodaStatusnew => acknowledged
2008-12-17 11:02alostaleTag Attached: platform1_sprint1
2009-01-19 13:39psarobeStatusacknowledged => scheduled
2009-01-19 13:39psarobeversion => trunk
2009-01-27 09:00svnbotCheckin
2009-01-27 09:00svnbotNote Added: 0012661
2009-01-27 09:00svnbotsvn_revision => 12298
2009-01-27 15:48svnbotCheckin
2009-01-27 15:48svnbotNote Added: 0012691
2009-01-27 15:48svnbotsvn_revision12298 => 12322
2009-01-27 16:06shuehnerRelationship addedhas duplicate 0006536
2009-01-28 11:02svnbotCheckin
2009-01-28 11:02svnbotNote Added: 0012722
2009-01-28 11:02svnbotsvn_revision12322 => 12350
2009-01-28 11:27svnbotCheckin
2009-01-28 11:27svnbotNote Added: 0012724
2009-01-28 11:27svnbotsvn_revision12350 => 12351
2009-01-28 14:01svnbotCheckin
2009-01-28 14:01svnbotNote Added: 0012729
2009-01-28 14:01svnbotsvn_revision12351 => 12368
2009-01-28 14:28svnbotCheckin
2009-01-28 14:28svnbotNote Added: 0012730
2009-01-28 14:28svnbotsvn_revision12368 => 12374
2009-01-28 15:50svnbotCheckin
2009-01-28 15:50svnbotNote Added: 0012737
2009-01-28 15:50svnbotsvn_revision12374 => 12383
2009-01-28 16:17svnbotCheckin
2009-01-28 16:17svnbotNote Added: 0012739
2009-01-28 16:17svnbotsvn_revision12383 => 12387
2009-01-28 16:27svnbotCheckin
2009-01-28 16:27svnbotNote Added: 0012740
2009-01-28 16:27svnbotsvn_revision12387 => 12389
2009-01-28 16:32svnbotCheckin
2009-01-28 16:32svnbotNote Added: 0012742
2009-01-28 16:32svnbotsvn_revision12389 => 12390
2009-01-28 16:39svnbotCheckin
2009-01-28 16:39svnbotNote Added: 0012745
2009-01-28 16:39svnbotsvn_revision12390 => 12393
2009-01-28 16:44svnbotCheckin
2009-01-28 16:44svnbotNote Added: 0012749
2009-01-28 16:44svnbotsvn_revision12393 => 12395
2009-01-28 17:02svnbotCheckin
2009-01-28 17:02svnbotNote Added: 0012759
2009-01-28 17:02svnbotsvn_revision12395 => 12399
2009-01-28 18:14svnbotCheckin
2009-01-28 18:14svnbotNote Added: 0012767
2009-01-28 18:14svnbotsvn_revision12399 => 12411
2009-01-28 18:26svnbotCheckin
2009-01-28 18:26svnbotNote Added: 0012768
2009-01-28 18:26svnbotsvn_revision12411 => 12413
2009-01-29 11:37svnbotCheckin
2009-01-29 11:37svnbotNote Added: 0012794
2009-01-29 11:37svnbotsvn_revision12413 => 12446
2009-01-29 11:40svnbotCheckin
2009-01-29 11:40svnbotNote Added: 0012795
2009-01-29 11:40svnbotsvn_revision12446 => 12448
2009-01-29 12:37svnbotCheckin
2009-01-29 12:37svnbotNote Added: 0012806
2009-01-29 12:37svnbotsvn_revision12448 => 12463
2009-01-29 12:53svnbotCheckin
2009-01-29 12:53svnbotNote Added: 0012809
2009-01-29 12:53svnbotsvn_revision12463 => 12466
2009-01-29 13:18alostaleStatusscheduled => resolved
2009-01-29 13:18alostaleFixed in Version => trunk
2009-01-29 13:18alostaleResolutionopen => fixed
2009-01-30 20:01shuehnerIssue End Monitor: shuehner
2009-03-06 12:34psarobeStatusresolved => closed

Notes
(0010841)
shuehner   
2008-12-01 13:08   
Ack. At least the tableSQL case is easy to fix, as the object is always created in doPost and then used in some navigation functions called from within doPost (first,next,previous..., Element)
(0012661)
svnbot   
2009-01-27 09:00   
Repository: openbravo
Revision: 12298
Author: alostale
Date: 2009-01-27 09:00:37 +0100 (Tue, 27 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed HttpSecureAppServlet.myTheme memeber, instead of using this one take its value from session and
refactored the methods that used it

---
U trunk/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateFile.java
U trunk/src/org/openbravo/erpCommon/ad_actionButton/ProjectSetType.java
U trunk/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java
U trunk/src/org/openbravo/erpCommon/ad_process/ApplyModules.java
U trunk/src/org/openbravo/erpCommon/ad_process/CreateTest.java
U trunk/src/org/openbravo/erpCommon/ad_process/DisplayJasper.java
U trunk/src/org/openbravo/erpCommon/ad_process/RescheduleProcess.java
U trunk/src/org/openbravo/erpCommon/ad_process/ScheduleProcess.java
U trunk/src/org/openbravo/erpCommon/ad_process/TestHeartbeat.java
U trunk/src/org/openbravo/erpCommon/ad_process/UnscheduleProcess.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportAcctRedirectUtility.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportExpense.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoicesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportParetoProduct.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProductionCost.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSiteJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalyses.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportRefundSalesDimensionalAnalysesPDF.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoicedJasper.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvidedJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipper.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportToInvoiceConsignmentJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
U trunk/src/org/openbravo/erpCommon/ad_workflow/WorkflowControl.java
U trunk/src/org/openbravo/erpCommon/businessUtility/Buscador.java
U trunk/src/org/openbravo/erpCommon/info/AttributeSetInstance.java
U trunk/src/org/openbravo/erpCommon/utility/ExecuteTask.java
U trunk/src/org/openbravo/erpCommon/utility/OpenPentaho.java
U trunk/src/org/openbravo/erpCommon/utility/PrintJR.java
U trunk/src/org/openbravo/erpCommon/utility/UsedByLink.java
U trunk/src/org/openbravo/erpCommon/utility/WindowTree.java
U trunk/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
U trunk/src/org/openbravo/erpReports/ReportTaxPaymentJR.java
U trunk/src/org/openbravo/erpReports/ReportVatRegisterJR.java
U trunk/src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml
U trunk/src-wad/src/org/openbravo/wad/ActionButton_Responser.javaxml
U trunk/src-wad/src/org/openbravo/wad/javasource.javaxml
U trunk/src-wad/src/org/openbravo/wad/javasourceSortTab.javaxml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12298&sc=1 [^]
(0012691)
svnbot   
2009-01-27 15:48   
Repository: openbravo
Revision: 12322
Author: huehner
Date: 2009-01-27 15:48:30 +0100 (Tue, 27 Jan 2009)

Issue 6283
Remove instance fields from ExportGrid servlet
- one statement was allocated but never used
- second one is instance of helper class which was changed to static

---
U trunk/src/org/openbravo/erpCommon/utility/ExportGrid.java
U trunk/src/org/openbravo/erpCommon/utility/GridBO.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12322&sc=1 [^]
(0012722)
svnbot   
2009-01-28 11:02   
Repository: openbravo
Revision: 12350
Author: alostale
Date: 2009-01-28 11:02:22 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

HttpSecureAppServlet.classInfo is now not set in the service method but in the init one, thus is only initialized
once per servlet. In addition the name which is used by Jasper Reports is not calculated based on the language
anymore, it's maintained only for backwards compatibility. The REPORT_TITLE parameter is now set automatically to
Reports in the renderJR method.

---
U trunk/src/org/openbravo/base/secureApp/ClassInfo_data.xsql
U trunk/src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportBankJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportCashJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedger.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportGuaranteeDateJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscountJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportInvoicesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportMaterialTransactionEditionJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoiceJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPendingProductionJr.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProductionRunJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProjectBuildingSiteJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportProjectProgress.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderInvoicedJasper.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderOpenItemJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportSalesOrderProvidedJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportShipmentEditionJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportStandardCostJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportTaxInvoiceJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportToInvoiceConsignmentJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWarehouseDetailInventoryJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartnerJR.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily.java
U trunk/src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementJR.java
U trunk/src/org/openbravo/erpCommon/utility/PrintJR_data.xsql
U trunk/src/org/openbravo/erpCommon/utility/Utility.java
U trunk/src/org/openbravo/erpReports/ReportTaxPaymentJR.java
U trunk/src/org/openbravo/erpReports/ReportVatRegisterJR.java
U trunk/src/org/openbravo/erpReports/RptC_Remittance.java
U trunk/src/org/openbravo/erpReports/RptC_RemittanceJR.java
U trunk/src/org/openbravo/erpReports/RptMA_ProcessPlan.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12350&sc=1 [^]
(0012724)
svnbot   
2009-01-28 11:27   
Repository: openbravo
Revision: 12351
Author: alostale
Date: 2009-01-28 11:27:29 +0100 (Wed, 28 Jan 2009)

related to issue 0006283: Remaining title

---
U trunk/src/org/openbravo/erpReports/RptC_RemittanceJR.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12351&sc=1 [^]
(0012729)
svnbot   
2009-01-28 14:01   
Repository: openbravo
Revision: 12368
Author: alostale
Date: 2009-01-28 14:01:52 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

tableSQL is not a member of the WAD generated servlets anymore, instead it is a variable in doPost method

---
U trunk/src-wad/src/org/openbravo/wad/javasource.javaxml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12368&sc=1 [^]
(0012730)
svnbot   
2009-01-28 14:28   
Repository: openbravo
Revision: 12374
Author: alostale
Date: 2009-01-28 14:28:51 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Moved members for shorcuts control

---
U trunk/src-wad/src/org/openbravo/wad/javasource.javaxml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12374&sc=1 [^]
(0012737)
svnbot   
2009-01-28 15:50   
Repository: openbravo
Revision: 12383
Author: alostale
Date: 2009-01-28 15:49:58 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Process in action button responser generated java

---
U trunk/src-wad/src/org/openbravo/wad/ActionButtonJava_Responser.javaxml
U trunk/src-wad/src/org/openbravo/wad/ActionButton_Responser.javaxml
---

https://dev.openbravo.com/websvn/openbravo/?rev=12383&sc=1 [^]
(0012739)
svnbot   
2009-01-28 16:17   
Repository: openbravo
Revision: 12387
Author: alostale
Date: 2009-01-28 16:17:44 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

In class CreateRegFactAcct synchronized methods to avoid problems with the following memembers:

ExpenseAmtCr
RevenueAmtDr
RevenueAmtCr
ExpenseAmtDr

---
U trunk/src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12387&sc=1 [^]
(0012740)
svnbot   
2009-01-28 16:27   
Repository: openbravo
Revision: 12389
Author: alostale
Date: 2009-01-28 16:27:52 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions


Removed global members in Invoice Vendor Multiline

---
U trunk/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12389&sc=1 [^]
(0012742)
svnbot   
2009-01-28 16:32   
Repository: openbravo
Revision: 12390
Author: alostale
Date: 2009-01-28 16:32:46 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions


Removed global members in Invoice Vendor Multiline Lines

---
U trunk/src/org/openbravo/erpCommon/ad_forms/InvoiceVendorMultiline_Lines.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12390&sc=1 [^]
(0012745)
svnbot   
2009-01-28 16:39   
Repository: openbravo
Revision: 12393
Author: alostale
Date: 2009-01-28 16:39:00 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed global member isRTL in Role class

---
U trunk/src/org/openbravo/erpCommon/ad_forms/Role.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12393&sc=1 [^]
(0012749)
svnbot   
2009-01-28 16:44   
Repository: openbravo
Revision: 12395
Author: alostale
Date: 2009-01-28 16:44:40 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Centrally maintained for Translate class

---
U trunk/src/org/openbravo/erpCommon/ad_forms/Translation.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12395&sc=1 [^]
(0012759)
svnbot   
2009-01-28 17:02   
Repository: openbravo
Revision: 12399
Author: alostale
Date: 2009-01-28 17:02:34 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed global members in Send Mail Text

---
U trunk/src/org/openbravo/erpCommon/ad_process/SendMailText.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12399&sc=1 [^]
(0012767)
svnbot   
2009-01-28 18:14   
Repository: openbravo
Revision: 12411
Author: alostale
Date: 2009-01-28 18:14:47 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Synchronized process method

---
U trunk/src/org/openbravo/erpCommon/ad_forms/InitialOrgSetup.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12411&sc=1 [^]
(0012768)
svnbot   
2009-01-28 18:26   
Repository: openbravo
Revision: 12413
Author: alostale
Date: 2009-01-28 18:26:12 +0100 (Wed, 28 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

---
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12413&sc=1 [^]
(0012794)
svnbot   
2009-01-29 11:37   
Repository: openbravo
Revision: 12446
Author: alostale
Date: 2009-01-29 11:37:25 +0100 (Thu, 29 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

In Out Trace

---
U trunk/src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12446&sc=1 [^]
(0012795)
svnbot   
2009-01-29 11:40   
Repository: openbravo
Revision: 12448
Author: alostale
Date: 2009-01-29 11:40:52 +0100 (Thu, 29 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed global members from PrintJR class

---
U trunk/src/org/openbravo/erpCommon/utility/PrintJR.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12448&sc=1 [^]
(0012806)
svnbot   
2009-01-29 12:37   
Repository: openbravo
Revision: 12463
Author: alostale
Date: 2009-01-29 12:37:26 +0100 (Thu, 29 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed global members fro Print Controller

---
U trunk/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12463&sc=1 [^]
(0012809)
svnbot   
2009-01-29 12:53   
Repository: openbravo
Revision: 12466
Author: alostale
Date: 2009-01-29 12:53:22 +0100 (Thu, 29 Jan 2009)

Related to issue 0006283: Openbravo servlet classes have (static) members which are changed by post/get actions

Removed global members fro Print Controller

---
U trunk/src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12466&sc=1 [^]