Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0006038Openbravo ERP08. Project and service managementpublic2008-11-18 19:552009-02-18 15:17
plujan 
alostale 
urgentmajorhave not tried
closedfixed 
20
pi 
pi 
Core
No
0006038: [QA-alpha-r1] Change Status button on projects has no label
I create a new Multiphase project. The label for the button used to change project status has no label.
Go to Project and Service > Transactions > Multiphase Project
Click on new. See the button at the bottom of the page (see attach)
No tags attached.
jpg R250alpha_BUG_NoLabelButton.JPG (93,276) 2008-11-18 19:55
https://issues.openbravo.com/file_download.php?file_id=437&type=bug
jpg
Issue History
2008-11-18 19:55plujanNew Issue
2008-11-18 19:55plujanAssigned To => rafaroda
2008-11-18 19:55plujansf_bug_id0 => 2310712
2008-11-18 19:55plujanFile Added: R250alpha_BUG_NoLabelButton.JPG
2008-11-18 19:55plujanRegression testing => No
2008-11-18 19:57plujanStatusnew => scheduled
2008-11-18 19:57plujanfix_in_branch => trunk
2008-12-23 12:58PavelPonomarevAssigned Torafaroda => Hennadzi
2009-01-08 14:29PavelPonomarevNote Added: 0011986
2009-01-08 14:29PavelPonomarevAssigned ToHennadzi => PavelPonomarev
2009-01-08 14:30PavelPonomarevAssigned ToPavelPonomarev => rafaroda
2009-01-08 14:30PavelPonomarevfix_in_branchtrunk =>
2009-01-10 18:00rafarodaAssigned Torafaroda => alostale
2009-01-10 18:02rafarodaNote Added: 0012094
2009-01-27 15:44HennadziIssue Monitored: Hennadzi
2009-02-04 16:53svnbotCheckin
2009-02-04 16:53svnbotNote Added: 0013149
2009-02-04 16:53svnbotStatusscheduled => resolved
2009-02-04 16:53svnbotResolutionopen => fixed
2009-02-04 16:53svnbotsvn_revision => 12787
2009-02-06 09:07HennadziIssue End Monitor: Hennadzi
2009-02-18 15:17sureshbabuStatusresolved => closed
2009-02-18 15:17sureshbabuNote Added: 0013667
2009-02-18 15:17sureshbabuFixed in Version => trunk

Notes
(0011986)
PavelPonomarev   
2009-01-08 14:29   
WAD issue, reassigned from Hennadzi to Rafa.
(0012094)
rafaroda   
2009-01-10 18:02   
Info provided by Paul:

This problem is closely related with the unique logic that is used for field "changeprojectstatus"of the WAD process. Due to that, there is a lack of some code in class MultiphaseProject.java (same as for "ServiceProject.java") to show that label.
For example, the following code could be used in my opinion:
xmlDocument.setParameter("ChangeProjectStatus_BTNname", Utility.getButtonName(this, vars, "803670", "ChangeProjectStatus_linkBTN", usedButtonShortCuts, reservedButtonShortCuts));
some where in method printPageEdit().
Therefore, a parameter should appear in the "MultiphaseProject_Edition.xml" file.

This, in turn, leads us to the class WADButton.java or rather to an adjustment of methods "WADButton.toJava()" and "WADButton.toXml()".

To save stability of code and fix this bug, my proposition is to add some code for this condition :
getData("ColumnName").equalsIgnoreCase("ChangeProjectStatus")
For method WADButton.toJava() the additional code could be:

        if (getData("IsDisplayed").equals("Y") && getData("ColumnName").equalsIgnoreCase("ChangeProjectStatus"))
                    return "xmlDocument.setParameter(\""
                    + getData("ColumnName")
                    + "_BTNname\", Utility.getButtonName(this, vars, \""
                    + getData("AD_Field_ID")
                    + "\", \""
                    + getData("ColumnName")
                    + "_linkBTN\", usedButtonShortCuts, reservedButtonShortCuts));";

For the method WADButton.toXml():

        if (getData("IsDisplayed").equals("Y")
                        && getData("ColumnName").equalsIgnoreCase(
                            "ChangeProjectStatus")) {
                        text.append("<PARAMETER id=\"").append(getData("ColumnName"))
                                .append("_BTNname\" name=\"").append(
                                        getData("ColumnName")).append(
                                        "_BTNname\" default=\"\"/>\n");
                    }
(0013149)
svnbot   
2009-02-04 16:53   
Repository: openbravo
Revision: 12787
Author: alostale
Date: 2009-02-04 16:53:56 +0100 (Wed, 04 Feb 2009)

fixed bug 0006038: [QA-alpha-r1] Change Status button on projects has no label

---
U trunk/src-wad/lib/openbravo-wad.jar
U trunk/src-wad/src/org/openbravo/wad/controls/WADButton.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=12787&sc=1 [^]
(0013667)
sureshbabu   
2009-02-18 15:17   
Retested in context 79.125.56.185/openbravotrunk