Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0005867Openbravo ERP01. General setuppublic2008-11-06 19:212009-04-21 11:06
vmromanos 
vmromanos 
highmajorhave not tried
closedfixed 
20Ubuntu 8.04
 
pi 
Core
No
0005867: Organization's comboboxes must only show ready organizations
The organization's comboboxes of the applications must show only ready organizations, but they currently don't do it.
multi-org
Issue History
2008-11-06 19:21vmromanosNew Issue
2008-11-06 19:21vmromanosAssigned To => rafaroda
2008-11-06 19:21vmromanossf_bug_id0 => 2230573
2008-11-06 19:21vmromanosRegression testing => No
2008-11-06 19:24rafarodaTag Attached: multi-org
2008-11-06 19:25rafarodaAssigned Torafaroda => vmromanos
2008-11-09 20:06psarobeNote Added: 0010102
2008-11-09 20:06psarobeStatusnew => feedback
2008-11-12 11:01vmromanosNote Added: 0010191
2008-11-20 10:27rafarodaNote Added: 0010429
2008-11-20 13:07vmromanosNote Added: 0010442
2008-11-20 13:07vmromanosStatusfeedback => scheduled
2008-11-20 13:07vmromanosfix_in_branch => trunk
2008-11-24 18:15svnbotCheckin
2008-11-24 18:15svnbotNote Added: 0010584
2008-11-24 18:15svnbotStatusscheduled => resolved
2008-11-24 18:15svnbotResolutionopen => fixed
2008-11-24 18:15svnbotsvn_revision => 10488
2008-11-25 10:52psarobeNote Added: 0010607
2008-12-03 18:06psarobeStatusresolved => new
2008-12-03 18:06psarobeResolutionfixed => open
2008-12-03 18:06psarobeNote Added: 0010946
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-09 17:40vmromanosNote Added: 0011084
2008-12-09 17:40vmromanosStatusnew => feedback
2008-12-11 19:15vmromanosStatusfeedback => scheduled
2008-12-11 19:20vmromanosStatusscheduled => resolved
2008-12-11 19:20vmromanosFixed in Version => trunk
2008-12-11 19:20vmromanossvn_revision10488 => 11098
2008-12-11 19:20vmromanosResolutionopen => fixed
2008-12-11 19:20vmromanosNote Added: 0011207
2009-04-21 11:06psarobeStatusresolved => closed

Notes
(0010102)
psarobe   
2008-11-09 20:06   
Hi Victor,

It is mandatory to write a good description and the steps to reproduce the bug to allow the QA team to understand the bug.

In the same way please write the steps and the issues to verify when the bug is fixed so QA team can check if the fixed is correct
(0010191)
vmromanos   
2008-11-12 11:01   
Due to the new multi-org project, a new flag called 'IsReady' has been added to the organization table. This flag allows us to implement some business rules into the ERP related with the organization's tree.

From a user perspective, this flag is very similar to an 'IsActive' flag; thus every combobox into the application must display only organizations which are 'Ready'.

The application currently does not take into account this flag, so we must change every application's combobox to add/modify the validation rule in order to only display 'Ready' organizations.
(0010429)
rafaroda   
2008-11-20 10:27   
Please specify the steps in the application where to configure this and then to which window we should go to test if it works
(0010442)
vmromanos   
2008-11-20 13:07   
After talking to ici and pju the fix for this bug has been changed.

The affected organization's comboboxes are only the ones inside a "Transaction" window. The transaction windows are defined into the Application Dictionary (field Window Type).

The application will apply this validation rule automatically, so it is not necessary to associate manually the validation rule in every organization's combobox of the transaction windows.

In order to do that, it will be necessary to adapt the WAD.
(0010584)
svnbot   
2008-11-24 18:15   
Repository: openbravo
Revision: 10488
Author: vmromanos
Date: 2008-11-24 18:14:10 +0100 (Mon, 24 Nov 2008)

Fixed bug 0005867:
- Removed "AD_Org is transactions allowed" validation rule of the transaction's windows.
- Modified the WAD to validate automatically the organization's combobox of every transactional window. Note: the new DataAccess Layer has been used for this check.

---
U trunk/src/org/openbravo/base/secureApp/OrgTree.java
U trunk/src/org/openbravo/base/secureApp/OrgTreeNode.java
U trunk/src/org/openbravo/erpCommon/utility/Utility.java
U trunk/src/org/openbravo/erpCommon/utility/WindowTree_data.xsql
U trunk/src-db/database/sourcedata/AD_COLUMN.xml
U trunk/src-db/database/sourcedata/AD_VAL_RULE.xml
---

https://dev.openbravo.com/websvn/openbravo/?rev=10488&sc=1 [^]
(0010607)
psarobe   
2008-11-25 10:52   
The transactional windows are for example Purchase invoice, purchase order, sales invoice, settlement.

So the organization must be configured as ready and the flag transactions allowed mark (type organization)
(0010946)
psarobe   
2008-12-03 18:06   
I have created a new organization. Put is as child of Main. Generic. Set as ready and after all I cannot see in the organization in any transactional window
(0011084)
vmromanos   
2008-12-09 17:40   
To fix this bug we are using the new Data Access Layer and I think the problem is on the Hibernate's cache. If you restart Tomcat you will see the organizations and you will be able to check the bug is already fixed.

To solve this cache issue we have to find the way to force Hibernate not to use the internal cache with organizations. I am talking to mtaal to find the perfect solution for that. At the moment we have three possibilities to fix it but we are discussing about which one is the perfect one.
(0011207)
vmromanos   
2008-12-11 19:20   
After disabling the Hibernate's second-level cache, it is not necessary to restart Tomcat anymore to see the recently created organizations.