0005849: General Ledger: Accumulated amounts when using more than a range

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0005849

Openbravo ERP

09. Financial management

public

2008-11-06 12:15

2008-12-09 11:14

Reporter

galderromo

Assigned To

dalsasua

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Gentoo 2.6.24

Product Version

2.35MP5

Target Version

Fixed in Version

2.35MP10

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0005849: General Ledger: Accumulated amounts when using more than a range

Description

When having more than 500 records, the report shows more than a view.
The break between ranges can happend during the same accounting date. On this cases, the new range's amounts are not proparly calculated.

Steps To Reproduce

Supposing you have this records on facct_acct:
Date: 11-08-08 fact_acct_id:1000 amount:1000
Date: 11-08-08 fact_acct_id:1001 amount:800
---------------- Range break ----------------
Date: 11:08-08 fact_acct_id:1002 amount:350
Date: 12-08-08 fact_acct_id:1003 amount:100

When the new range is loaded, you previous amount will be 2150 instead of 1800.

Proposed Solution

Change selectPrevious method on ReportGeneralLedger_data.xsql with:
  <SqlMethod name="selectPrevious" type="preparedStatement" return="multiple">
      <SqlMethodComment></SqlMethodComment>
      <Sql><![CDATA[
      SELECT COALESCE(SUM(AMTACCTDR),0) AS TOTALDR, COALESCE(SUM(AMTACCTCR),0) AS TOTALCR,
      COALESCE(SUM(AMTACCTDR-AMTACCTCR),0) AS TOTAL
      FROM FACT_ACCT
      WHERE 1=1
      AND FACT_ACCT.ACCOUNT_ID = ?
      AND (DATEACCT < ? OR (DATEACCT= ? AND FACT_ACCT_ID < ? ))
      AND FACT_ACCT.AD_ORG_ID IN ('1')
      AND 2=2
      ]]></Sql>
      <Parameter name="bpartner" optional="true" after="1=1"><![CDATA[ AND FACT_ACCT.C_BPARTNER_ID = ? ]]></Parameter>
      <Parameter name="project" optional="true" after="1=1"><![CDATA[ AND FACT_ACCT.C_PROJECT_ID = ? ]]></Parameter>
      <Parameter name="acctschema" optional="true" after="1=1"><![CDATA[ and fact_acct.C_ACCTSCHEMA_ID = ? ]]></Parameter>
      <Parameter name="account"/>
      <Parameter name="date"/>
      <Parameter name="date"/>
      <Parameter name="factacct"/>
      <Parameter name="orgs" type="replace" optional="true" after="AND FACT_ACCT.AD_ORG_ID IN (" text="'1'"/>
      <Parameter name="productId" optional="true" type="argument" after="2=2"><![CDATA[ AND FACT_ACCT.M_PRODUCT_ID IN ]]></Parameter>
      <Parameter name="user1" optional="true" after="2=2"><![CDATA[ AND fact_acct.USER1_ID = ? ]]></Parameter>
      <Parameter name="user2" optional="true" after="2=2"><![CDATA[ AND fact_acct.USER2_ID = ? ]]></Parameter>
   </SqlMethod>

Additional Information