Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0058279POS2POSpublic2025-03-18 18:162025-03-25 13:54
Reporterfofarril 
Assigned Tofofarril 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0058279: Error when making a verified return of a product at price = 0€
DescriptionWhen doing a verified return of a product at price = 0€, the following error message appear 'Cannot convert undefined or null to object'.
Steps To ReproduceIn backoffice
-In 'Vall Blanca Store' organization the property "Rules for Returns" needs to be set to "One Original Order in one single return" and the property "Rules for Sales and Return lines" needs to be set to "Allow to mix lines only if the total amount is 0" or "Not allow to mix lines".
-In Channel Touchpoint -> Payment Type -> Payment Method set property 'Allowed PMs for Refund' different of 'All' and set some items of 'PM for Refund' tab.
-Configure a product with price equal 0€.

POS2
-In POS, make a sale of a product with price = 0€ or apply a 100% discount to a product with a price greater than 0€
-Go to Orders and make a verified return of the product with price = 0€


Current behavior : The following error message appears and it is not possible to make the return

Expected results : the return should be possible even price of product = 0€
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005828025Q1.1 closed fofarril Error when making a verified return of a product at price = 0€ 
depends on backport 005828124Q4.2 closed fofarril Error when making a verified return of a product at price = 0€ 
Attached Filespng Error.png (92,810) 2025-03-18 18:16
https://issues.openbravo.com/file_download.php?file_id=21064&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2025-03-18 18:16fofarrilNew Issue
2025-03-18 18:16fofarrilAssigned To => Retail
2025-03-18 18:16fofarrilFile Added: Error.png
2025-03-18 18:16fofarrilOBNetwork customer => No
2025-03-18 18:16fofarrilTriggers an Emergency Pack => No
2025-03-18 18:16fofarrilAssigned ToRetail => fofarril
2025-03-18 18:17fofarrilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=29384#r29384
2025-03-18 18:19fofarrilStatusnew => scheduled
2025-03-18 18:21fofarrilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=29385#r29385
2025-03-19 14:27hgbotMerge Request Status => open
2025-03-19 14:27hgbotNote Added: 0176987
2025-03-19 14:30hgbotNote Added: 0176988
2025-03-24 13:14hgbotMerge Request Statusopen => approved
2025-03-25 13:54hgbotNote Added: 0177229
2025-03-25 13:54hgbotResolutionopen => fixed
2025-03-25 13:54hgbotStatusscheduled => closed
2025-03-25 13:54hgbotFixed in Version => RR25Q2
2025-03-25 13:54hgbotNote Added: 0177230
2025-03-25 13:54hgbotNote Added: 0177231
2025-03-25 13:54hgbotNote Added: 0177232

Notes
(0176987)
hgbot   
2025-03-19 14:27   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1979 [^]
(0176988)
hgbot   
2025-03-19 14:30   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/74 [^]
(0177229)
hgbot   
2025-03-25 13:54   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1979 [^]
(0177230)
hgbot   
2025-03-25 13:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: fa4472657e434317a92650a3510ad23113b53e4d
Author: Francisco Javier Deler O'Farril <francisco.ofarril@doceleguas.com>
Date: 25-03-2025 13:54:26
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/fa4472657e434317a92650a3510ad23113b53e4d [^]

Fixes ISSUE-58279: Error when making a verified return of a product at price = 0€

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
---
(0177231)
hgbot   
2025-03-25 13:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 5833384af596e2a20958b63eac8be9a44d49442c
Author: Francisco Javier Deler O'Farril <francisco.ofarril@doceleguas.com>
Date: 25-03-2025 13:54:31
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/5833384af596e2a20958b63eac8be9a44d49442c [^]

Fixes ISSUE-58279: Error when making a verified return of a product at price = 0€

---
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/Validations.js
---
(0177232)
hgbot   
2025-03-25 13:54   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/74 [^]