0058265: Install from obx file does not handle AD_MODULE_MERGE entries

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0058265

Openbravo ERP

A. Platform

public

2025-03-17 20:28

2025-03-24 14:55

Reporter

shuehner

Assigned To

shuehner

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

PR25Q2

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0058265: Install from obx file does not handle AD_MODULE_MERGE entries

Description

Installing a new obx version from a file does not detect / handle ad_module_merge entries declared in the new version.

That means that the merged module does not get auto-uninstalled as it should be.

As a consequence the rest of the process has both the merge copy + the original module present and will fail with various errors

Rebuilding system will have lots of duplicate errors

Trying to install 2nd module from obx file will have in ‘verifyLocalChanges’ as that reads model from xml file which fails with seeing i.e. EM* columns twice

It looks like that error is present from day1 on adding support code for ad_module_merge.

https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/6a41faac00f680e468ff0b559605ac49ae9e0ef9#6fe7d4ebb49405382b6092f13a4a78c1b3cebab0_1247_1318 [^]

https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/d7658bec195f8e4e5af0764eaa63c490a61c3ebe#6fe7d4ebb49405382b6092f13a4a78c1b3cebab0_1319_1320 [^]

Problem seems to be the extra / in front of src-db.

When parsing file for obx of core/ad_module_id=0 as created by script packagedistribution/packager/obx file the AD_MODULE_MERGE.xml file inside the ZipInputStream does not match with that leading /

Steps To Reproduce

Have context with backoffice only (git master) + org.openbravo.retail.config
=> Pre org.openbravo.retail.config merge into core

Have local obx file ready with:
- higher ad_module.version
- ad_module_merge having and entry to declare merge of org.openbravo.retail.config

Install this obx file from local.

Expected:
- Message telling about uninstalled org.openbravo.retail.config module as it has been merged. After confirming this the module folder should be deleted
Actual:
- This declared is not detected and obx file is installed without deleting the org.openbravo.retail.config module folder

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0058283	PR25Q1.1	closed	shuehner	Install from obx file does not handle AD_MODULE_MERGE entries
depends on	backport	0058284	PR24Q4.2	closed	shuehner	Install from obx file does not handle AD_MODULE_MERGE entries