Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0058162Retail ModulesCopy Retail Storepublic2025-03-06 12:402025-03-21 09:56
ReporterXABIER_AGUADO 
Assigned ToRajesh_18 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0058162: Copy Retail Store doesnt copy all parameteres as expected.
DescriptionWhen doing CRS, the new created store doesnt have the right values in some windows / fields.
Steps To ReproduceOn livebuilds, do a CRS of Store 'Vall Blanca Store' and create a new store with name 'T000 - TEMPLATE' and Search Key 'T000'
Once CRS is done, check the following parameters:

Business Partner --> Name is 'T000 - VBS Customer' when it should be T000 - TEMPLATE
Also, business partners should be created at the same level as the one in the original Store. I.E: Original Store has a Business Partner defined at legal entity, new BP should be created at legal entity too instead of at store level

Channel TouchPoint --> Original Vall Blanca TouchPoint has Search Key 'VBS2-1' and name 'VBS2 POS Terminal'. Copied TouchPoint has Search key 'T0002-1' (OK) and name 'T0002-1' (KO). It should be 'T0002 POS Terminal'

Channel TouchPoint --> Prefixes arent being copied. When creating prefixes for the new touchpoint CRS should:
If no prefix exists leave it empty.
If prefix exist, it should keep the same format as in the original store only updating the search key.
I.E:
Original Store Searcxh Key = VBS2-1
Original Store Simplified Invoice Sequence Prefix = VBS2-1SIMPINV
T000 Store Search Key = T0002-1
Simplified Invoice Sequence Prefix should be ---> T0002-1SIMPINV



Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0057842 closed Rajesh_18 Openbravo ERP Copy Terminal doesnt Copy the touchpoint´s prefixes and the ones being copied are KO. 
Attached Filespng CRS_1.png (91,504) 2025-03-06 12:40
https://issues.openbravo.com/file_download.php?file_id=21013&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2025-03-06 12:40XABIER_AGUADONew Issue
2025-03-06 12:40XABIER_AGUADOAssigned To => Retail
2025-03-06 12:40XABIER_AGUADOFile Added: CRS_1.png
2025-03-06 12:40XABIER_AGUADOOBNetwork customer => Gold
2025-03-06 12:40XABIER_AGUADOTriggers an Emergency Pack => No
2025-03-07 11:22XABIER_AGUADOSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=29322#r29322
2025-03-10 07:31guillermogilSeveritymajor => minor
2025-03-10 07:36guillermogilRelationship addedrelated to 0057842
2025-03-10 10:34migueldejuanaStatusnew => scheduled
2025-03-10 10:34migueldejuanaAssigned ToRetail => Rajesh_18
2025-03-12 13:10hgbotMerge Request Status => open
2025-03-12 13:10hgbotNote Added: 0176720
2025-03-12 13:11hgbotNote Added: 0176721
2025-03-21 09:48hgbotMerge Request Statusopen => approved
2025-03-21 09:49hgbotResolutionopen => fixed
2025-03-21 09:49hgbotStatusscheduled => closed
2025-03-21 09:49hgbotNote Added: 0177089
2025-03-21 09:49hgbotNote Added: 0177090
2025-03-21 09:49hgbotNote Added: 0177091
2025-03-21 09:49hgbotNote Added: 0177092
2025-03-21 09:49hgbotNote Added: 0177093
2025-03-21 09:56marvintmNote Added: 0177102

Notes
(0176720)
hgbot   
2025-03-12 13:10   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/96 [^]
(0176721)
hgbot   
2025-03-12 13:11   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore.giftcards/-/merge_requests/8 [^]
(0177089)
hgbot   
2025-03-21 09:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 0d238ed05e1793327823cc0a11b48fcb0fcf5647
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 21-03-2025 12:49:00
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/0d238ed05e1793327823cc0a11b48fcb0fcf5647 [^]

Fixed ISSUE-58162: Refactored copying of prefix and anonymous bp name and organization
* If the orginal store has termialSearchKey+Sequence prefix then it is replaced with newTerminalSearchKey+Sequence prefix
* BP name is same as new organization name
* If original BP organization is present in legal entity of new organization then the new BP is created in the orginal BP organization

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/DefaultPropertiesHandler.java
---
(0177090)
hgbot   
2025-03-21 09:49   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 90992cada4681032875123ac204e6cd30ee11ee5
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 21-03-2025 12:56:29
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/90992cada4681032875123ac204e6cd30ee11ee5 [^]

Related to ISSUE-58162: Reverted the changes of anonymous BP searchkey, name and organization

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
---
(0177091)
hgbot   
2025-03-21 09:49   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/96 [^]
(0177092)
hgbot   
2025-03-21 09:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore.giftcards [^]
Changeset: b6a91664bcdd2d4764421e4b1bb9b3711edd7b75
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 12-03-2025 17:31:14
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore.giftcards/-/commit/b6a91664bcdd2d4764421e4b1bb9b3711edd7b75 [^]

Fixed ISSUE-58162: Original application has giftcard search key then it is replaced with new application search key

---
M src/org/openbravo/retail/copystore/giftcards/DefaultGiftcardsPropertiesHandler.java
---
(0177093)
hgbot   
2025-03-21 09:49   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.copystore.giftcards/-/merge_requests/8 [^]
(0177102)
marvintm   
2025-03-21 09:56   
We have implemented several changes proposed in this issue, but not all of them. After these fixes, now:
- Prefixes for several sequences like cash up document number, of gift cards documents now work as proposed
- Terminal name will also work as expected, the search key of the original organization will be replaced by the search key of the new organization
- We have also removed some redundant code in the anonymous customer initialization.

However, the following changes have not been implemented:
- Customer name currently follows the rules originally defined, implemented as part of this issue: https://issues.openbravo.com/view.php?id=50680 [^] Specifically, the name of the original anonymous customer is picked, a "-" is searched, and if it exists, the left side is replaced by the search key of the new organization. If a new rule must be implemented, then it should be discussed first with Product Management
- The organization in which the customer is created has also not been changed. Currently, the rule that is followed is: if the organization belongs to a cross-store structure, then the new anonymous customer is created at the root of the structure (to enable cross-store operations). Otherwise, it is created at store level. If this rule must be changed, then it should be discussed first with Product Management.