Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0058004POS2Corepublic2025-02-17 13:382025-02-23 18:44
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2025-02-13
Regression introduced in release24Q4
Regression introduced by commithttps://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/9cf77cc5f0dbc50fb83ffdd920e42a4820b58441 [^]
Triggers an Emergency PackNo
Summary0058004: Login blocked because of an error related to an inconsistent state
DescriptionLogin fails with an error related to inconsistent state. This error does not happen in livebuilds, but it does happen in some specific clients. It seems to be due to some cashup state already being available, but not in its entirety.
Steps To ReproduceNot reproducible in livebuilds, and not very clear steps to reproduce.

1. Initialize an environment
2. Try to login in WebPOS2

In some occasions the state includes ticket + an existing empty cashup, in that case, the error is thrown. The error was attached as part of this issue.
Proposed SolutionProperly handle checking Ticket.id and Cashup.id, instead of the objects, which usually exist but are empty.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005800525Q1 closed cberner Login blocked because of an error related to an inconsistent state 
depends on backport 005800624Q4.2 closed cberner Login blocked because of an error related to an inconsistent state 
caused by feature request 0056377 closed AugustoMauch Management of inconsistent application state should be properly addressed in core2 applications 
Attached Filesjpeg error.jpeg (24,379) 2025-02-17 13:45
https://issues.openbravo.com/file_download.php?file_id=20920&type=bug
jpeg
Issue History
Date ModifiedUsernameFieldChange
2025-02-17 13:38cbernerNew Issue
2025-02-17 13:38cbernerAssigned To => cberner
2025-02-17 13:38cbernerOBNetwork customer => No
2025-02-17 13:38cbernerTriggers an Emergency Pack => No
2025-02-17 13:38cbernerStatusnew => acknowledged
2025-02-17 13:38cbernerStatusacknowledged => scheduled
2025-02-17 13:41hgbotMerge Request Status => open
2025-02-17 13:41hgbotNote Added: 0175771
2025-02-17 13:45cbernerFile Added: error.jpeg
2025-02-17 14:00cbernerRelationship addedcaused by 0056377
2025-02-17 14:01hgbotMerge Request Statusopen => approved
2025-02-17 14:44hgbotResolutionopen => fixed
2025-02-17 14:44hgbotStatusscheduled => closed
2025-02-17 14:44hgbotNote Added: 0175774
2025-02-17 14:44hgbotFixed in Version => 25Q2
2025-02-17 14:44hgbotNote Added: 0175775
2025-02-17 16:22cbernerRegression level => Production - Confirmed Stable
2025-02-17 16:22cbernerRegression date => 2025-02-13
2025-02-17 16:22cbernerRegression introduced in release => 24Q4
2025-02-17 16:22cbernerRegression introduced by commit => https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/9cf77cc5f0dbc50fb83ffdd920e42a4820b58441 [^]
2025-02-23 18:44hgbotFixed in Version25Q2 => 25Q1
2025-02-23 18:44hgbotNote Added: 0176040

Notes
(0175771)
hgbot   
2025-02-17 13:41   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1776 [^]
(0175774)
hgbot   
2025-02-17 14:44   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1776 [^]
(0175775)
hgbot   
2025-02-17 14:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 221420e2082180e76ed41181a1654d14a9420d38
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 17-02-2025 13:39:04
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/221420e2082180e76ed41181a1654d14a9420d38 [^]

Fixes ISSUE-58004: Login blocked because of an error related to an inconsistent state

The checkStateValidity function was not taking into account empty ticket
object or a missing cashup id.

---
M web-jspack/org.openbravo.core2/src/authentication/loginInitActions.js
---
(0176040)
hgbot   
2025-02-23 18:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 92e0ba54f465b627a1acb80b211bbdb682be2bec
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 23-02-2025 18:18:56
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/92e0ba54f465b627a1acb80b211bbdb682be2bec [^]

Fixes ISSUE-57963: Global mitigation of state related problems

On each login, the local state is checked, and if it is determined that the state is not valid, it will
be reset.

This code references non-core2 concepts (Ticket, Cashup). It was done intentionally, this code should be
temporary and be removed once we find out the root cause of the back-to-the-past state problems. Instead
of implementing some infra to be able to add the relevant portion of the state to the request payload, it
is hardcoded for now

[stateMitigation] Adds missing adminMode when checking the state validity

[stateMitigation] Properly fail when in offline mode the stateValidity request

[stateMitigation] Use OB.App.reload api instead of manual location reload

Related to ISSUE-56377: Fixes test

Fixes ISSUE-58004: Login blocked because of an error related to an inconsistent state

The checkStateValidity function was not taking into account empty ticket
object or a missing cashup id.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.core2/src/authentication/loginInitActions.js
---