Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057988ModulesEvent for Paymentspublic2025-02-14 07:442025-02-18 15:14
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0057988: Approvals for Payment Amount Validation are not persisted
DescriptionApprovals for Payment Amount Validation are not persisted
Steps To Reproduce1) Create an event subscription for the "Payment Validation Management" event
2) Configure a payment method of the Touchpoint Type with the "Execute Payment Validation" flag enabled
3) Configure a role so approval is required for the "Payment Amount Validation Approval" user action
4) Login in the POS with a termina of the type configured in step 2) and a user with the role configured in step 3
5) Add a line to the ticket and pay it using the payment method configured in step 2). Approval should be requested.
6) After approving, proceed with paying the ticket
7) Go to the Sales Order window in the backoffice and check the synchronized order. Note that no approval information has been persisted in the "Approval History" subtab
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-02-14 07:44caristuNew Issue
2025-02-14 07:44caristuAssigned To => caristu
2025-02-14 08:19hgbotNote Added: 0175641
2025-02-14 12:23hgbotNote Added: 0175652
2025-02-14 12:58hgbotNote Added: 0175654
2025-02-17 11:45hgbotNote Added: 0175762
2025-02-18 15:12hgbotNote Added: 0175823
2025-02-18 15:12hgbotNote Added: 0175824
2025-02-18 15:13hgbotNote Added: 0175825
2025-02-18 15:13hgbotNote Added: 0175826
2025-02-18 15:14hgbotNote Added: 0175827
2025-02-18 15:14hgbotNote Added: 0175828
2025-02-18 15:14hgbotResolutionopen => fixed
2025-02-18 15:14hgbotStatusnew => closed
2025-02-18 15:14hgbotNote Added: 0175829
2025-02-18 15:14hgbotNote Added: 0175830
2025-02-18 15:14hgbotNote Added: 0175831

Notes
(0175641)
hgbot   
2025-02-14 08:19   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/106 [^]
(0175652)
hgbot   
2025-02-14 12:23   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/52 [^]
(0175654)
hgbot   
2025-02-14 12:58   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1770 [^]
(0175762)
hgbot   
2025-02-17 11:45   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.ssms/-/merge_requests/421 [^]
(0175823)
hgbot   
2025-02-18 15:12   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1770 [^]
(0175824)
hgbot   
2025-02-18 15:12   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: e2e8beb486e19fd2d663f442fa99d7bdc850e414
Author: Carlos Aristu <c.aristu@orisha.com>
Date: 18-02-2025 14:12:13
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/e2e8beb486e19fd2d663f442fa99d7bdc850e414 [^]

related to BUG-57988: User Action infrastructure adaptations

---
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/GetUserAction.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
---
(0175825)
hgbot   
2025-02-18 15:13   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.ssms/-/merge_requests/421 [^]
(0175826)
hgbot   
2025-02-18 15:13   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.ssms [^]
Changeset: dbbf5d491131d9f7832d513d2980ecc7b154c121
Author: Carlos Aristu <c.aristu@orisha.com>
Date: 17-02-2025 10:46:55
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.ssms/-/commit/dbbf5d491131d9f7832d513d2980ecc7b154c121 [^]

related to BUG-57988: fix tests

---
M web-jspack/org.openbravo.ssms/src/model/box/__test__/ChangeRefInvStatus.test.js
M web-jspack/org.openbravo.ssms/src/model/distributionOrder/_test_/AssignDistributionOrder.test.js
M web-jspack/org.openbravo.ssms/src/model/distributionOrder/_test_/ConfirmDistributionOrder.test.js
---
(0175827)
hgbot   
2025-02-18 15:14   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: 62a7744d43fc85e89652cad4463ba5247f85f0ab
Author: Carlos Aristu <c.aristu@orisha.com>
Date: 18-02-2025 14:13:58
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/commit/62a7744d43fc85e89652cad4463ba5247f85f0ab [^]

related to BUG-57988: use standard infra to request the approvals

---
A web-jspack/org.openbravo.events.client/src/user-interface/user-actions/ApproveEvent.js
A web-jspack/org.openbravo.events.client/src/user-interface/user-actions/__test__/ApproveEvent.test.js
M web-jspack/org.openbravo.events.client/src/components/MessagesManager.jsx
M web-jspack/org.openbravo.events.client/src/components/__test__/MessagesManager.test.jsx
M web-jspack/org.openbravo.events.client/src/ob-init.js
---
(0175828)
hgbot   
2025-02-18 15:14   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/106 [^]
(0175829)
hgbot   
2025-02-18 15:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment [^]
Changeset: f3171b2db33dd4dde146ec2fde53c512eaa2abdb
Author: Carlos Aristu <c.aristu@orisha.com>
Date: 17-02-2025 11:22:05
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment/-/commit/f3171b2db33dd4dde146ec2fde53c512eaa2abdb [^]

fixes BUG-57988: persist payment validation approvals in the backoffice

---
A web-jspack/org.openbravo.events.payment/src/user-interface/user-actions/ValidatePayment.js
A web-jspack/org.openbravo.events.payment/src/user-interface/user-actions/__test__/ValidatePayment.test.js
M web-jspack/org.openbravo.events.payment/src/ob-init.js
---
(0175830)
hgbot   
2025-02-18 15:14   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment [^]
Changeset: d2ab1eed843aa790ca6c7521558393450e8df8a0
Author: Carlos Aristu <c.aristu@orisha.com>
Date: 18-02-2025 07:38:30
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment/-/commit/d2ab1eed843aa790ca6c7521558393450e8df8a0 [^]

related to BUG-57988: fix broken simulator

---
M web/org.openbravo.events.payment/source/paymentvalidationsimulator/SamplePaymentValidationSimulator.js
---
(0175831)
hgbot   
2025-02-18 15:14   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/52 [^]