Openbravo Issue Tracking System - POS2
View Issue Details
0057975POS2Corepublic2025-01-24 12:552025-03-20 13:57
aaroncalero 
Triage Platform Base 
highcriticalalways
closedfixed 
5
 
24Q4.124Q4.1 
approved
Gold
No
0057975: 'Application Locked' popup can be bypassed before the first login is done
Core2-based applications have a mechanism to block the page if the code detects that the same url has been opened in a different tab[1]. When that situation is detected, a popup is opened, blocking the screen and preventing further action in that tab.

That popup can fail to be opened if current tab is on the login screen, and no login has been performed yet: a js error is raised while trying to get the label to be displayed in the popup:
hook.js:608 Uncaught TypeError: Cannot read properties of undefined (reading 'language_string');



[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/user-interface/BrowserTab.js?ref_type=heads [^]
In a POS2 environment:
Copy the url of the application and close all POS tabs.
Open the first tab with the copied url and open the chrome console.
Open the second tab with the copied url.
Verify that the first tab now shows an error in the console.
Verify that it is now possible to log in from both tabs
No tags attached.
blocks defect 0057755 closed Triage Platform Base 'Application Locked' popup can be bypassed before the first login is done 
Issue History
2025-02-13 10:32AugustoMauchTypedefect => backport
2025-02-13 10:32AugustoMauchTarget Version => 24Q4.1
2025-02-26 17:01hgbotMerge Request Status => open
2025-02-26 17:01hgbotNote Added: 0176161
2025-02-26 17:01hgbotNote Added: 0176162
2025-02-26 17:02hgbotNote Added: 0176163
2025-02-26 17:02hgbotMerge Request Statusopen => approved
2025-02-26 17:03hgbotResolutionopen => fixed
2025-02-26 17:03hgbotStatusscheduled => closed
2025-02-26 17:03hgbotFixed in Version => 24Q4.1
2025-02-26 17:03hgbotNote Added: 0176164
2025-02-26 17:03hgbotNote Added: 0176165
2025-03-20 13:57marvintmSeveritymajor => critical

Notes
(0176161)
hgbot   
2025-02-26 17:01   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1795 [^]
(0176162)
hgbot   
2025-02-26 17:01   
Merge request closed: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1795 [^]
(0176163)
hgbot   
2025-02-26 17:02   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1796 [^]
(0176164)
hgbot   
2025-02-26 17:03   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 808e1f67efd1b5fa89072dac121ed46e4caea258
Author: Augusto Mauch <amauch@orisha.com>
Date: 26-02-2025 17:00:38
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/808e1f67efd1b5fa89072dac121ed46e4caea258 [^]

Fixes ISSUE-57975: Detection of duplicated tabs does not work in login screen

The problem was that there was an error when displaying a popover in the login screen,
becuase the getLabel function failed due to the terminal missing some info. Now it no
longer fails, because we only check the property of the terminal if the terminal is not null.

This was causing "back to the past" problems after the popup failed to appear, the state persistence
was disabled the same, and then if the cashier used this tab, no state changes would be persisted

[duplicated-tab] Make sure configuration dialog tab is displayed even if app was not ready

If app had not been done rendering when the other tab was opened, the configuration dialog that would block the
screen would not be displayed. Now the mechanism will detect if the application was not ready by capturing an
exception, and it will retry

---
M web-jspack/org.openbravo.core2/src/components/ConfirmationDialog/ConfirmationDialog.jsx
M web-jspack/org.openbravo.core2/src/core/user-interface/BrowserTab.js
M web-jspack/org.openbravo.core2/src/core/user-interface/View.js
M web-jspack/org.openbravo.core2/src/ob-init.js
---
(0176165)
hgbot   
2025-02-26 17:03   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1796 [^]