Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057954POS2POSpublic2025-01-31 10:162025-02-15 22:51
Reporterjinigo 
Assigned Tosreehari 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version25Q1Fixed in Version25Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057954: [25Q1] Anonymous customer should not be validated when no email is present
DescriptionWhen email validation is configured in the Openbravo CRM, the anonymous customer (VBS Customer) is marked as invalid if no email is associated with it. This is incorrect because the anonymous customer is not supposed to have an email, and therefore should not be subject to validation.
Steps To Reproduce1. Go to Backoffice
2. Go to CRM Connector Configuration
3. Select Openbravo CRM
4. In 'API Property for Customer' select 'email'
5. In Validations & Notifications set the following values:
- Validation: Informative
- Validation Type: Empty
- Show Notification Icon in Order Header: Wrong Format
6. Ensure that 'VSB Customer' has not email (Business Partner -> VBS Customer -> Contact subtab)
7. Log in to POS2
8. Click VBS Customer -> New customer
9. Complete Greetings, Name and Last Name
10. Click Save and Assign
11. Click 'Not now' in 'Incorrect Customer Data Detected'

Error icon is shown next to the customer (correct)

12. Select any product and complete a payment

Error icon is shown next to anonymous customer (incorrect)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0057815 closed Bimla_vm [25Q1] Anonymous customer should not be validated when no email is present 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-02-12 07:16sreehariTypedefect => backport
2025-02-12 07:16sreehariTarget Version => 25Q1
2025-02-12 07:17sreehariAssigned ToBimla_vm => sreehari
2025-02-12 18:20hgbotNote Added: 0175542
2025-02-12 18:21hgbotNote Added: 0175543
2025-02-12 18:22hgbotNote Added: 0175544
2025-02-15 22:51hgbotNote Added: 0175706
2025-02-15 22:51hgbotNote Added: 0175707
2025-02-15 22:51hgbotNote Added: 0175708
2025-02-15 22:51hgbotNote Added: 0175709
2025-02-15 22:51hgbotResolutionopen => fixed
2025-02-15 22:51hgbotStatusscheduled => closed
2025-02-15 22:51hgbotFixed in Version => 25Q1
2025-02-15 22:51hgbotNote Added: 0175710
2025-02-15 22:51hgbotNote Added: 0175711

Notes
(0175542)
hgbot   
2025-02-12 18:20   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3494 [^]
(0175543)
hgbot   
2025-02-12 18:21   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/828 [^]
(0175544)
hgbot   
2025-02-12 18:22   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/79 [^]
(0175706)
hgbot   
2025-02-15 22:51   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs [^]
Changeset: 836a245e2c1e732fb27ba28d837a02f772a87913
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 12-02-2025 21:14:04
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/commit/836a245e2c1e732fb27ba28d837a02f772a87913 [^]

Related ISSUE-57954: Fixed test cases

---
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButton/__test__/LoyaltyTicketBPButton.test.jsx
M web-jspack/org.openbravo.retail.loyalty.programs/src/components/LoyaltyTicketBPButtonWithDocType/__test__/LoyaltyTicketBPButtonWithDocType.test.jsx
---
(0175707)
hgbot   
2025-02-15 22:51   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.loyalty.programs/-/merge_requests/79 [^]
(0175708)
hgbot   
2025-02-15 22:51   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 2b85309c3cf05bab905f73c5b4e3bceaaf9ca8d9
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 12-02-2025 21:12:56
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/2b85309c3cf05bab905f73c5b4e3bceaaf9ca8d9 [^]

Related ISSUE-57954: Add utility function to make easier to work with anonymous customer

---
M web/org.openbravo.mobile.core/app/integration/external-business-partner/CRMConfigurationHelper.js
---
(0175709)
hgbot   
2025-02-15 22:51   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/828 [^]
(0175710)
hgbot   
2025-02-15 22:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e8ede9d2a7268024347173de9564b41600a379e5
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 12-02-2025 23:00:32
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/e8ede9d2a7268024347173de9564b41600a379e5 [^]

Fixes ISSUE-57954: Removing CRM validation for Anonymous customer

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar2/__test__/ButtonBar2.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerNotification/CustomerNotification.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/TicketBPNotifications.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPNotifications/__test__/TicketBPNotifications.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListLocalGrid/__test__/TicketListLocalGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/__test__/TicketListRemoteGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/DeleteTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/LoadLocalTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/NewTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AssignExternalBusinessPartner.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/UnassignExternalBusinessPartner.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/LoadExternalBpNotifications.js
---
(0175711)
hgbot   
2025-02-15 22:51   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3494 [^]