Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057860POS2POSpublic2025-02-04 17:552025-02-12 08:18
Reporterfrank_gonzalez 
Assigned Tofrank_gonzalez 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057860: OMPT Tax modification is sending more lines than expected
DescriptionWhen attempting a verified return with a ticket that had lines with tax modifications, in the “Return from Customer” order in the Tax tab, there are various taxes instead of just the one the one selected in the POS.
Steps To Reproduce- Create various tax modifications and assign them to the "normal" tax rate
See jira https://openbravo.atlassian.net/browse/RM-20850 [^]

- Add a product that gets the tax rate with the tax modifications
- Click on product line and add a ‘Tax Modification’ with a ‘Tax Reason’
- Complete payment and finish the sale
- Do a verified return
- Check Backoffice: ‘Sales Order’ and ‘Return from Customer’ and their subtab ‘Approval History’
- There are 2 tax modification with the same information
- Check Backoffice: ‘Return from Customer’ and its subtab ‘Tax'
- Even thought we selected one tax modification, we are getting every type of tax for ‘IVA ISENTO’
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-02-04 17:55frank_gonzalezNew Issue
2025-02-04 17:55frank_gonzalezAssigned To => frank_gonzalez
2025-02-04 17:55frank_gonzalezTriggers an Emergency Pack => No
2025-02-04 17:59hgbotNote Added: 0175111
2025-02-04 18:03hgbotNote Added: 0175113
2025-02-05 11:55hgbotNote Added: 0175156
2025-02-05 11:55hgbotResolutionopen => fixed
2025-02-05 11:55hgbotStatusnew => closed
2025-02-05 11:55hgbotFixed in Version => RR25Q2
2025-02-05 11:55hgbotNote Added: 0175157
2025-02-05 11:56hgbotNote Added: 0175158
2025-02-05 11:56hgbotFixed in VersionRR25Q2 => 25Q2
2025-02-05 11:56hgbotNote Added: 0175159
2025-02-11 16:06hgbotNote Added: 0175492
2025-02-12 08:18hgbotNote Added: 0175509
2025-02-12 08:18hgbotNote Added: 0175510

Notes
(0175111)
hgbot   
2025-02-04 17:59   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3456 [^]
(0175113)
hgbot   
2025-02-04 18:03   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1906 [^]
(0175156)
hgbot   
2025-02-05 11:55   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1906 [^]
(0175157)
hgbot   
2025-02-05 11:55   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 483b5690d4d0107302c30a2895a94e8fa2f5fece
Author: Frank González <f.gonzalez@orisha.com>
Date: 05-02-2025 10:55:56
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/483b5690d4d0107302c30a2895a94e8fa2f5fece [^]

Fixes ISSUE-57860: OMPT Tax modification is sending more lines than expected

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-rules.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0175158)
hgbot   
2025-02-05 11:56   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3456 [^]
(0175159)
hgbot   
2025-02-05 11:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a1161e2759b759de1dd455d9f6e94572db0b3e1f
Author: Frank González <f.gonzalez@orisha.com>
Date: 05-02-2025 10:56:03
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/a1161e2759b759de1dd455d9f6e94572db0b3e1f [^]

Fixes ISSUE-57860: OMPT Tax modification is sending more lines than expected

---
M web-jspack/org.openbravo.pos2/src/model/masterdata/TaxUserInputValue.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/TaxCheck.js
---
(0175492)
hgbot   
2025-02-11 16:06   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3484 [^]
(0175509)
hgbot   
2025-02-12 08:18   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3484 [^]
(0175510)
hgbot   
2025-02-12 08:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1b044d87efb25478a5d7292d8f100aaef4312d14
Author: frank.gonzalez1 <frank.gonzalez@openbravo.com>
Date: 12-02-2025 07:15:28
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/1b044d87efb25478a5d7292d8f100aaef4312d14 [^]

Fixes ISSUE-57860: OMPT Tax modification is sending more lines than expected (multiple of same tax modification applied)

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
---