Openbravo Issue Tracking System - POS2
View Issue Details
0057831POS2POSpublic2025-01-29 15:382025-02-16 09:19
jfvaringot 
ranjith_qualiantech_com 
highmajoralways
closedfixed 
5
 
25Q125Q1 
approved
OBPS
Packaging and release
2024-11-18
main
https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f83f2bd4a99014cfe9b4f8703c046f5d77817d1e [^]
No
0057831: POS2 - Return reason could not be added for unverified returns
When doing a unverified return, I can add an item without adding a return reason, while it's noticed as a mandatory data.

Reproduced on 24Q4 and 25Q1.
On POS 2 :
1. Convert an order to return
2. Add an item
3. The reason is asked, with a * symbol
4. Click on 'Cancel'

-> The item is all the same added, and the return can be done without a reason.


WARNING :
If you add items to the ticket THEN convert to order, the reason is asked. If you click on 'Cancel', the ticket is NOT convert to return.
When the return reason pop over is cancelled, the item should not be added to the return.
No tags attached.
blocks defect 0057794 closed ranjith_qualiantech_com POS2 - Return reason could not be added for unverified returns 
Issue History
2025-02-03 07:40ranjith_qualiantech_comTypedefect => backport
2025-02-03 07:40ranjith_qualiantech_comTarget Version => 25Q1
2025-02-15 18:27hgbotNote Added: 0175697
2025-02-16 09:10hgbotNote Added: 0175716
2025-02-16 09:18hgbotMerge Request Statusopen => approved
2025-02-16 09:19hgbotNote Added: 0175721
2025-02-16 09:19hgbotNote Added: 0175722
2025-02-16 09:19hgbotNote Added: 0175723
2025-02-16 09:19hgbotResolutionopen => fixed
2025-02-16 09:19hgbotStatusscheduled => closed
2025-02-16 09:19hgbotFixed in Version => 25Q1
2025-02-16 09:19hgbotNote Added: 0175724

Notes
(0175697)
hgbot   
2025-02-15 18:27   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3505 [^]
(0175716)
hgbot   
2025-02-16 09:10   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1772 [^]
(0175721)
hgbot   
2025-02-16 09:19   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: fcd3f18ba037c6d235e13191f8c2f346fc2f6be5
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 16-02-2025 13:38:24
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/fcd3f18ba037c6d235e13191f8c2f346fc2f6be5 [^]

Related to ISSUE-57831: Added payload for approvalSummaryContent in UserAction

---
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
---
(0175722)
hgbot   
2025-02-16 09:19   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1772 [^]
(0175723)
hgbot   
2025-02-16 09:19   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3505 [^]
(0175724)
hgbot   
2025-02-16 09:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 445f7b5a32f34e5676cefe3e0dac9798d1c5dac3
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 16-02-2025 08:18:56
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/445f7b5a32f34e5676cefe3e0dac9798d1c5dac3 [^]

Fixed ISSUE-57831: Validate UserInput when adding line in Blind Return
* Refactored UserInput validation with addProduct actionPreparation instead of
  UserAction AddProduct's PostHook

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnBlindTicket.js
---