Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057794POS2POSpublic2025-01-29 15:382025-02-15 10:29
Reporterjfvaringot 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression levelPackaging and release
Regression date2024-11-18
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f83f2bd4a99014cfe9b4f8703c046f5d77817d1e [^]
Triggers an Emergency PackNo
Summary0057794: POS2 - Return reason could not be added for unverified returns
DescriptionWhen doing a unverified return, I can add an item without adding a return reason, while it's noticed as a mandatory data.

Reproduced on 24Q4 and 25Q1.
Steps To ReproduceOn POS 2 :
1. Convert an order to return
2. Add an item
3. The reason is asked, with a * symbol
4. Click on 'Cancel'

-> The item is all the same added, and the return can be done without a reason.


WARNING :
If you add items to the ticket THEN convert to order, the reason is asked. If you click on 'Cancel', the ticket is NOT convert to return.
Proposed SolutionWhen the return reason pop over is cancelled, the item should not be added to the return.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005783125Q1 closed ranjith_qualiantech_com POS2 - Return reason could not be added for unverified returns 
depends on backport 005795624Q4.2 closed ranjith_qualiantech_com POS2 - Return reason could not be added for unverified returns 
caused by defect 0056934 closed fofarril Return Line without return reason 
has duplicate defect 0057236 closed ranjith_qualiantech_com [Return Input] On converted return, previous reasons already entered are asked again when adding a new product 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-01-29 15:38jfvaringotNew Issue
2025-01-29 15:38jfvaringotAssigned To => Retail
2025-01-29 15:38jfvaringotTriggers an Emergency Pack => No
2025-01-30 07:16ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2025-01-30 08:51ranjith_qualiantech_comRelationship addedcaused by 0056934
2025-01-31 14:43inaki_azkonobietaOBNetwork customer => OBPS
2025-01-31 14:43inaki_azkonobietaIssue Monitored: inaki_azkonobieta
2025-02-02 13:00ranjith_qualiantech_comRegression level => Packaging and release
2025-02-02 13:00ranjith_qualiantech_comRegression date => 2024-11-18
2025-02-02 13:00ranjith_qualiantech_comRegression introduced in release => main
2025-02-02 13:00ranjith_qualiantech_comRegression introduced by commit => https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f83f2bd4a99014cfe9b4f8703c046f5d77817d1e [^]
2025-02-03 07:02hgbotMerge Request Status => open
2025-02-03 07:02hgbotNote Added: 0175007
2025-02-03 07:40ranjith_qualiantech_comStatusnew => scheduled
2025-02-11 12:58hgbotNote Added: 0175477
2025-02-12 07:57ranjith_qualiantech_comStatusscheduled => acknowledged
2025-02-12 07:57ranjith_qualiantech_comStatusacknowledged => scheduled
2025-02-15 10:25hgbotMerge Request Statusopen => approved
2025-02-15 10:26hgbotResolutionopen => fixed
2025-02-15 10:26hgbotStatusscheduled => closed
2025-02-15 10:26hgbotNote Added: 0175679
2025-02-15 10:26hgbotFixed in Version => 25Q2
2025-02-15 10:26hgbotNote Added: 0175680
2025-02-15 10:26hgbotNote Added: 0175681
2025-02-15 10:26hgbotNote Added: 0175682
2025-02-15 10:29marvintmNote Added: 0175683
2025-02-16 08:33marvintmRelationship addedhas duplicate 0057236

Notes
(0175007)
hgbot   
2025-02-03 07:02   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3444 [^]
(0175477)
hgbot   
2025-02-11 12:58   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1761 [^]
(0175679)
hgbot   
2025-02-15 10:26   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3444 [^]
(0175680)
hgbot   
2025-02-15 10:26   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6d8b315cb22711036998c95d7a647e146215797b
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 15-02-2025 08:46:28
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/6d8b315cb22711036998c95d7a647e146215797b [^]

Fixed ISSUE-57794: Validate UserInput when adding line in Blind Return
* Refactored UserInput validation with addProduct actionPreparation instead of
  UserAction AddProduct's PostHook

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/ReturnBlindTicket.js
---
(0175681)
hgbot   
2025-02-15 10:26   
Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 165bfcce29581e53d2af56f92455c9d43b768bb0
Author: Ranjith S R <r.rangaraju@external.orisha.com>
Date: 15-02-2025 08:43:50
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/165bfcce29581e53d2af56f92455c9d43b768bb0 [^]

Related to ISSUE-57794: Added payload for approvalSummaryContent in UserAction

---
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
---
(0175682)
hgbot   
2025-02-15 10:26   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1761 [^]
(0175683)
marvintm   
2025-02-15 10:29   
Tested the following cases:
- On an existing ticket, when executing "Convert to return":
   - Mandatory inputs must be specified
   - Optional inputs can be skipped
   - Cancelling the process cancels the action, order is still an order
   - Completing the process sets the input values at line level correctly in the backoffice
- On an existing ticket, after transforming to return:
   - Adding a product raises the inputs for the new line
   - Mandatory inputs must be specified
   - Optional inputs can be skipped
   - Cancelling the process cancels the action, line is never added
   - Completing the process adds the negative line with the correct input values in the backoffice