Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057783POS2Corepublic2025-01-28 15:512025-02-23 18:50
Reporterdorian_robillard 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057783: when a pop up is opened in the POS and use the scan to fill a field, is trying to add a product
DescriptionI have 2 case identified :
- approval pop up
- Product activation

When the pop up is opened the cursor is in a field and when scanning an EAN (User for approval or serial number for product activation). POS is trying to add an EAN and display the pop up :
Unknown product
The product EAN that you scanned is not recognized (see attachment)

== note that in this issue only the approval popup fix will be done. the product action flow is not owned by the platform base team

For product activation, it is a big issue because they have ID to enter with more of 20 digits and an error can be activate a bad product
Steps To ReproduceFor approval

Connect to POS change profile VallBlancaCashier

Add a product
Modify price --> Approval is required
Scan an EAN

The error message is diplayed
Proposed SolutionUpdate the behaviour of those two inputs, so that instead of triggering the scan event handler, the scanned code is pasted into the input
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005788425Q1 closed AugustoMauch when a pop up is opened in the POS and use the scan to fill a field, is trying to add a product 
Attached Filespng Capture d’écran 2025-01-28 152419.png (49,962) 2025-01-28 15:51
https://issues.openbravo.com/file_download.php?file_id=20805&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2025-01-28 15:51dorian_robillardNew Issue
2025-01-28 15:51dorian_robillardAssigned To => Triage Platform Base
2025-01-28 15:51dorian_robillardFile Added: Capture d’écran 2025-01-28 152419.png
2025-01-28 15:51dorian_robillardTriggers an Emergency Pack => No
2025-01-28 15:55victor_perezOBNetwork customer => OBPS
2025-01-28 15:55victor_perezAssigned ToTriage Platform Base => Retail
2025-01-29 06:56jorgewederagoNote Added: 0174830
2025-01-29 06:56jorgewederagoAssigned ToRetail => Triage Platform Base
2025-02-04 13:19AugustoMauchProposed Solution updated
2025-02-04 13:19AugustoMauchStatusnew => acknowledged
2025-02-05 17:33hgbotMerge Request Status => open
2025-02-05 17:33hgbotNote Added: 0175185
2025-02-05 17:42AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2025-02-05 17:42AugustoMauchStatusacknowledged => scheduled
2025-02-05 17:43AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=29187#r29187
2025-02-06 10:50AugustoMauchStatusscheduled => resolved
2025-02-06 10:50AugustoMauchResolutionopen => fixed
2025-02-06 10:50AugustoMauchStatusresolved => new
2025-02-06 10:50AugustoMauchResolutionfixed => open
2025-02-06 10:51AugustoMauchStatusnew => scheduled
2025-02-10 01:30hgbotMerge Request Statusopen => approved
2025-02-10 09:51hgbotNote Added: 0175375
2025-02-10 09:51hgbotResolutionopen => fixed
2025-02-10 09:51hgbotStatusscheduled => closed
2025-02-10 09:51hgbotFixed in Version => 25Q2
2025-02-10 09:51hgbotNote Added: 0175376
2025-02-23 18:50hgbotFixed in Version25Q2 => 25Q1
2025-02-23 18:50hgbotNote Added: 0176051

Notes
(0174830)
jorgewederago   
2025-01-29 06:56   
I think this should be handled by Platform Teams.
*The part about approvals as far as I know is their infra and makes sense to centralize the fix
*The part about product activation I think it was handled originally by Platform connectors so may make sense for them to handle that case.

Do not hesitate to contact me if needed
(0175185)
hgbot   
2025-02-05 17:33   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1754 [^]
(0175375)
hgbot   
2025-02-10 09:51   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1754 [^]
(0175376)
hgbot   
2025-02-10 09:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 3b068032375ae41656396d5129868e92230e922a
Author: Augusto Mauch <amauch@orisha.com>
Date: 10-02-2025 08:50:43
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/3b068032375ae41656396d5129868e92230e922a [^]

Fixes ISSUE-57783: It is possible to scan employee codes into approval username

---
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---
(0176051)
hgbot   
2025-02-23 18:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 14c582b06dd3100170c86ba1b368fad82682fab5
Author: Augusto Mauch <amauch@orisha.com>
Date: 23-02-2025 18:50:11
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.core2/-/commit/14c582b06dd3100170c86ba1b368fad82682fab5 [^]

Fixes ISSUE-57783: It is possible to scan employee codes into approval username

---
M web-jspack/org.openbravo.core2/src/core/security/requestInputAndApproval.js
---